Received-SPF: pass (google.com: domain of linux-kernel+bounces-15136-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 3 Jan 2024 11:34:12 +0800
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: chrome-platform@lists.linux.dev, kernel-janitors@vger.kernel.org,
	Benson Leung <bleung@chromium.org>,
	=?iso-8859-1?Q?G=FCnter_R=F6ck?= <groeck@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/chrome: cros_ec_i2c: Less function calls in
 cros_ec_cmd_xfer_i2c() after error detection
Message-ID: <ZZTVtOumDlR4iZPa@google.com>
References: <5db36d2b-afe0-4027-b22e-ded163a409be@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5db36d2b-afe0-4027-b22e-ded163a409be@web.de>

On Thu, Dec 28, 2023 at 08:56:38AM +0100, Markus Elfring wrote:
> The kfree() function was called in up to two cases by
> the cros_ec_cmd_xfer_i2c() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
> 
> * Adjust jump targets.
> 
> * Delete two initialisations which became unnecessary
>   with this refactoring.

The patch saves few instructions but makes the code less readable a bit.  I
would prefer to leave the code as is or wait for other reviewers' input.