Received-SPF: pass (google.com: domain of linux-kernel+bounces-15192-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231229081409.1276386-1-menglong8.dong@gmail.com>
 <ZZRR1q1JrJMD1lAy@google.com> <c628c362-b2e8-4ad6-a34f-50c2822bccd6@linux.dev>
 <CADxym3bPjdErhZ_wgQNK3BqbeUgvGMtLJRA_rD3pRa+BVcA95A@mail.gmail.com> <4fa8ae9d-11fd-4728-83bd-848cb22952e7@linux.dev>
In-Reply-To: <4fa8ae9d-11fd-4728-83bd-848cb22952e7@linux.dev>
From: Menglong Dong <menglong8.dong@gmail.com>
Date: Wed, 3 Jan 2024 14:03:02 +0800
Message-ID: <CADxym3aYT6ftPMFiuMSiTpNEYpvPz1p3rEtK6bX2_N=BreXOzQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next 0/2] bpf: add csum/ip_summed fields to __sk_buff
To: Yonghong Song <yonghong.song@linux.dev>
Cc: Martin KaFai Lau <martin.lau@linux.dev>, Stanislav Fomichev <sdf@google.com>, andrii@kernel.org, 
	ast@kernel.org, daniel@iogearbox.net, song@kernel.org, 
	john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com, 
	jolsa@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, 
	pabeni@redhat.com, mykolal@fb.com, shuah@kernel.org, horms@kernel.org, 
	dhowells@redhat.com, linyunsheng@huawei.com, aleksander.lobakin@intel.com, 
	joannelkoong@gmail.com, laoar.shao@gmail.com, kuifeng@meta.com, 
	bjorn@rivosinc.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 3, 2024 at 11:55=E2=80=AFAM Yonghong Song <yonghong.song@linux.=
dev> wrote:
>
>
> On 1/2/24 6:54 PM, Menglong Dong wrote:
> > On Wed, Jan 3, 2024 at 8:52=E2=80=AFAM Martin KaFai Lau <martin.lau@lin=
ux.dev> wrote:
> >> On 1/2/24 10:11 AM, Stanislav Fomichev wrote:
> >>> On 12/29, Menglong Dong wrote:
> >>>> For now, we have to call some helpers when we need to update the csu=
m,
> >>>> such as bpf_l4_csum_replace, bpf_l3_csum_replace, etc. These helpers=
 are
> >>>> not inlined, which causes poor performance.
> >>>>
> >>>> In fact, we can define our own csum update functions in BPF program
> >>>> instead of bpf_l3_csum_replace, which is totally inlined and efficie=
nt.
> >>>> However, we can't do this for bpf_l4_csum_replace for now, as we can=
't
> >>>> update skb->csum, which can cause skb->csum invalid in the rx path w=
ith
> >>>> CHECKSUM_COMPLETE mode.
> >>>>
> >>>> What's more, we can't use the direct data access and have to use
> >>>> skb_store_bytes() with the BPF_F_RECOMPUTE_CSUM flag in some case, s=
uch
> >>>> as modifing the vni in the vxlan header and the underlay udp header =
has
> >>>> no checksum.
> >> There is bpf_csum_update(), does it work?
> >> A helper call should be acceptable comparing with the csum calculation=
 itself.
> > Yeah, this helper works in this case! Now we miss the last
> > piece for the tx path: ip_summed. We need to know if it is
> > CHECKSUM_PARTIAL to decide if we should update the
> > csum in the packet. In the tx path, the csum in the L4 is the
> > pseudo header only if skb->ip_summed is CHECKSUM_PARTIAL.
> >
> > Maybe we can introduce a lightweight kfunc to get its
> > value? Such as bpf_skb_csum_mode(). As we need only call
> > it once, there shouldn't be overhead on it.
>
> You don't need kfunc, you can do checking like
>    struct sk_buff *kskb =3D bpf_cast_to_kern_ctx(skb);
>    if (kskb->ip_summed =3D=3D CHECKSUM_PARTIAL) ...
>    ...
>

Great, this is exactly what I need! Thanks~