Received-SPF: pass (google.com: domain of linux-kernel+bounces-15218-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <96f1e8d4-18fc-461e-9916-f7ddd6ea4b26@linux.dev>
Date: Wed, 3 Jan 2024 14:47:11 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] RDMA/rxe: Fix port state on associating netdev
 successfully
To: zhenwei pi <pizhenwei@bytedance.com>, zyjzyj2000@gmail.com, jgg@ziepe.ca,
 leon@kernel.org
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240103020133.664928-1-pizhenwei@bytedance.com>
From: Zhu Yanjun <yanjun.zhu@linux.dev>
In-Reply-To: <20240103020133.664928-1-pizhenwei@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

在 2024/1/3 10:01, zhenwei pi 写道:
> Originally, after adding a RXE device successfully, the RXE device
> gets ready, it still reports 'PORT_DOWN' state. Set the state to
> *IB_PORT_ACTIVE* once it becomes ready to access.

IB_PORT_ACTIVE is set in the function rxe_port_up.

The followings are the call chain.

rxe_net_add -- > rxe_register_device -- > ib_register_device -- > 
enable_device_and_get -- > rxe_enable_driver -- > rxe_set_port_state -- 
 > rxe_port_up

In this commit, in rxe_net_add, the port->attr.state is set to 
IB_PORT_ACTIVE.

But then in the function rxe_init_port_param, port->attr.state is set to 
IB_PORT_DOWN again.

Zhu Yanjun

> 
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>   drivers/infiniband/sw/rxe/rxe_net.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index cd59666158b1..eafcb2351a7b 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -524,6 +524,7 @@ int rxe_net_add(const char *ibdev_name, struct net_device *ndev)
>   {
>   	int err;
>   	struct rxe_dev *rxe = NULL;
> +	struct rxe_port *port;
>   
>   	rxe = ib_alloc_device(rxe_dev, ib_dev);
>   	if (!rxe)
> @@ -537,6 +538,11 @@ int rxe_net_add(const char *ibdev_name, struct net_device *ndev)
>   		return err;
>   	}
>   
> +	if (netif_running(ndev) && netif_carrier_ok(ndev)) {
> +		port = &rxe->port;
> +		port->attr.state = IB_PORT_ACTIVE;
> +	}
> +
>   	return 0;
>   }
>