Received-SPF: pass (google.com: domain of linux-kernel+bounces-15253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Swee, Leong Ching" <leong.ching.swee@intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
CC: Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S .
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, Teoh Ji Sheng <ji.sheng.teoh@intel.com>
Subject: RE: [PATCH net-next v1 3/4] net: stmmac: Add support for TX/RX
 channel interrupt
Thread-Topic: [PATCH net-next v1 3/4] net: stmmac: Add support for TX/RX
 channel interrupt
Thread-Index: AQHaNJox4jd+E/aBcUiXrRKS2mOw+bC12C8AgBHyAHA=
Date: Wed, 3 Jan 2024 07:57:23 +0000
Message-ID: <CH0PR11MB54909520AD7A8B5FE4C68334CF60A@CH0PR11MB5490.namprd11.prod.outlook.com>
References: <20231222054451.2683242-1-leong.ching.swee@intel.com>
 <20231222054451.2683242-4-leong.ching.swee@intel.com>
 <qyiveqz3egzctymkwflgw4u6ubnpiss2x244fsepop7t3ve7ev@7x24oaiferuy>
In-Reply-To: <qyiveqz3egzctymkwflgw4u6ubnpiss2x244fsepop7t3ve7ev@7x24oaiferuy>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FPufNI5ATofH+7CZ1I/8pRGQax7iQ9wryZUJ8jAUUL3oFF8MKVvyFKGVtdnw?=
 =?us-ascii?Q?XwtV4yB+aLg8y62QwMuk32wgAH1P4sPqaegaasBacOxdLE1QFOrmnxGlqb7H?=
 =?us-ascii?Q?ziQJnqUhobb+yX/XXRz4iT8/NJq7ivlwV1muBrinvMU3VfE2EhhCRd29gE8v?=
 =?us-ascii?Q?s57EDdYvM/ncEElxocSz2sqnKIGZtekGT5Fe4d3vmJzc/7nYJ/VGqsb1JdaP?=
 =?us-ascii?Q?og6UL6AaDDnuQ2oja2k84uK0dLPzJ1g1EdOgIwdGVWW1TKhKsHi763EzRIdZ?=
 =?us-ascii?Q?Z4SqF58HAqOlY9kfFIsqQ1jRv7g7nB0y+M1rOtYlYmoV5EKU3gXGzoubIepa?=
 =?us-ascii?Q?7NIcQvpnx2SpV4dqV1IogLAgvdY8v13XWLtFcjC1j+jsSrhmlnpR5NJU8JaG?=
 =?us-ascii?Q?Ye1MtT29MerAv0jf1P/xV3jKSKwCIE4zwSmL3jYlf8OgfdJig81jzp9Jukiz?=
 =?us-ascii?Q?tqcgnGjTOlxcgHtL8EE5JJvBVfuYNdZkEbS8ibonhlrEpxwV6IecoCgkviBI?=
 =?us-ascii?Q?ywPHwEZjsW7OiSzfU4jF0EaIfryl+aBkjBdrbosiS3m/YasHS2Vq/uF32QJl?=
 =?us-ascii?Q?sQ5qV0BCf1W/aMheqQDpjHCIWMQZFQI2wEXfYBteF2oZihIUrSSzei0KlEE+?=
 =?us-ascii?Q?2j9jRqo8eecgUaf5B7UIoNSj+ieLq5j7O3ewUrhDT5ehlNOcJrthaXyJu0OJ?=
 =?us-ascii?Q?wVc/iyzOivRU5NdGA/v+XneMATy2/hViuF4n0h8sabexeRraVoXxdC0BJ5NB?=
 =?us-ascii?Q?NuvYvGct1OStrvv8FJfPx1W4mzlDN7Y11xEnZyxqtX2w0YP6JHQ/DTIOdClD?=
 =?us-ascii?Q?3h/AZODA1gjm/PXBBuSi0ZHRgwvNJTlvSEdguZ906HNL6M7WskKHsTpHFvg6?=
 =?us-ascii?Q?mWQ9Sk2ohKlHM+XBLwAlXI1zVQ0b/efC8Tn4kuSotv+gy3ha5eO7+zpnsoSM?=
 =?us-ascii?Q?94YyzxI81P8VgYd32x1m0h0UF2CjDckhi7fvSnKPPHMxW7uohjTwoooHY6FY?=
 =?us-ascii?Q?AFFvJjLwGxQdBEsX1qsGhVfNmmvmAiASqnschrK6Lq2SaQBZN+j/6gfOCRq/?=
 =?us-ascii?Q?bEjHIz7Cxoj6dHxdjTnx9KV5PVwCVSnvMf8cSqvAlq1U+UqzWRrKdUJG4TAA?=
 =?us-ascii?Q?z3VE7q4Ohjj9dvn/8sT6OqhUCkjysZzDMjP19hwyt17zAeNgCatUvrcwzYhs?=
 =?us-ascii?Q?4FgbIL99Tlz8phXUNUzUaREPST5xf+t5vDDr2/vUh+pCsWowzhVHc5BIGaeG?=
 =?us-ascii?Q?XbteeDZFhVpOqaSets+9mrJTaNRPjHM5nBxom09VL0bEYmUMxOLZHH0BoK1m?=
 =?us-ascii?Q?krEF5uYfIxceu7jAvc06j2dAbigfQuu8GPpJ+tqVOyuQH1JVSpg1QFMBLKe6?=
 =?us-ascii?Q?ZNYgbOrHW+yKMMQDvr3sjpH8n8ClVQbH0mjF0hwOkiQhTge6p3ozduQV8uMp?=
 =?us-ascii?Q?vl3s1vmWGaQpCFb6sLonoS0AhHiwRWeGYYfVke4lRg16kxKut7xSBoKYkmgM?=
 =?us-ascii?Q?mXEX+K03CR5UIHr3RcuBYrc0PomvlNQOeZ/KLTjBDMZcJ+exdtXFVSOEPLKA?=
 =?us-ascii?Q?TnrLZVHn1Ca8DHlOvtj7jMsLvk/5ALatthGRhbdfSqODaKkBsUKBoAUfJ2Fq?=
 =?us-ascii?Q?YA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5490.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d110b593-97ba-4e44-359c-08dc0c319e82
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2024 07:57:23.1675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7g7aEZKYlFE9+1sHvQ/nLVDM26zyyfqUBp42atoj1KJ3idJYmyIbrBYJliIw8D3ND4r2rvB2uAU1QZZ73sYhV7oZmzlxReSNfXTtDw6CpJs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5337
X-OriginatorOrg: intel.com

> -----Original Message-----
> From: Serge Semin <fancer.lancer@gmail.com>
> Sent: Saturday, December 23, 2023 5:49 AM
> To: Swee, Leong Ching <leong.ching.swee@intel.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>; Alexandre Torgue
> <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>;
> David S . Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Giuseppe Cavallaro <peppe.cavallaro@st.com>;
> linux-stm32@st-md-mailman.stormreply.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; devicetree@vger.kernel.org; Teoh Ji Sheng
> <ji.sheng.teoh@intel.com>
> Subject: Re: [PATCH net-next v1 3/4] net: stmmac: Add support for TX/RX
> channel interrupt
>=20
> On Fri, Dec 22, 2023 at 01:44:50PM +0800, Leong Ching Swee wrote:
> > From: Swee Leong Ching <leong.ching.swee@intel.com>
> >
> > Enable TX/RX channel interrupt registration for MAC that interrupts
> > CPU through shared peripheral interrupt (SPI).
> >
> > Per channel interrupts and interrupt-names are registered through,
> > Eg: 4 tx and 4 rx channels:
> > interrupts =3D <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>,
> >              <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
> >              <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> >              <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> >              <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> >              <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
> >              <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> >              <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>; interrupt-names =3D
> > "dma_tx0",
> >                   "dma_tx1",
> >                   "dma_tx2",
> >                   "dma_tx3",
> >                   "dma_rx0",
> >                   "dma_rx1",
> >                   "dma_rx2",
> >                   "dma_rx3";
> >
> > Signed-off-by: Teoh Ji Sheng <ji.sheng.teoh@intel.com>
> > Signed-off-by: Swee Leong Ching <leong.ching.swee@intel.com>
> > ---
> >  .../ethernet/stmicro/stmmac/stmmac_platform.c | 24
> > +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > index 70eadc83ca68..f857907f13a0 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> > @@ -710,6 +710,8 @@
> EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt);
> >  int stmmac_get_platform_resources(struct platform_device *pdev,
> >  				  struct stmmac_resources *stmmac_res)  {
>=20
> > +	char irq_name[8];
>=20
> By DW XGMAC v2.x IP-core design there can be up to 16 Tx channels and
> 12 Rx channels. Thus it's better to set irq_name size being at least
> (strlen("dma_tx16") + 1) =3D=3D 9 beforehand since you are adding this co=
de
> anyway and for some reason didn't consider to pick the Jisheng'
> patch up which fixed the MTL_MAX_TX_QUEUES/MTL_MAX_RX_QUEUES
> macros.
>=20
I only have 8 channels tx/rx dma irq setup, so I could not test 16 channels
Patch. Will update to 9 in v2.
> > +	int i;
>=20
> Please add an empty line between the variables declaration and the next
> statement.
>=20
Thanks. Will update this in v2.
> >  	memset(stmmac_res, 0, sizeof(*stmmac_res));
> >
> >  	/* Get IRQ information early to have an ability to ask for deferred
> > @@ -719,6 +721,28 @@ int stmmac_get_platform_resources(struct
> platform_device *pdev,
> >  	if (stmmac_res->irq < 0)
> >  		return stmmac_res->irq;
> >
>=20
> > +	/* For RX Channel */
> > +	for (i =3D 0; i < MTL_MAX_RX_QUEUES; i++) {
> > +		snprintf(irq_name, sizeof(irq_name), "dma_rx%i", i);
> > +		stmmac_res->rx_irq[i] =3D
> platform_get_irq_byname_optional(pdev, irq_name);
> > +		if (stmmac_res->rx_irq[i] < 0) {
> > +			if (stmmac_res->rx_irq[i] =3D=3D -EPROBE_DEFER)
> > +				return -EPROBE_DEFER;
> > +			break;
> > +		}
> > +	}
>=20
> What about:
>=20
> +	/* Get optional Tx/Rx DMA per-channel IRQs, which otherwise
> +	 * are supposed to be delivered via the common MAC IRQ line
> +	 */
> +	for (i =3D 0; i < MTL_MAX_RX_QUEUES; i++) {
> +		snprintf(irq_name, sizeof(irq_name), "dma_rx%i", i);
> +		irq =3D platform_get_irq_byname_optional(pdev, irq_name);
> +		if (irq =3D=3D -EPROBE_DEFER)
> +			return irq;
> +		else if (irq < 0)
> +			break;
> +
> +		stmmac_res->rx_irq[i] =3D irq;
> +	}
>=20
> It's cleaner a bit with less indentations and doesn't pollute rx_irq[]/tx=
_irq[]
> arrays with the error numbers.
>=20
Sure, will update this in v2.
> > +
> > +	/* For TX Channel */
> > +	for (i =3D 0; i < MTL_MAX_TX_QUEUES; i++) {
> > +		snprintf(irq_name, sizeof(irq_name), "dma_tx%i", i);
> > +		stmmac_res->tx_irq[i] =3D
> platform_get_irq_byname_optional(pdev, irq_name);
> > +		if (stmmac_res->tx_irq[i] < 0) {
> > +			if (stmmac_res->rx_irq[i] =3D=3D -EPROBE_DEFER)
> > +				return -EPROBE_DEFER;
> > +			break;
> > +		}
> > +	}
> > +
>=20
> Please move the Tx/Rx IRQs getting loops to the bottom of the
> stmmac_get_platform_resources() method. Thus the order of the IRQs
> getting would be the same as the order of the IRQs requests implemented i=
n
> the stmmac_request_irq_multi_msi() and
> stmmac_request_irq_single() methods.
>=20
> -Serge(y)
>=20
Will move those methods to bottom in v2.
> >  	/* On some platforms e.g. SPEAr the wake up irq differs from the
> mac irq
> >  	 * The external wake up irq can be passed through the platform code
> >  	 * named as "eth_wake_irq"
> > --
> > 2.34.1
> >
> >