Received-SPF: pass (google.com: domain of linux-kernel+bounces-15279-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 3 Jan 2024 09:40:13 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: POPESCU Catalin <catalin.popescu@leica-geosystems.com>
Cc: "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
 "michael@walle.cc" <michael@walle.cc>, "rafal@milecki.pl"
 <rafal@milecki.pl>, "robh@kernel.org" <robh@kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 GEO-CHHER-bsp-development <bsp-development.geo@leica-geosystems.com>, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Luca Ceresoli
 <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH] nvmem: fix issue within nvmem_register with
 fixed-layout.
Message-ID: <20240103094013.2672cb7d@xps-13>
In-Reply-To: <20231205100502.623863ff@xps-13>
References: <20231130162922.2989774-1-catalin.popescu@leica-geosystems.com>
	<16c4c272-1a19-4fb8-8a2d-b2cf61ba37f2@leica-geosystems.com>
	<20231205100502.623863ff@xps-13>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Catalin,

miquel.raynal@bootlin.com wrote on Tue, 5 Dec 2023 10:05:02 +0100:

> Hi Catalin,
>=20
> + GKH
> + Luca (who initially reported this issue)
>=20
> catalin.popescu@leica-geosystems.com wrote on Tue, 5 Dec 2023 08:48:27
> +0000:
>=20
> > Adding more people.
> >=20
> > On 30.11.23 17:29, Catalin Popescu wrote:
> > > fixed-layout is natively supported by NVMEM framework.
> > > Yet, it's not been declared as a supported layout. As a
> > > result, nvmem_register always returns -EPROBE_DEFER if
> > > configuration has no layout and the NVMEM provider DT
> > > uses a fixed layout.
> > >
> > > As a fix, declare fixed-layout as a supported layout
> > > and use add_cells callback to parse the cells. This adds
> > > consistency over layouts parsing as fixed-layout parsing
> > > is handled in the same way than others nvmem layouts.
>=20
> I believe this patch (not taken yet) should fix your issue and should be
> queued to fixes.
>=20
> Link: https://lore.kernel.org/lkml/20231124193814.360552-1-miquel.raynal@=
bootlin.com/
>=20
> However I like your approach which should probably be taken into
> consideration for the next cycle, as I think it fits Rafal's
> original idea pretty well.

Do you plan on updating this patch at -rc1? I think it would be
interesting to follow your idea.

Thanks,
Miqu=C3=A8l