Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7002799rdb; Wed, 3 Jan 2024 00:47:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqAer+avEB8r/hFQSCK0clNr6Y56MohqyjbHoI/canF4g3SP8bTUYw+gL1vYYt2RiDOQ6z X-Received: by 2002:a17:90a:f007:b0:28c:c667:450c with SMTP id bt7-20020a17090af00700b0028cc667450cmr2533508pjb.66.1704271663601; Wed, 03 Jan 2024 00:47:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704271663; cv=none; d=google.com; s=arc-20160816; b=V8sQfbxJnr5AW0Qu4xCRY+wnL/ECpey9CaLiJXKi9re45U4aGUFA77hoF7zhvJwiPn uoZhS6PNTyGaoMB7+XtY5m6WbL2gBH5b3d1WJ+o61cwloPctENSbxnqK+1fdytiKzirT +UBinNCP6gNCg4tWus6kiQMEvuI05wwfM9cbmy6uUMbYkDkBOyKA1YgkoCGWD2AgeNoB WqhDwPMQ3HmkF8GxoKprjHFrV7Cf1Oe4GCpOQ73+qa1LsbfJoFS9+VFmNdXIwGO6/IBp vIwQfN6BJ3IATDyN8RmU05ow9glpnUP6HDZVAdEUSh4TGkK/A2ao9CC/7L2rVx97rv+B 8+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=S1g5lIBQVgYT+w+mPslzeSD45B7fzqMjAF8opZY3q3c=; fh=+StYV2A1mCnV5FlrB/uRodcOrlLFELas49npWomYASI=; b=rxf2CH4x4Hh2X8/FmaanPcGb0OrJr+cP+ftVgYRnCqhZNQlKMXcKDGrNznBuc7eld+ IRvBTZVj/X0ax0/ajU5pepfVSygItWMdG/65h29yExIv1fBBlioO9llFrpT7o+AsdSfJ By0oSB7+fTteqV8vfdC3CNCSDkws5o1gjZuI5kXyaC1HWK/LVm6+zCEQ3p9NHViMHuzc qwQh/GUn44KwPq+Uuzng2qI/6bOC6jkrm32FZOH666GX9va7l9umOOa3a+V9a38huzTj pCJLaxWgneNUxArqPVIpMm/zA+NVO+/jhZVeHKQkgzu6Te7FXWmexm0XU+fCON/7a9Fb q3WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-15285-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15285-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c22-20020a17090aa61600b0028cbd8d3293si865849pjq.159.2024.01.03.00.47.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 00:47:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15285-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-15285-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15285-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4922F285149 for ; Wed, 3 Jan 2024 08:47:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 494901805F; Wed, 3 Jan 2024 08:47:35 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5AC18049; Wed, 3 Jan 2024 08:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowAAH6AwZH5Vl66EnAw--.36358S2; Wed, 03 Jan 2024 16:47:21 +0800 (CST) From: Chen Ni To: patrice.chotard@foss.st.com, linus.walleij@linaro.org, bartosz.golaszewski@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to transfer the error Date: Wed, 3 Jan 2024 08:50:58 +0000 Message-Id: <20240103085058.3771653-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:zQCowAAH6AwZH5Vl66EnAw--.36358S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtw4rtr1fuw1kZw4rJr45Awb_yoWfZrX_Ca 4fWFy7JryUC3WkWr1ayw13XFyIkanrXF10vFsYqr1akry5Cw4qv3s7urW5G3s7WrW7J345 GrWDXryrAw47AjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jw0_WrylYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r43 MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjYLvtUUUUU== X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Return pinctrl_gpio_direction_output() in order to transfer the error if it fails. Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()") Signed-off-by: Chen Ni --- drivers/pinctrl/pinctrl-st.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 1485573b523c..5d9abd6547d0 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -723,9 +723,8 @@ static int st_gpio_direction_output(struct gpio_chip *chip, struct st_gpio_bank *bank = gpiochip_get_data(chip); __st_gpio_set(bank, offset, value); - pinctrl_gpio_direction_output(chip, offset); - return 0; + return pinctrl_gpio_direction_output(chip, offset); } static int st_gpio_get_direction(struct gpio_chip *chip, unsigned offset) -- 2.25.1