Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7004022rdb; Wed, 3 Jan 2024 00:51:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSXFge+A8X5AoLRsSYHDxkQa1OMMRTFeLPLX+jR2fzAjJQh2w/XT0qHKNs4sbM96Ss0Pxv X-Received: by 2002:a05:6830:610e:b0:6dc:1ddd:b7ff with SMTP id ca14-20020a056830610e00b006dc1dddb7ffmr9317826otb.49.1704271896774; Wed, 03 Jan 2024 00:51:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704271896; cv=none; d=google.com; s=arc-20160816; b=MGxFrweVO6zdk8thhWmJE/cno5NEvb6vzhxZG2DV4v29x6QQ+m0ls0YgRQlYQMvpKA SMfjPo+x04VUjo0O09RgfZ6RKt9WgT6g4Kn1JAyelevFRqTMh9Nv4Cxc3oNHrbd0O61U YKP+IjE1wbM2BhUq9EiphIQfzpQuTxUSJkp7XGa28/piG3frtX+QxrGptanl51gHpl8E fjvgtitzjvlUiJrFrGlBoUK6djSPX1rDEOJw/a8xmgo1hqdu+5HCeCO3X454TnwPecyq zDLlQ0up0nzIAawDxfpR0gDpU+pjFezDaQyfmeJWLX7iQxyF9yDjgfTfuIXfr90Kg0z4 oqXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:references:in-reply-to :user-agent:subject:cc:to:from:date:dkim-signature; bh=XiqjQ4CtsdHzeZ/6fpkEoYxayaW7/f/QwsswQ02BtUY=; fh=U4K+Rr5pY8wh9Z23+Twr0s8SlZY5Uc+3au4AZy4Mr2I=; b=AAz7uJ7OkaMnvrLpnz5mdJPrDluGTi46dzE3bTf2jk2agGNZOYshEBBrTwQAq9QHGT GsilZCcX5kHQcm69/oNdpNekqIEhlQoMisNyn9w9tiBDwVPO1UK8c47i6/Th03pKbxg9 XeSqx5IaKKxIFLSuvEe3TuNgGiOwWO2KPy3W0m+TDmmEL6V5wTbTWX05ql7tvnfR952T dujw7fSIhpLzBpV63YFT0gJ/Elly+Fejf2OEpONVy9ZcT2DWfipXwBE9M/RVNUtgqy9k b8Hb/t9pHu1p5YNikOf64+SrcN33eaSBGFTwqpDNhBDxekmzhLkjyJrPUQGpalFkL4S8 Khyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QHTbpHjv; spf=pass (google.com: domain of linux-kernel+bounces-15289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bs6-20020a632806000000b005cdfd3960f4si17905819pgb.677.2024.01.03.00.51.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 00:51:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=QHTbpHjv; spf=pass (google.com: domain of linux-kernel+bounces-15289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15289-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7AF0CB22C8F for ; Wed, 3 Jan 2024 08:51:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F363C18625; Wed, 3 Jan 2024 08:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QHTbpHjv" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF2E9182B9; Wed, 3 Jan 2024 08:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-55676f1faa9so1780607a12.0; Wed, 03 Jan 2024 00:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704271866; x=1704876666; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=XiqjQ4CtsdHzeZ/6fpkEoYxayaW7/f/QwsswQ02BtUY=; b=QHTbpHjv+Cw0zzcEmh87ZdwKKKK4xZKOOPqunMP8nY07GPih+Pwyy+1vi9nRCk89Z4 ++mqwurighPZGOBt0Cdzvv+bkrLdFGPRlNSinov/LChUTJyz+w55cuJm/251VIpTq+DC wbwKNdJjvaPIo0DdUsWt0hPp1HKqY/gikjcr93vHInEjIgI1kMgZW9CHxPtqoKBp/YDk CzBsdsmr+HlbtVWfgLk9OoerTmsB81Sv1iDijBeXGZCGKziOn7lPTdNgx6BC9tABwj8F RDsPJh+RSwKgzXr0ihU6jUkuOcEF4PdjuErMSJMuj4WFSLNIW9ZdEhrGaR9uQ3jDodJg JlZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704271866; x=1704876666; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XiqjQ4CtsdHzeZ/6fpkEoYxayaW7/f/QwsswQ02BtUY=; b=pOX3I2Kn0L0M3wdUvCUZ3/Wi4LreOot8BEypL7EuvFoJJ+4he2QM4tm7i/D/7YWLVX rv9hG6WCiooO/D0tDzM8ZF59hLtWhSrJtBySXl9GiyUGM3QUmAQOkrmJLljzIDSPZu88 cLeBFnAPbywzlJACg7vMnzajyhMLka5Rbo68to1vlsR/hjrvObjOwytmMacQAgPlV5XD OA4Ho8o7QMWQJlRbWgZhQuqcRT6fDjEUOBoY3y+LI9rrQKo5Yi0jy0ukz+TlwkeytXOW fo5ygk5tdfGAZHEp1JW7XlOSB3+yhTY24WC51vaKWpDf2R24jnf/6Y3dulezhSD208Kl Tvxw== X-Gm-Message-State: AOJu0YwafJRaA+x+6dYN4glP8ftzHWtjSAwP9etROcg01wH1jKuZCnXZ 9j4lZa9uwpCIULJJME7Q68s= X-Received: by 2002:aa7:d795:0:b0:552:3044:1df9 with SMTP id s21-20020aa7d795000000b0055230441df9mr10602167edq.67.1704271865117; Wed, 03 Jan 2024 00:51:05 -0800 (PST) Received: from [127.0.0.1] ([89.205.132.224]) by smtp.gmail.com with ESMTPSA id o18-20020aa7dd52000000b00555a0fa2211sm7690447edw.31.2024.01.03.00.51.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jan 2024 00:51:04 -0800 (PST) Date: Wed, 03 Jan 2024 09:51:06 +0100 From: Eric Woudstra To: Daniel Golle CC: "Russell King (Oracle)" , Alexander Couzens , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_RFC_net-next=5D_net=3A_pcs=3A_pcs-mtk-lyn?= =?US-ASCII?Q?xi_fix_mtk=5Fpcs=5Flynxi=5Fget=5Fstate=28=29_for_2500base-x?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20240102074408.1049203-1-ericwouds@gmail.com> <92190426-3614-4774-9E9F-18F121622788@gmail.com> <74223164-ab50-4d6d-a4f4-561b0a70d396@gmail.com> <6666EB36-984E-4898-A41A-2D9713DE4DB0@gmail.com> Message-ID: <654EAEA9-052C-43C6-AA8E-16A30721A916@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >Surely, having phylink take care whether SGMII_SPEED_DUPLEX_AN should be >set would be even nicer=2E > >I believe that source of confusion here is simply that > >in-band-status !=3D SGMII_SPEED_DUPLEX_AN > >We *do* have in-band-status even without having SGMII_SPEED_DUPLEX_AN set >with 2500Base-X link mode (as in: link being up or down and link, duplex >and speed is fixed anyway for 2500Base-X)=2E All clear, and even with autoneg disabled, one way or another, we now have a non-functional 2500base-x=2E Cannot manipulate anything in userland to get the connection functional=2E We need a fix in kernel=2E