Received-SPF: pass (google.com: domain of linux-kernel+bounces-15291-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Subject: Re: [PATCH 4/5] LoongArch: Add paravirt interface for guest kernel
To: Juergen Gross <jgross@suse.com>, Huacai Chen <chenhuacai@kernel.org>,
 Tianrui Zhao <zhaotianrui@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
 virtualization@lists.linux.dev, kvm@vger.kernel.org
References: <20240103071615.3422264-1-maobibo@loongson.cn>
 <20240103071615.3422264-5-maobibo@loongson.cn>
 <66c15a1b-fb28-4653-982f-37494a01cd4f@suse.com>
 <4240d67f-1e5d-f865-c16e-32b64aea8099@loongson.cn>
 <df32d011-49c8-4bdb-a695-41cb6fbdf854@suse.com>
From: maobibo <maobibo@loongson.cn>
Message-ID: <b8b2330d-9057-ff9b-b5aa-483c0f573a72@loongson.cn>
Date: Wed, 3 Jan 2024 16:54:07 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <df32d011-49c8-4bdb-a695-41cb6fbdf854@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit


On 2024/1/3 下午4:14, Juergen Gross wrote:
> On 03.01.24 09:00, maobibo wrote:
>>
>>
>> On 2024/1/3 下午3:40, Jürgen Groß wrote:
>>> On 03.01.24 08:16, Bibo Mao wrote:
>>>> The patch add paravirt interface for guest kernel, it checks whether
>>>> system runs on VM mode. If it is, it will detect hypervisor type. And
>>>> returns true it is KVM hypervisor, else return false. Currently only
>>>> KVM hypervisor is supported, so there is only hypervisor detection
>>>> for KVM type.
>>>
>>> I guess you are talking of pv_guest_init() here? Or do you mean
>>> kvm_para_available()?
>> yes, it is pv_guest_init. It will be better if all hypervisor detection
>> is called in function pv_guest_init. Currently there is only kvm 
>> hypervisor, kvm_para_available is hard-coded in pv_guest_init here.
> 
> I think this is no problem as long as there are not more hypervisors
> supported.
> 
>>
>> I can split file paravirt.c into paravirt.c and kvm.c, paravirt.c is 
>> used for hypervisor detection, and move code relative with pv_ipi into 
>> kvm.c
> 
> I wouldn't do that right now.
> 
> Just be a little bit more specific in the commit message (use the related
> function name instead of "it").
Sure, will do this in next version, and thanks for your guidance.

Regards
Bibo Mao
> 
> 
> Juergen