Received-SPF: pass (google.com: domain of linux-kernel+bounces-15292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240103085058.3771653-1-nichen@iscas.ac.cn>
In-Reply-To: <20240103085058.3771653-1-nichen@iscas.ac.cn>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Wed, 3 Jan 2024 09:56:16 +0100
Message-ID: <CACMJSetTdEOVc5S2tCNzXy3CFmNq+Dh-tB07Kfgw7C3EfEbBSQ@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: st: Return pinctrl_gpio_direction_output to
 transfer the error
To: Chen Ni <nichen@iscas.ac.cn>
Cc: patrice.chotard@foss.st.com, linus.walleij@linaro.org, 
	linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 3 Jan 2024 at 09:47, Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Return pinctrl_gpio_direction_output() in order to transfer the error
> if it fails.
>
> Fixes: b679d6c06b2b ("treewide: rename pinctrl_gpio_direction_output_new()")

It doesn't technically fix this commit as the return value was never
propagated here in the first place.

Anyway:

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Bart

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/pinctrl/pinctrl-st.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1485573b523c..5d9abd6547d0 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -723,9 +723,8 @@ static int st_gpio_direction_output(struct gpio_chip *chip,
>         struct st_gpio_bank *bank = gpiochip_get_data(chip);
>
>         __st_gpio_set(bank, offset, value);
> -       pinctrl_gpio_direction_output(chip, offset);
>
> -       return 0;
> +       return pinctrl_gpio_direction_output(chip, offset);
>  }
>
>  static int st_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> --
> 2.25.1
>