Received-SPF: pass (google.com: domain of linux-kernel+bounces-15294-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231227145143.2399-3-jiangshanlai@gmail.com> <202401031025.95761451-oliver.sang@intel.com>
In-Reply-To: <202401031025.95761451-oliver.sang@intel.com>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Wed, 3 Jan 2024 17:01:33 +0800
Message-ID: <CAJhGHyAsg+AOY4GEE4m-7YA7YPf0hzqMgWTAVsr31Ob49VVXyw@mail.gmail.com>
Subject: Re: [PATCH 2/7] workqueue: Share the same PWQ for the CPUs of a pod
To: kernel test robot <oliver.sang@intel.com>
Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, 
	Tejun Heo <tj@kernel.org>, Naohiro.Aota@wdc.com, 
	Lai Jiangshan <jiangshan.ljs@antgroup.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 3, 2024 at 10:55=E2=80=AFAM kernel test robot <oliver.sang@inte=
l.com> wrote:


Hello 0-DAY CI Kernel Test Team

> If you fix the issue in a separate patch/commit (i.e. not just a new vers=
ion of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@intel.com>
> | Closes: https://lore.kernel.org/oe-lkp/202401031025.95761451-oliver.san=
g@intel.com
>
>
> [   30.471685][    T1] ------------[ cut here ]------------
> [ 30.476998][ T1] WARNING: CPU: 111 PID: 1 at kernel/workqueue.c:4842 des=
troy_workqueue (kernel/workqueue.c:4842 (discriminator 1))

It hits the check here

        if ((pwq !=3D pwq->wq->dfl_pwq) && (pwq->refcnt > 1))
                return true;

Not only is the default pwq installed multiple times, but also other pwqs
with this patch.

Maybe pwq->installed_refcnt needs to be introduced to fix it.

Thanks
Lai