Received-SPF: pass (google.com: domain of linux-kernel+bounces-15395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 3 Jan 2024 11:33:05 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Arnd Bergmann <arnd@arndb.de>, Yu Liao <liaoyu15@huawei.com>,
	Dawei Li <set_pte_at@outlook.com>, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: ac97: fix build regression
Message-ID: <2024010332-sermon-snowy-cf47@gregkh>
References: <20240103102544.3715055-1-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240103102544.3715055-1-arnd@kernel.org>

On Wed, Jan 03, 2024 at 11:25:38AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The ac97_bus_type structure is no longer declared in this file:
> 
> sound/ac97/bus.c: In function 'ac97_codec_add':
> sound/ac97/bus.c:112:27: error: 'ac97_bus_type' undeclared (first use in this function); did you mean 'bus_type'?
>   112 |         codec->dev.bus = &ac97_bus_type;
>       |                           ^~~~~~~~~~~~~
>       |                           bus_type
> sound/ac97/bus.c:112:27: note: each undeclared identifier is reported only once for each function it appears in
> sound/ac97/bus.c: In function 'snd_ac97_codec_driver_register':
> sound/ac97/bus.c:191:28: error: 'ac97_bus_type' undeclared (first use in this function); did you mean 'ac97_bus_reset'?
>   191 |         drv->driver.bus = &ac97_bus_type;
> 
> Include the header that contains the declaration and make sure the definition
> is const but not static.
> 
> Fixes: 66e82d219924 ("ALSA: mark all struct bus_type as const")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  sound/ac97/bus.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Ick, sorry about that, this didn't trigger in all of my build testing,
nor for 0-day, odd.

Anyway, thanks for the fix it is obviously correct:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>