Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7059771rdb; Wed, 3 Jan 2024 03:20:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEScwTG6tjvCTUIGWnVp0N7dXE6YIXPLBB3FyYep2RJvpV0L4lA1wyF3eoqwBW5C6iLk4wF X-Received: by 2002:a05:6358:52d0:b0:173:74e:f419 with SMTP id z16-20020a05635852d000b00173074ef419mr18327844rwz.46.1704280828797; Wed, 03 Jan 2024 03:20:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704280828; cv=none; d=google.com; s=arc-20160816; b=USA2PpR9X6ACiZnLWiln0FzB/PeM4BxA3dvXPnnyBoBXquetewmzbohElsYJU9Ehnp EDFN7quBy8ca7jqoFjBMfGCKi74i8M53JK4PJmRBrk2zYB/yib7fCkvQTGNq/08oUC5u FOpBseuwL39NjsylJ8nd+fJcHaY+XwVHVtPY6WFQlPO5jyww42/jiDpA4nJ+FytTcWdu T27ls9upcfJe75XbLaoTQWVT308U+x5mddn3mP7OflJY/hhBgaCtBGJFZ4eQHKjndO/U 3KANCL1K9Pf6/gBEcQumffxnhfzgCu/Z99FS5VgfD5zlfNhWEdz7dW6/seYKhRFsYrS5 xglw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=pURSsn42YASyjShYaXFji90kv1W3zA6MqwSIHytkY6k=; fh=c8qTpBdgq82M5uCzuqrmfc1XNjNwAiHxv7+TiZqO38w=; b=V8OLatEhHfg3fDjFVE5805dwBR/pRWJRCcyjmtjmFA/6FHs2jCSclrjiDfavyRULmc WL3eID8vhvUKwtzaOzGLdVTR/JZ7nJg8AyIr05ZhaAWAyqAfaCkxWMMShqhi6E0TMpgK Krx4ZNhLGHk91Fwz2vbCAJz1KgfPyursKhKWLyruQqHA4NvZu8Eiw2UywsTHCPxJG4Zu VPx4/AVd+o+dR3elMlltDSKHk0MC/VP5AS5bUYsDWwKo8lLahJoXleRTrBpitGLGCZjm tL3Y1p8jR2O/JSHMYEN4Ta+p98H5aV6OXy7Dqg1hzEhRDx6ItsgkLLAuf/eG2QGr6ZnY kVEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm1 header.b=siv4dEvU; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="4skXX/n4"; spf=pass (google.com: domain of linux-kernel+bounces-15437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15437-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fb23-20020a056a002d9700b006d9b044f15csi16873855pfb.258.2024.01.03.03.20.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 03:20:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm1 header.b=siv4dEvU; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="4skXX/n4"; spf=pass (google.com: domain of linux-kernel+bounces-15437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15437-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B973BB2251B for ; Wed, 3 Jan 2024 11:20:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F08D218E26; Wed, 3 Jan 2024 11:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="siv4dEvU"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="4skXX/n4" X-Original-To: linux-kernel@vger.kernel.org Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 988F018E0C; Wed, 3 Jan 2024 11:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A52445C01B3; Wed, 3 Jan 2024 06:20:11 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 03 Jan 2024 06:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1704280811; x=1704367211; bh=pURSsn42YA SyjShYaXFji90kv1W3zA6MqwSIHytkY6k=; b=siv4dEvUTdBa5tvrhjfr+0AqUz MC+yLr0d/hie2ElJdhXE9U9i8FdAlYhNaIEZmQeU+lNJct2lmqOdDgG+nRXE5BsM C5FklLlR8QJTIAZDb3dj/PPrWr5DVY4x/HhO6TtjYHj+QUOk2vZm0sh2Vj6WXydu n4q3vm4M3wha7rsHEyNFxcGjCH3xc1Isk7KRS6HIXHsFAcOxb2k8hTFwneI5+15Z gobIeGOZT+UymSBgtLf9wiN1FcAu8RUU59qpQwF8O66etIKmvILPllLQaTBdd40r YNcgJOYfxWSWgPIIs6sOnKJ435C+gG/P6CaoTcRVXnHxJOCLVonBVe8QOKlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1704280811; x=1704367211; bh=pURSsn42YASyjShYaXFji90kv1W3 zA6MqwSIHytkY6k=; b=4skXX/n4oIK9krhbABBIURU/f98yOhCL/oPYgI5oU5Z+ VkaXh/klpi0UAZRtaSn046r9uHggozA+xgWjGwjw8GyFFcnCJ4wFlvwTOfTy2Y9S V/0QmRnrOXtt7YY682YRc/SkAfdtIpbnwMNv7zpU+966o8rzMfhHRB7qsNaod7VR qMBTBB77FWBtf18fC1KSHS0ZDY9ylin/rdXIacfPPF57FrIZacSWv1LOkoSOCFwZ fmIxT7vVeyni6WpHWrke4MvSnErl695+OZEsboiu7aJ7MV/RcWaarE7toqN0kOE1 hVJ9w+2aj2yhVB4HDNgCgc2+uIhDDb7p1RnCdIcJPw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeghedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0C00CB6008F; Wed, 3 Jan 2024 06:20:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1364-ga51d5fd3b7-fm-20231219.001-ga51d5fd3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20240103102458.3687963-1-arnd@kernel.org> Date: Wed, 03 Jan 2024 12:19:50 +0100 From: "Arnd Bergmann" To: "Maciej Fijalkowski" , "Arnd Bergmann" Cc: "Jesse Brandeburg" , "Anthony L Nguyen" , "Jakub Kicinski" , "David S . Miller" , "Eric Dumazet" , "Paolo Abeni" , "Simon Horman" , "Daniel Borkmann" , "Larysa Zaremba" , "Piotr Raczynski" , "Amritha Nambiar" , "Alexei Starovoitov" , "intel-wired-lan@lists.osuosl.org" , Netdev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ice: fix building withouto XDP Content-Type: text/plain On Wed, Jan 3, 2024, at 11:54, Maciej Fijalkowski wrote: > On Wed, Jan 03, 2024 at 11:24:45AM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> The newly added function fails to build when struct xsk_cb_desc is >> not defined: >> >> drivers/net/ethernet/intel/ice/ice_base.c: In function 'ice_xsk_pool_fill_cb': >> drivers/net/ethernet/intel/ice/ice_base.c:525:16: error: variable 'desc' has initializer but incomplete type >> >> Hide this part in the same #ifdef that controls the structure definition. > > Hey Arnd, > > this has been fixed by Vladimir: > https://lore.kernel.org/netdev/20231219110205.1289506-1-vladimir.oltean@nxp.com/ > > in a way that we don't have to wrap driver code with ifdefs. Ok, sounds good. Arnd