Received-SPF: pass (google.com: domain of linux-kernel+bounces-15484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1703042081.git.kevinmbecause@gmail.com> <941a566eb114701685dc44f708f81891b3bd085b.1703042082.git.kevinmbecause@gmail.com>
In-Reply-To: <941a566eb114701685dc44f708f81891b3bd085b.1703042082.git.kevinmbecause@gmail.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Wed, 3 Jan 2024 21:00:29 +0900
Message-ID: <CAK7LNAQX+h-a3yBEOqXG2_7mw+6bS5NmJ=UYAEt=oghQvi4W2Q@mail.gmail.com>
Subject: Re: [PATCH 1/2] kbuild: Enable decompression for use by
 EXTRA_FIRMWARE The build system can currently only compress files. This patch
 adds the functionality to decompress files. Decompression is needed for
 building firmware files into the kernel if those files are compressed on the
 filesystem. Compressed firmware files are in use by Gentoo, Fedora, Arch, and others.
To: Kevin Martin <kevinmbecause@gmail.com>
Cc: joeyzerocrash@protonmail.com, Nathan Chancellor <nathan@kernel.org>, 
	Nick Desaulniers <ndesaulniers@google.com>, Nicolas Schier <nicolas@fjasle.eu>, 
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 7:26=E2=80=AFPM Kevin Martin <kevinmbecause@gmail.c=
om> wrote:
>
> Signed-off-by: Kevin Martin <kevinmbecause@gmail.com>
> ---
>  scripts/Makefile.lib | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 1a965fe68..d043be3dc 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -523,6 +523,9 @@ quiet_cmd_xzkern_with_size =3D XZKERN  $@
>  quiet_cmd_xzmisc =3D XZMISC  $@
>        cmd_xzmisc =3D cat $(real-prereqs) | $(XZ) --check=3Dcrc32 --lzma2=
=3Ddict=3D1MiB > $@
>
> +quiet_cmd_xzdec =3D XZDEC   $@
> +      cmd_xzdec =3D cat $(real-prereqs) | $(XZ) --decompress > $@
> +


Please do not fork the meaningless 'cat' process.

This should be a single process to take just one input file.

    cmd_xzdec =3D $(XZ) --decompress --stdout $< > $@


Commit d3dd3b5a29bb9582957451531fed461628dfc834
was a very bad commit.

The 'cat' and compression/decompression must be
separate rules.

We should not repeat the mistake in the past.


>  # ZSTD
>  # ----------------------------------------------------------------------=
-----
>  # Appends the uncompressed size of the data using size_append. The .zst
> @@ -548,6 +551,9 @@ quiet_cmd_zstd22 =3D ZSTD22  $@
>  quiet_cmd_zstd22_with_size =3D ZSTD22  $@
>        cmd_zstd22_with_size =3D { cat $(real-prereqs) | $(ZSTD) -22 --ult=
ra; $(size_append); } > $@
>
> +quiet_cmd_zstddec =3D ZSTDDEC $@
> +      cmd_zstddec =3D cat $(real-prereqs) | $(ZSTD) --decompress > $@
> +


Same here.
Please make this a single process:

   cmd_zstddec =3D $(ZSTD) --decompress --force --output=3D$@ $<


One small concern in the future is, if we end up with adding
quiet_cmd_bzip2dec, we will run out of the 7-column of the short log.

 quiet_cmd_bzip2dec =3D BZIP2DEC$@

We can increase the column size if needed, so I do not think
it is a big issue.


>  # ASM offsets
>  # ----------------------------------------------------------------------=
-----
>
> --
> 2.41.0
>


--=20
Best Regards
Masahiro Yamada