Received-SPF: pass (google.com: domain of linux-kernel+bounces-15488-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20230921090027.11136-1-Wenhua.Lin@unisoc.com> <20230921090027.11136-4-Wenhua.Lin@unisoc.com>
 <07a9e3c1-0ed4-6f30-81c9-4eabcc11a18b@linux.alibaba.com>
In-Reply-To: <07a9e3c1-0ed4-6f30-81c9-4eabcc11a18b@linux.alibaba.com>
From: wenhua lin <wenhua.lin1994@gmail.com>
Date: Wed, 3 Jan 2024 20:04:34 +0800
Message-ID: <CAB9BWhcFgTP1M5LxnYAWLaCZpfxZfqmQh6e63vX7rri-j87FqA@mail.gmail.com>
Subject: Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Wenhua Lin <Wenhua.Lin@unisoc.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Andy Shevchenko <andy@kernel.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Orson Zhai <orsonzhai@gmail.com>, 
	Chunyan Zhang <zhang.lyra@gmail.com>, linux-gpio@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 27, 2023 at 5:24=E2=80=AFPM Baolin Wang
<baolin.wang@linux.alibaba.com> wrote:
>
>
>
> On 9/21/2023 5:00 PM, Wenhua Lin wrote:
> > When the soc changes, the corresponding gpio-eic-sprd.c
> > code needs to be modified, and the corresponding
> > Document must also be modified, which is quite troublesome.
> > To avoid modifying the driver file, the number of EICs
> > is automatically calculated by matching dts nodes.
> >
> > Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
>
> This is not a bugfix and you still use an incorrect Fixes tag.
>
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> > ---
> >   drivers/gpio/gpio-eic-sprd.c | 43 ++++++++++++++++++-----------------=
-
> >   1 file changed, 22 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.=
c
> > index 96f1c7fd3988..e85addbdf8aa 100644
> > --- a/drivers/gpio/gpio-eic-sprd.c
> > +++ b/drivers/gpio/gpio-eic-sprd.c
> > @@ -100,33 +100,32 @@ struct sprd_eic {
> >
> >   struct sprd_eic_variant_data {
> >       enum sprd_eic_type type;
> > -     u32 num_eics;
> >   };
> >
> > +#define SPRD_EIC_VAR_DATA(soc_name)                          \
> > +static const struct sprd_eic_variant_data soc_name##_eic_dbnc_data =3D=
 {       \
> > +     .type =3D SPRD_EIC_DEBOUNCE,                                     =
 \
> > +};                                                                   \
> > +                                                                     \
> > +static const struct sprd_eic_variant_data soc_name##_eic_latch_data =
=3D {      \
> > +     .type =3D SPRD_EIC_LATCH,                                        =
 \
> > +};                                                                   \
> > +                                                                     \
> > +static const struct sprd_eic_variant_data soc_name##_eic_async_data =
=3D {      \
> > +     .type =3D SPRD_EIC_ASYNC,                                        =
 \
> > +};                                                                   \
> > +                                                                     \
> > +static const struct sprd_eic_variant_data soc_name##_eic_sync_data =3D=
 {       \
> > +     .type =3D SPRD_EIC_SYNC,                                         =
 \
> > +}
> > +
> > +SPRD_EIC_VAR_DATA(sc9860);
> > +
> >   static const char *sprd_eic_label_name[SPRD_EIC_MAX] =3D {
> >       "eic-debounce", "eic-latch", "eic-async",
> >       "eic-sync",
> >   };
> >
> > -static const struct sprd_eic_variant_data sc9860_eic_dbnc_data =3D {
> > -     .type =3D SPRD_EIC_DEBOUNCE,
> > -     .num_eics =3D 8,
> > -};
> > -
> > -static const struct sprd_eic_variant_data sc9860_eic_latch_data =3D {
> > -     .type =3D SPRD_EIC_LATCH,
> > -     .num_eics =3D 8,
> > -};
> > -
> > -static const struct sprd_eic_variant_data sc9860_eic_async_data =3D {
> > -     .type =3D SPRD_EIC_ASYNC,
> > -     .num_eics =3D 8,
> > -};
> > -
> > -static const struct sprd_eic_variant_data sc9860_eic_sync_data =3D {
> > -     .type =3D SPRD_EIC_SYNC,
> > -     .num_eics =3D 8,
> > -};
> >
> >   static inline void __iomem *sprd_eic_offset_base(struct sprd_eic *spr=
d_eic,
> >                                                unsigned int bank)
> > @@ -595,6 +594,7 @@ static int sprd_eic_probe(struct platform_device *p=
dev)
> >       struct sprd_eic *sprd_eic;
> >       struct resource *res;
> >       int ret, i;
> > +     u16 num_banks =3D 0;
> >
> >       pdata =3D of_device_get_match_data(&pdev->dev);
> >       if (!pdata) {
> > @@ -625,12 +625,13 @@ static int sprd_eic_probe(struct platform_device =
*pdev)
> >                       break;
> >
> >               sprd_eic->base[i] =3D devm_ioremap_resource(&pdev->dev, r=
es);
> > +             num_banks++;
>
> Please move this after the validation of the sprd_eic->base.

Thank you very much for your review.
I will fix this issue in patch v3.

>
> >               if (IS_ERR(sprd_eic->base[i]))
> >                       return PTR_ERR(sprd_eic->base[i]);
> >       }
> >
> >       sprd_eic->chip.label =3D sprd_eic_label_name[sprd_eic->type];
> > -     sprd_eic->chip.ngpio =3D pdata->num_eics;
> > +     sprd_eic->chip.ngpio =3D num_banks * SPRD_EIC_PER_BANK_NR;
> >       sprd_eic->chip.base =3D -1;
> >       sprd_eic->chip.parent =3D &pdev->dev;
> >       sprd_eic->chip.direction_input =3D sprd_eic_direction_input;