Received-SPF: pass (google.com: domain of linux-kernel+bounces-15499-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Feedback-ID: i68a1478a:Fastmail
Date: Wed, 3 Jan 2024 06:17:10 -0600
From: Patrick Williams <patrick@stwcx.xyz>
To: Peter Yin <peteryin.openbmc@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 5/5] ARM: dts: aspeed: Harma: Add spi-gpio
Message-ID: <ZZVQRgTe57G4Tc_w@heinlein.vulture-banana.ts.net>
References: <20240102044409.3810873-1-peteryin.openbmc@gmail.com>
 <20240102044409.3810873-6-peteryin.openbmc@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="4MieZFNir6FV4A2x"
Content-Disposition: inline
In-Reply-To: <20240102044409.3810873-6-peteryin.openbmc@gmail.com>


--4MieZFNir6FV4A2x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 02, 2024 at 12:44:09PM +0800, Peter Yin wrote:
> Add spi-gpio for tpm device.
>=20
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> ---
>  .../dts/aspeed/aspeed-bmc-facebook-harma.dts  | 21 +++++++++++++++++++
>  1 file changed, 21 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arc=
h/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index 36aad01dda20..25ae044cd176 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -28,6 +28,8 @@ aliases {
>  		i2c29 =3D &imux29;
>  		i2c30 =3D &imux30;
>  		i2c31 =3D &imux31;
> +
> +		spi1 =3D &spi_gpio;
>  	};
> =20
>  	chosen {
> @@ -67,6 +69,25 @@ led-2 {
>  			gpios =3D <&gpio0 124 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
> +
> +	spi_gpio: spi-gpio {
> +		status =3D "okay";
> +		compatible =3D "spi-gpio";
> +		#address-cells =3D <1>;
> +		#size-cells =3D <0>;
> +
> +		gpio-sck =3D <&gpio0 ASPEED_GPIO(Z, 3) GPIO_ACTIVE_HIGH>;
> +		gpio-mosi =3D <&gpio0 ASPEED_GPIO(Z, 4) GPIO_ACTIVE_HIGH>;
> +		gpio-miso =3D <&gpio0 ASPEED_GPIO(Z, 5) GPIO_ACTIVE_HIGH>;
> +		num-chipselects =3D <1>;
> +		cs-gpios =3D <&gpio0 ASPEED_GPIO(Z, 0) GPIO_ACTIVE_LOW>;
> +
> +		tpmdev@0 {
> +			compatible =3D "tcg,tpm_tis-spi";

Due to other pending changes, there is a request that all tpm_tis-spi
also contain a compatible with a chip vendor.  Please add
"infineon,slb9670".

See https://lore.kernel.org/lkml/ZZTS0p1hdAchIbKp@heinlein.vulture-banana.t=
s.net/
for more context.

> +			spi-max-frequency =3D <33000000>;
> +			reg =3D <0>;
> +		};
> +	};
>  };
> =20
>  // HOST BIOS Debug
> --=20
> 2.25.1
>=20

--=20
Patrick Williams

--4MieZFNir6FV4A2x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmWVUEYACgkQqwNHzC0A
wRlu0Q/+JCxoappGQgYN8XwykKfMvTqOKTOoH56HMD4//s7BZSAqhc663TqU+iSk
GdF5fU6nXjga9rM/eh5t4HPBmptag+RnUIAYolxL3G5UoRaJs0Mk6k2qQzCUheZv
+aIo5H1NDzurnUt4WXhpc07nVwQRlsu/q6+xPLrLfd2sVnHLRbGjfo9T+Q1w+9P7
bKsSfO8dqtfxIvHc4GRqQTJTprzpyJd9X3WC6PmeS5PEWuLzG5JDK4LzEjGHpEno
ldZKmO7TNInpLA4TbeLzS3O1dHSPIGcqwAAzrkgZ1pJUZaTmpdoHKFgpIeYq5p+b
INHCEaBukf20jwjC04FQaF3dif+zMlMUiRkDdZIQmc4RatAVWv5pkfj4hRqbnDk3
/1VOY6C3NKtu+1v7MOQsfuxwNrbrb20TQu5LWco9z1ENsbW5ngr6iHU/yx164UDs
xy1HPRm7Y9wJUz3VmvQmvdUHNIQ6gAMGMnrk+4F69pUR5drmUtgDAxc1TTsUBklV
MCj47BP+o1PNwT/UaScuQorCS8ffxk7tGOT4zfKLqQghEpLO/aKzaSk+V8k8hoRC
pXbBmjXtyuYEp50RG5Uim4/PdoWX6Dm1Vfz6pE7t0XzcntXgwzPNgWYBiGwamhEL
ajhb2hf4aXXIyutOcF+F2g/VSpRh1cJ8AFomfqW+CSLRWn9zXAY=
=ZFb5
-----END PGP SIGNATURE-----

--4MieZFNir6FV4A2x--