Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7085121rdb; Wed, 3 Jan 2024 04:18:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNg58uHQ7yNoASOIYQuiktAd+wehtpVqeNyv6ehOaJ4xwD/EDCHGmGWbP/cBoJG8whhThS X-Received: by 2002:a05:6e02:1a42:b0:35f:f94e:d858 with SMTP id u2-20020a056e021a4200b0035ff94ed858mr13084832ilv.111.1704284320107; Wed, 03 Jan 2024 04:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704284320; cv=none; d=google.com; s=arc-20160816; b=W2+rqUn2+QSpxIKGHXPBGjFHkv0mSxkkTxBZrUw8q/TvBgHMCRdYBySTY2Ndi3Ykph 17pRKMyBGzFry+8QlbjSi+GyNhWVArFiVcZqrEMYmQ9YLJ6zHf1uaePo5jWhiNENsh+i AYy2dkqcu2VE1B6BB4hZTHUnJmUf59IyXw+bY5k334SUNlG5iZ0O00Yu7wXS0lJb/5E6 mtHh0GDK3tbE2CI3hLWMHgz8+hx3VhxcZ0w0Kuqn642zaBmhiZJ59vRBrTqQHwHAdRNI dQMI+ja8DLL5lJL5lBefpUPVE9zQLsD6oKyPoXbmUgWSQrriMGI+/D89RZlVn+yxDv5z WyQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id:dkim-signature; bh=kXZ7H5ciV8izRUYlk7CkzEBsb3PXS4+N0LB5qQgk7Bo=; fh=rVTevkBNaOWUK9pgrM0zMmCbXLnAgH/o2x3U+4qc0CE=; b=toq0eIXRV7OIEiAfb4QrE58x4jnP89tp40QgETbz/DAS/onxAERO1yGW/waQ2GOTkU r3g35n9FTqOM2q3XnhYCm2jnvqaBA4JXoIzArDTa384GgEgSh9yDSRnCpGjXzi6H5two DmGT5IphvAYAO7KeUGNwsQ/QiYNOp1XbCza6/0CCPPfherhX4dTsTOFVsCNnZGE60mL8 YUflmn992CgpMXtwCZBvQbBJmHeDO8ctPMhMjLPyBblKQwnjvY8wA2B9l3djLomFgTFz UgL31h3Cr3+n59pv5DdWLmYjvDL4yFhQgpyKirpD1j8aiM7H6saJmivqstdCsC+bsoSm TZDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b="tKg2/8QS"; spf=pass (google.com: domain of linux-kernel+bounces-15500-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15500-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q1-20020a63d601000000b005cdfaea88a0si19461176pgg.783.2024.01.03.04.18.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 04:18:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15500-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b="tKg2/8QS"; spf=pass (google.com: domain of linux-kernel+bounces-15500-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15500-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=qq.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BA37D2858A2 for ; Wed, 3 Jan 2024 12:18:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2E26318EB6; Wed, 3 Jan 2024 12:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=qq.com header.i=@qq.com header.b="tKg2/8QS" X-Original-To: linux-kernel@vger.kernel.org Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72C7A18EB5 for ; Wed, 3 Jan 2024 12:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=qq.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qq.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1704283997; bh=kXZ7H5ciV8izRUYlk7CkzEBsb3PXS4+N0LB5qQgk7Bo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tKg2/8QSOQQRL8Wr3FdQpzA/PMJlf9ysF9rZj0zgFmvqD3HF9uLhxbVIXaYCBrbQ9 BQkV4v4LIX79fRbqZo10r+VMy07jdNdTQlSIDhoZbCRTQp4kAGsCkIoXHl9hFQIdPb 9gOl8APJ6GXe/aTOWFlDlk+tjSoArUkfdrz9ODDw= Received: from pek-lxu-l1.wrs.com ([111.198.225.215]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 34FAC091; Wed, 03 Jan 2024 20:13:15 +0800 X-QQ-mid: xmsmtpt1704283995t4ad9vegk Message-ID: X-QQ-XMAILINFO: NvH2zBBgt3uT6SfvEicVD2L0azpIUZsry5Y/HUPF5hFdUj4LCsVXMen8nLulvz gltrAhfJ/ubQm8Cf5k8FI4q3Dk3kN8Zpjh7u4GRC19fBk0V7imHh3Ug+vyKj2tISZohXId3Jh5ms q2rxIvuAHuCP65hDVP52sfZH4n3CKFc0Qp+vVb0TlddA2/5VzVP+bBqsat4fC2d7WaDGqwRVp7Vs 47DSTGiUYRrndtyZ1bOfLrRadGn4E4iq9qcMiP7/V1W+yXoUouxdTcpFrcoEZnHcfl7Rkcbs/VqN ZkIpT0tcBM28nFlJ928Na6MBAG4+BiIqwigE0v4ywGdPbATH2S4wIawSnIq6aJhTfZYS7jyGmQUL XvfTFIoHERFXzp1Gl1/ptayPFt7bOKRFeM0c9PeB48FLEG+w63yg6W+IyDYqhjcIyDwG4rp4xhfi OPmXkUnhLMZhiSSkS2YOWIy+VTBzTPcuXdU1co84BoWqRHBTn4NXoyGn7dmlZPtAXwhXHwDV5VK9 FWNckPzhRIk4upclCH8WiPQ/FW6UinyuJ7K7a7ssoj4vNzuVVVi9vF5gXEvZ/767Ai391FiCXR50 uId2zshqwgQpxfbMxU+iXd1qfgWsvu9uiorqotQ1f6sQTmO4Cn/R+9kLSw26k5Znyax9UP0XqU/p GZlTvg415XQgVe32BEv3rFUW4oDiV+L45+us7Kx0nxqZmHZ2E0gGlicg/8bZ3U1tG9WdZSHWbCfq S48/Q0gqnAKIDhu1AY0z2U2UZ98b9JARH7g8hmiHI84aFPheiKp+CFGhlp8PuaihNazNGnecFusW NpaLtRozWB39lS4CcdT30twj4cn2QXaY2gARiELauCmCYdNUXpoZjsKPRjgSm2TrOWQXfYiNJXzT sA6kuVOlkKGUThFH67LqXpPa9Puuz4oW4fOqqSigPQZJP+Rvoi1N9Y3X67GaI7lpYOHvycOjhU9a en5l5GOEA= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= From: Edward Adam Davis To: syzbot+74dce9511a59ad67a492@syzkaller.appspotmail.com Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [reiserfs?] general protection fault in reiserfs_xattr_set Date: Wed, 3 Jan 2024 20:13:16 +0800 X-OQ-MSGID: <20240103121315.2733802-2-eadavis@qq.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <0000000000009d4b80060df41cf8@google.com> References: <0000000000009d4b80060df41cf8@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit please test null ptr deref in reiserfs_xattr_set #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 453f5db0619e diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 998035a6388e..00fd8f747394 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c @@ -618,6 +618,9 @@ int reiserfs_xattr_set(struct inode *inode, const char *name, int error, error2; size_t jbegin_count = reiserfs_xattr_nblocks(inode, buffer_size); + if (!reiserfs_xattrs_initialized(inode->i_sb)) + return -EOPNOTSUPP; + /* Check before we start a transaction and then do nothing. */ if (!d_really_is_positive(REISERFS_SB(inode->i_sb)->priv_root)) return -EOPNOTSUPP;