Received-SPF: pass (google.com: domain of linux-kernel+bounces-15554-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <1f5633526f6f2d39382fa638adc0e5c0b3cb61ab.camel@linux.intel.com>
Subject: Re: [PATCH -next] drm/xe: Remove unneeded semicolon
From: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= <thomas.hellstrom@linux.intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>, daniel@ffwll.ch,
 airlied@gmail.com,  mripard@kernel.org, tzimmermann@suse.de,
 maarten.lankhorst@linux.intel.com
Cc: lucas.demarchi@intel.com, intel-xe@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date: Wed, 03 Jan 2024 14:11:57 +0100
In-Reply-To: <20240103011515.56529-1-yang.lee@linux.alibaba.com>
References: <20240103011515.56529-1-yang.lee@linux.alibaba.com>
Organization: Intel Sweden AB, Registration Number: 556189-6027
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi, Yang,

On Wed, 2024-01-03 at 09:15 +0800, Yang Li wrote:
> ./drivers/gpu/drm/xe/xe_rtp.c:168:2-3: Unneeded semicolon
>=20

Could you please reformulate using imperative "Remove..." rather than
citing a style alert?

With that,
Reviewed-by: Thomas Hellstr=C3=B6m <thomas.hellstrom@linux.intel.com>


> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> =C2=A0drivers/gpu/drm/xe/xe_rtp.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/xe/xe_rtp.c
> b/drivers/gpu/drm/xe/xe_rtp.c
> index fb44cc7521d8..316ed2f6d1f0 100644
> --- a/drivers/gpu/drm/xe/xe_rtp.c
> +++ b/drivers/gpu/drm/xe/xe_rtp.c
> @@ -165,7 +165,7 @@ static void rtp_get_context(struct
> xe_rtp_process_ctx *ctx,
> =C2=A0		*gt =3D (*hwe)->gt;
> =C2=A0		*xe =3D gt_to_xe(*gt);
> =C2=A0		break;
> -	};
> +	}
> =C2=A0}
> =C2=A0
> =C2=A0/**