Received-SPF: pass (google.com: domain of linux-kernel+bounces-15558-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1703596577.git.u.kleine-koenig@pengutronix.de> <4a97c8e6996c9c95244715310b57ce5af6ccb1ad.1703596577.git.u.kleine-koenig@pengutronix.de>
In-Reply-To: <4a97c8e6996c9c95244715310b57ce5af6ccb1ad.1703596577.git.u.kleine-koenig@pengutronix.de>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Wed, 3 Jan 2024 14:18:49 +0100
Message-ID: <CAMj1kXELWT1c1iE8u5yCNBUJBUGsxfFeKsSYXWQHRNMiOum2Ug@mail.gmail.com>
Subject: Re: [PATCH 1/2] virt: efi_secret: Convert to platform remove callback
 returning void
To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Dov Murik <dovmurik@linux.ibm.com>, Dan Williams <dan.j.williams@intel.com>, 
	kernel@pengutronix.de, Gerd Hoffmann <kraxel@redhat.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 26 Dec 2023 at 14:28, Uwe Kleine-K=C3=B6nig
<u.kleine-koenig@pengutronix.de> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  drivers/virt/coco/efi_secret/efi_secret.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/virt/coco/efi_secret/efi_secret.c b/drivers/virt/coc=
o/efi_secret/efi_secret.c
> index e700a5ef7043..cd29e66b1543 100644
> --- a/drivers/virt/coco/efi_secret/efi_secret.c
> +++ b/drivers/virt/coco/efi_secret/efi_secret.c
> @@ -326,16 +326,15 @@ static int efi_secret_probe(struct platform_device =
*dev)
>         return ret;
>  }
>
> -static int efi_secret_remove(struct platform_device *dev)
> +static void efi_secret_remove(struct platform_device *dev)
>  {
>         efi_secret_securityfs_teardown(dev);
>         efi_secret_unmap_area();
> -       return 0;
>  }
>
>  static struct platform_driver efi_secret_driver =3D {
>         .probe =3D efi_secret_probe,
> -       .remove =3D efi_secret_remove,
> +       .remove_new =3D efi_secret_remove,
>         .driver =3D {
>                 .name =3D "efi_secret",
>         },
> --
> 2.43.0
>