Received-SPF: pass (google.com: domain of linux-kernel+bounces-15584-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 3 Jan 2024 14:32:53 +0100
From: Nam Cao <namcao@linutronix.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Ryan England <rcengland@gmail.com>, Larry Finger
 <Larry.Finger@lwfinger.net>, Florian Schilhabel
 <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment
Message-ID: <20240103143253.0d9c7788@namcao>
In-Reply-To: <f9b34a72-42e1-43f6-b03c-5a3d05773862@moroto.mountain>
References: <ZYSemFbzTlgLROMc@kernel.ryanengland.xyz>
	<20231222094735.5554b67a@namcao>
	<f9b34a72-42e1-43f6-b03c-5a3d05773862@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 3 Jan 2024 16:19:45 +0300 Dan Carpenter <dan.carpenter@linaro.org> wrote:
> On Fri, Dec 22, 2023 at 09:47:35AM +0100, Nam Cao wrote:
> > On Thu, 21 Dec 2023 20:22:48 +0000 Ryan England <rcengland@gmail.com> wrote:
> > >  static u32 start_drv_threads(struct _adapter *padapter)
> > >  {
> > > -	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s",
> > > -					  padapter->pnetdev->name);
> > > +	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name);  
> > 
> > Your description claims to fix "CHECK: Alignment should match open
> > parenthesis", but this one is already aligned, isn't it?  
> 
> No.  It was not aligned.  There was a space character missing.

Ah right, sorry for the noises.

Best regards,
Nam