Received-SPF: pass (google.com: domain of linux-kernel+bounces-15638-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <3d62b430-030a-4e85-9d4d-0468d237d371@web.de>
Date: Wed, 3 Jan 2024 15:16:11 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [0/2] net/smc: Adjustments for two function implementations
Content-Language: en-GB
To: Wenjia Zhang <wenjia@linux.ibm.com>, linux-s390@vger.kernel.org,
 netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
 "David S. Miller" <davem@davemloft.net>, "D. Wythe"
 <alibuda@linux.alibaba.com>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Jan Karcher <jaka@linux.ibm.com>,
 Paolo Abeni <pabeni@redhat.com>, Tony Lu <tonylu@linux.alibaba.com>,
 Wen Gu <guwen@linux.alibaba.com>
References: <8ba404fd-7f41-44a9-9869-84f3af18fb46@web.de>
 <41536899-3ca2-4413-b483-3d27ffe0d7f4@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <41536899-3ca2-4413-b483-3d27ffe0d7f4@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:q/blSR/UhsE=;br9DybMm/k674NvLS5wxXx+po5+
 aVwj+BcI4b0vFYlfB8FkrOPxJ7p1gxmI4O+pLWpKAbrCWF7MFso6QkUY/eLR1DZW4lwbCfvou
 R6YVtuKq8UmT4RSvzhAnrQ0FPhcDAbwcMD5wgZNqV7Soc6TEsyOIPL+xnuDvdvyadvabb+f3m
 +bzf6EycstiWdpnK2Aiz+8pzUH6tnUoaBCR1qpNwxneWPYg9T7C0HAa1bacU9Balnswch3loA
 vZo/KzEweUvIw/XfILVRG/mnB53VYow1CNqk9T54u98NHYDVe114dlvAfWFCpZroZ+Ig/4wLA
 wysBNjFnAcb4vLIUjYjfTiumiNjvbIfVLp6wc0gMB4DkfOM+vX/X59iLe/iD1J51yefC4WkRT
 vAT25qjVzqLaBw98A/0ZWPxWUkEgC/Wt/7KPfOGfsbL7RJJYi71GtSqYtiJ3S2FiK2rO6brjj
 tpb6u3Z7SVga+U2kpUjCnrO6Jp+M3R/XX2gRBsT1542aufOiPRNkbDxepv7GfGA6WQSQ8ULFT
 SSsZqSQ4ailE60sd7A7Mtbd8PvXTbRYnB/2wdI9VICTk+9gT3rZ9pv9Zm7mJNDAcTvpxSDuKf
 Y1/cbhcs4HC7S7yNPtJQdLtRVxI5Im4sAucTVQLhrsO/SsaFKZxUw5iG0g9fnkyt9sYzcA2JJ
 R5XwRoB81ec+XkmlWbzjsDs+/2Ff3wnYTHUa25zow7QooJMLxItQoHd2Ic/xKZuDaHLVaSrCV
 wvC/ggjmWbM4BewAHpNVZUSjxd9T1p6PFRF9h87YgmoOgJeniVSkgHAhcUmd1EN36CN+CkMIn
 LuoEUnUCsww/9rsRO1ZjRtQKQDGh8vt6DjEXYZCrn5AocqQV7htUIyclGEw5NysX9/tEpkoWH
 L3k1Y9r4dF45g/BAZ7isvCQU/SjRgsDh8e5QkY2o7aEFUm8gyjbqrBi4XfKdf61QGkD1ueAjE
 JIa2/CLrJFzAWUTFXLceVatJKGQ=

=E2=80=A6
>> =C2=A0=C2=A0 Return directly after a failed kzalloc() in smc_fill_gid_l=
ist()
>> =C2=A0=C2=A0 Improve exception handling in smc_llc_cli_add_link_invite(=
)
>>
>> =C2=A0 net/smc/af_smc.c=C2=A0 |=C2=A0 2 +-
>> =C2=A0 net/smc/smc_llc.c | 15 +++++++--------
>> =C2=A0 2 files changed, 8 insertions(+), 9 deletions(-)
=E2=80=A6
> However, I'm on the same page with Wen Gu. I could not see the necessity=
 of the patches.
> BTW, if you want to send fix patches,

I obviously propose to adjust specific implementation details.


> please provide the error messages you met,

This development concern does not apply here.


> the procedure of reproducing the issue and the correspoinding commit mes=
sages.

Would you like to extend the usage of source code analysis tools?


> If you want to send feature patches, I'd like to see a well thought-out =
patch or patch series.

I presented some thoughts for special transformation patterns
on several software components.


> E.g. In our component, the kfree(NULL) issue doesn't only occur in the p=
ositions where you mentioned in the patch series, also somewhere else.

Does your feedback indicate that you would support the avoidance of such a=
 special function call
at more places?


> I would be grateful if all of them would be cleaned up, not just some pi=
eces.

Do you find my patch series too small for the mentioned Linux module at th=
e moment?

Regards,
Markus