Received-SPF: pass (google.com: domain of linux-kernel+bounces-15651-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231224082249.3539167-1-alexious@zju.edu.cn>
In-Reply-To: <20231224082249.3539167-1-alexious@zju.edu.cn>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Wed, 3 Jan 2024 09:30:04 -0500
Message-ID: <CADnq5_NrcF+Swf0T+upaM64=WYfxExEHyBEGKTDAB8P4Khyw1Q@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/pm/smu7: fix a memleak in smu7_hwmgr_backend_init
To: Zhipeng Lu <alexious@zju.edu.cn>
Cc: dri-devel@lists.freedesktop.org, Ran Sun <sunran001@208suo.com>, 
	Thomas Zimmermann <tzimmermann@suse.de>, Deepak R Varma <drv@mailo.com>, Rex Zhu <Rex.Zhu@amd.com>, 
	Ruan Jinjie <ruanjinjie@huawei.com>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, linux-kernel@vger.kernel.org, 
	amd-gfx@lists.freedesktop.org, Mario Limonciello <mario.limonciello@amd.com>, 
	Daniel Vetter <daniel@ffwll.ch>, Alex Deucher <alexander.deucher@amd.com>, 
	Ken Wang <Qingqing.Wang@amd.com>, Evan Quan <evan.quan@amd.com>, 
	David Airlie <airlied@gmail.com>, =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Applied.  Thanks!

On Mon, Dec 25, 2023 at 5:18=E2=80=AFAM Zhipeng Lu <alexious@zju.edu.cn> wr=
ote:
>
> The hwmgr->backend, (i.e. data) allocated by kzalloc is not freed in
> the error-handling paths of smu7_get_evv_voltages and
> smu7_update_edc_leakage_table. However, it did be freed in the
> error-handling of phm_initializa_dynamic_state_adjustment_rule_settings,
> by smu7_hwmgr_backend_fini. So the lack of free in smu7_get_evv_voltages
> and smu7_update_edc_leakage_table is considered a memleak in this patch.
>
> Fixes: 599a7e9fe1b6 ("drm/amd/powerplay: implement smu7 hwmgr to manager =
asics with smu ip version 7.")
> Fixes: 8f0804c6b7d0 ("drm/amd/pm: add edc leakage controller setting")
> Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/driver=
s/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> index 11372fcc59c8..b1a8799e2dee 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> @@ -2974,6 +2974,8 @@ static int smu7_hwmgr_backend_init(struct pp_hwmgr =
*hwmgr)
>                 result =3D smu7_get_evv_voltages(hwmgr);
>                 if (result) {
>                         pr_info("Get EVV Voltage Failed.  Abort Driver lo=
ading!\n");
> +                       kfree(hwmgr->backend);
> +                       hwmgr->backend =3D NULL;
>                         return -EINVAL;
>                 }
>         } else {
> @@ -3019,8 +3021,10 @@ static int smu7_hwmgr_backend_init(struct pp_hwmgr=
 *hwmgr)
>         }
>
>         result =3D smu7_update_edc_leakage_table(hwmgr);
> -       if (result)
> +       if (result) {
> +               smu7_hwmgr_backend_fini(hwmgr);
>                 return result;
> +       }
>
>         return 0;
>  }
> --
> 2.34.1
>