Received-SPF: pass (google.com: domain of linux-kernel+bounces-15683-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <743cde4d-7907-4dcf-a0d1-d06c486e2af6@amd.com>
Date: Wed, 3 Jan 2024 16:12:41 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [syzbot] [dri?] WARNING in drm_prime_destroy_file_private (2)
Content-Language: en-US
To: Qi Zheng <zhengqi.arch@bytedance.com>,
 syzbot <syzbot+59dcc2e7283a6f5f5ba1@syzkaller.appspotmail.com>
Cc: airlied@gmail.com, akinobu.mita@gmail.com, akpm@linux-foundation.org,
 daniel@ffwll.ch, dri-devel@lists.freedesktop.org, jgg@nvidia.com,
 linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
 linux-media@vger.kernel.org, maarten.lankhorst@linux.intel.com,
 mripard@kernel.org, sumit.semwal@linaro.org,
 syzkaller-bugs@googlegroups.com, tzimmermann@suse.de
References: <000000000000f4faa2060d83f582@google.com>
 <0b0963c2-3c77-4037-a66c-f535c4422755@bytedance.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <0b0963c2-3c77-4037-a66c-f535c4422755@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MXBpM0NYMUthMnI1Tm03TUlaaVd5T3R3Vm9oNThLYVR3bkxwSEpkTkRQbStz?=
 =?utf-8?B?b0ptc2ZFTVMvelh5Z2N3ZVNJYVFmVnd2M1E0QzQyZXZFRXk5OXh5and2Vngx?=
 =?utf-8?B?b3R0dDIxbUltRHdqejBDUHkrVWhtK2toamJ6bGgvMmZ6UytEbDE4bmdrU24v?=
 =?utf-8?B?TWZUTEdXbDNIWTZmd2p2ZzdGVWFHUFJROEtSYmpKZVBNcmRYeSs3aHpyMUQ2?=
 =?utf-8?B?RXAySll0RWRQSXdDbUdmSjYzd0xwSTl2TUdpUVhnS01vZ0xhYkoxRGtiRFcy?=
 =?utf-8?B?SW15TVJuS3BndXpUNWRlVk42NmEraGREdkZraFFvZlZ4c0QzUG5RbHN0Wm00?=
 =?utf-8?B?UkExRkhpMWY0dUp6TS9OV0hhVVk5Tlo5U04xYmZWdWVPL3ZJSWt6WUNJYnhr?=
 =?utf-8?B?OVhaWkMxMmNZaXB4Z0x4RWdiakkySE5zWk9vR1FxSk9WR3dybzdINlBDRFpk?=
 =?utf-8?B?ZDVSWFh4Q21NemFqR1BVdDUxTG1OQW91Q2cvM21NOGdoQmFGMW16T1NhM1E1?=
 =?utf-8?B?Y0RXZy9aWGJqWWIvRW1nanRWVXBUM2tHclBJb3ljQTZEbTJ6cEppc2dUbGQw?=
 =?utf-8?B?NkZmVitmNDc1K0cycGVBUTNHT0lDamRpdDllc0h2VjdTVWl0d04xY0pFYXow?=
 =?utf-8?B?UkdxbGtkbVdxdmVvUVB4aUJrZnhkbHE3YmdMblRXWmtQYWxPaHBVd1RDNGcw?=
 =?utf-8?B?YlllT2c4S291TW9UbVlPd2VCMmpwUXg4VnZFb3BHRUwxaDNyZG1ZRFdIWXVH?=
 =?utf-8?B?N2didTdmUlBoVENINVRQRVcvSy9sckZrTFRad1pnU3VuWEF0dUVrQmMwU2dP?=
 =?utf-8?B?V1JNd043cW9SQ3JVZmxtRldzNmQ1Vk9wUnFTQVFsZ09aZlhnWUhlWVhrcmlE?=
 =?utf-8?B?R0NLRmZpODZCMkVZT204NFNqQ0dVbmt4bFhqV28xMitkVWFCY3BxZURLaVh4?=
 =?utf-8?B?OGVzaVlIRjNCUG4xTVlyV3I0VVlyNFJybS9lcnE1SU1NQW9rMDBYYmowY29K?=
 =?utf-8?B?aFI2NTJrV0NjbW16TGh2eG8renV6YkE5VVRCOXNzOThlZnFtcjVUTkplSERH?=
 =?utf-8?B?MjNlNkhqTHpqQU5jYzhkRWZJYzkvMFYrTHFocE05RUVnQXdjdWZhSDd4cWo3?=
 =?utf-8?B?Z055SUZYTGhYc0xvaHJjOWVNUjNjRFgwNmJIVTY1WldTaHdaWmR2M1d4Qndr?=
 =?utf-8?B?eUt5cloxK1U4NStrMnRGbVVXKzVvZFRlem1rdUUwcmkzQ3FOOUxIdjdzRDBU?=
 =?utf-8?B?MGlJT1hsdFRkYXRTYXJrVVVLTGxqMHBiZ3BudkhQbmgwSTg4aUkweCtEclpR?=
 =?utf-8?B?T1FnSDJ6azhuZ3VBdDNmSVoxWVRzOFVoWEVpTTJQaXdEaWd0TUVGQ01tVlJi?=
 =?utf-8?B?NkF5SmlnR3Q4NFg0TG9WMWJIZzBTVVFYSDc4MVhseWgxa3d5Zm5TU3JoTi9I?=
 =?utf-8?B?K1I3V215cnBQb1dNSjBlaTJYMjRZcFBCM0IyU0xSY29YUWNSNjVnUXBIQnhD?=
 =?utf-8?B?bjJBUFZPbDZBYVM2Q1FIcTgwS3Z2UVRBN1RiSUlBY2FvaGJ4ZjIvK3gyMHJK?=
 =?utf-8?B?aFJkRGlDNzQrendlZzVERXJiNkdPV1RXVGRrbVNsSXU0SVdBN2l0UVVzaWJl?=
 =?utf-8?B?R3N0L1JOeUY2SVowWnNMblpaZzhRcG1RQ25GVnN2RmluZFhNdm0xSmZ1TTVZ?=
 =?utf-8?B?SGNiT0FoQTI1M1YxQUNPWXdFY25sVUhGWjdtZCsrTnB0TnZRQnZWWS9qOTZv?=
 =?utf-8?B?NGZZNDBGRGdXdU9JM29xa0I0Z1VUdSsrTXV0aUs2VEZmOGVsQkgraXVSR1pL?=
 =?utf-8?B?VmcwcHhPK3NEd3h0cFZJdFFNSXN2QnIrN1Z3NHVRQ3lLcjZQQ0dIQTlHQVd2?=
 =?utf-8?B?bnMxM3FlNWFLSnpLN3g5S09RZVVUeHJ5L0pWMGpxNG9HeHFVZnh1cHQ3Tk4w?=
 =?utf-8?B?NXFSNDJaUHhPT05Jbml5VFptd0hvOFlHb1RYdWJ5aFJTUHNhR1hnK093cDU4?=
 =?utf-8?B?aENFSndZQ09JbDVZNFh6enR3SGkvdTBRVEtTTjhLay9TNUs0RmF6WGVnbE9Y?=
 =?utf-8?B?Tk03cWpza1VLQUJ1NVF3dVMyemRPYmJXOGhQSlhPTDgrUzBXS1hZeldpeUR2?=
 =?utf-8?Q?RTwGmz7Ws+DYGBG58jeHePWx3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8b58534-27a1-40f9-ed13-08dc0c6e729a
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 15:12:49.1004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TWnUWzMBEvML0d0WFgJjhAG7W0q0BmBvsouempoAiaJDGJyd/REszCm1TAoqy7aS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8065

Am 28.12.23 um 03:57 schrieb Qi Zheng:
>
>
> On 2023/12/28 04:51, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit:    5254c0cbc92d Merge tag 'block-6.7-2023-12-22' of 
>> git://git..
>> git tree:       upstream
>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=10cc6995e80000
>> kernel config: 
>> https://syzkaller.appspot.com/x/.config?x=314e9ad033a7d3a7
>> dashboard link: 
>> https://syzkaller.appspot.com/bug?extid=59dcc2e7283a6f5f5ba1
>> compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils 
>> for Debian) 2.40
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13e35809e80000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=155d5fd6e80000
>>
>> Downloadable assets:
>> disk image: 
>> https://storage.googleapis.com/syzbot-assets/ebe09a5995ee/disk-5254c0cb.raw.xz
>> vmlinux: 
>> https://storage.googleapis.com/syzbot-assets/02178d7f5f98/vmlinux-5254c0cb.xz
>> kernel image: 
>> https://storage.googleapis.com/syzbot-assets/12307f47d87c/bzImage-5254c0cb.xz
>>
>> The issue was bisected to:
>>
>> commit ea4452de2ae987342fadbdd2c044034e6480daad
>> Author: Qi Zheng <zhengqi.arch@bytedance.com>
>> Date:   Fri Nov 18 10:00:11 2022 +0000
>>
>>      mm: fix unexpected changes to {failslab|fail_page_alloc}.attr
>>
>> bisection log: 
>> https://syzkaller.appspot.com/x/bisect.txt?x=13027f76e80000
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=10827f76e80000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=17027f76e80000
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the 
>> commit:
>> Reported-by: syzbot+59dcc2e7283a6f5f5ba1@syzkaller.appspotmail.com
>> Fixes: ea4452de2ae9 ("mm: fix unexpected changes to 
>> {failslab|fail_page_alloc}.attr")
>>
>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007efe98069194
>> R13: 00007efe97fd2210 R14: 0000000000000002 R15: 6972642f7665642f
>>   </TASK>
>> ------------[ cut here ]------------
>> WARNING: CPU: 0 PID: 5107 at drivers/gpu/drm/drm_prime.c:227 
>> drm_prime_destroy_file_private+0x43/0x60 drivers/gpu/drm/drm_prime.c:227
>
> The warning is caused by !RB_EMPTY_ROOT(&prime_fpriv->dmabufs):
>
> drm_prime_destroy_file_private
> --> WARN_ON(!RB_EMPTY_ROOT(&prime_fpriv->dmabufs));
>
> It seems irrelevant to the logic of fault injection. So I don't see
> why the commit ea4452de2ae9 can cause this warning. :(

Making an educated guess I strongly think syzbot incorrectly bisected this.

What basically happens is that a DRM test case crashes because a file 
private data structure is destroyed before all DMA-bufs referring to it 
are destroyed.

Looks like a random race condition in a test case to me. Question is 
really what test is syzbot running and who is maintaining this test case?

Regards,
Christian.

>
>> Modules linked in:
>> CPU: 0 PID: 5107 Comm: syz-executor227 Not tainted 
>> 6.7.0-rc6-syzkaller-00248-g5254c0cbc92d #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, 
>> BIOS Google 11/17/2023
>> RIP: 0010:drm_prime_destroy_file_private+0x43/0x60 
>> drivers/gpu/drm/drm_prime.c:227
>> Code: 00 00 fc ff df 48 89 fa 48 c1 ea 03 80 3c 02 00 75 21 48 8b 83 
>> 90 00 00 00 48 85 c0 75 06 5b e9 13 f1 93 fc e8 0e f1 93 fc 90 <0f> 
>> 0b 90 5b e9 04 f1 93 fc e8 3f 9b ea fc eb d8 66 66 2e 0f 1f 84
>> RSP: 0018:ffffc90003bdf9e0 EFLAGS: 00010293
>> RAX: 0000000000000000 RBX: ffff888019f28378 RCX: ffffc90003bdf9b0
>> RDX: ffff888018ff9dc0 RSI: ffffffff84f380c2 RDI: ffff888019f28408
>> RBP: ffff888019f28000 R08: 0000000000000001 R09: 0000000000000001
>> R10: ffffffff8f193a57 R11: 0000000000000000 R12: ffff88814829a000
>> R13: ffff888019f282a8 R14: ffff88814829a068 R15: ffff88814829a0a0
>> FS:  0000000000000000(0000) GS:ffff8880b9800000(0000) 
>> knlGS:0000000000000000
>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>> CR2: 00007efe98050410 CR3: 000000006d1ff000 CR4: 0000000000350ef0
>> Call Trace:
>>   <TASK>
>>   drm_file_free.part.0+0x738/0xb90 drivers/gpu/drm/drm_file.c:290
>>   drm_file_free drivers/gpu/drm/drm_file.c:247 [inline]
>>   drm_close_helper.isra.0+0x180/0x1f0 drivers/gpu/drm/drm_file.c:307
>>   drm_release+0x22a/0x4f0 drivers/gpu/drm/drm_file.c:494
>>   __fput+0x270/0xb70 fs/file_table.c:394
>>   task_work_run+0x14d/0x240 kernel/task_work.c:180
>>   exit_task_work include/linux/task_work.h:38 [inline]
>>   do_exit+0xa8a/0x2ad0 kernel/exit.c:869
>>   do_group_exit+0xd4/0x2a0 kernel/exit.c:1018
>>   get_signal+0x23b5/0x2790 kernel/signal.c:2904
>>   arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309
>>   exit_to_user_mode_loop kernel/entry/common.c:168 [inline]
>>   exit_to_user_mode_prepare+0x121/0x240 kernel/entry/common.c:204
>>   __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
>>   syscall_exit_to_user_mode+0x1e/0x60 kernel/entry/common.c:296
>>   do_syscall_64+0x4d/0x110 arch/x86/entry/common.c:89
>>   entry_SYSCALL_64_after_hwframe+0x63/0x6b
>> RIP: 0033:0x7efe98014769
>> Code: Unable to access opcode bytes at 0x7efe9801473f.
>> RSP: 002b:00007efe97fd2208 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
>> RAX: fffffffffffffe00 RBX: 00007efe9809c408 RCX: 00007efe98014769
>> RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00007efe9809c408
>> RBP: 00007efe9809c400 R08: 0000000000003131 R09: 0000000000003131
>> R10: 0000000000000000 R11: 0000000000000246 R12: 00007efe98069194
>> R13: 00007efe97fd2210 R14: 0000000000000002 R15: 6972642f7665642f
>>   </TASK>
>>
>>
>> ---
>> This report is generated by a bot. It may contain errors.
>> See https://goo.gl/tpsmEJ for more information about syzbot.
>> syzbot engineers can be reached at syzkaller@googlegroups.com.
>>
>> syzbot will keep track of this issue. See:
>> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>> For information about bisection process see: 
>> https://goo.gl/tpsmEJ#bisection
>>
>> If the report is already addressed, let syzbot know by replying with:
>> #syz fix: exact-commit-title
>>
>> If you want syzbot to run the reproducer, reply with:
>> #syz test: git://repo/address.git branch-or-commit-hash
>> If you attach or paste a git patch, syzbot will apply it before testing.
>>
>> If you want to overwrite report's subsystems, reply with:
>> #syz set subsystems: new-subsystem
>> (See the list of subsystem names on the web dashboard)
>>
>> If the report is a duplicate of another one, reply with:
>> #syz dup: exact-subject-of-another-report
>>
>> If you want to undo deduplication, reply with:
>> #syz undup