Received-SPF: pass (google.com: domain of linux-kernel+bounces-15726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Jan 2024 12:01:08 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
	"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com" <shameerali.kolothum.thodi@huawei.com>,
	"lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
	"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"Zeng, Xin" <xin.zeng@intel.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: Re: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Message-ID: <20240103160108.GP50406@nvidia.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-2-yi.l.liu@intel.com>
 <c967e716-9112-4d1a-b6f7-9a005e28202d@intel.com>
 <BN9PR11MB5276D14D2A7FF60B41A6A7B48C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXu5whlIGfiq16wF@Asurada-Nvidia>
 <BN9PR11MB52766D7F774510E0181CC89B8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXvI2IiXwwuHRE8V@Asurada-Nvidia>
 <7c398efc-8a2f-479d-bcff-ded8cc1ef3d0@intel.com>
 <20240102233849.GK50406@nvidia.com>
 <c59a780d-4030-4815-a34b-fb2e2f902ab3@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c59a780d-4030-4815-a34b-fb2e2f902ab3@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0eB8JeWl8iVrOPvLE/Q7NzADTd9/CsCebsgm8y3VwyEDxwJRUKuaS/Hd8szJ?=
 =?us-ascii?Q?ycvwdZpafo97Phhaiz/4mS7DyIihUoFX7Ql29zBAloj6j3JuzarcyMwFLnto?=
 =?us-ascii?Q?jtqdURvCLHmI29VPCH7t9lfD6zAHri+w2HR27x6LuV03YWRG5Kw2LGDNzjmN?=
 =?us-ascii?Q?x7IiQIxbGDYnh6HkXxEmlRO7J0y6w8F6eVsjJmrpCSFao0QPWTU6YzIFOwWW?=
 =?us-ascii?Q?m5UbNyauGCijKZhQHTuukPsEPGmbdHwFqHfWs/fl399tTcFNr9lk25JExmey?=
 =?us-ascii?Q?qN3hsdkD9bGva3Z+kGqfD+Ar5AlS3EZ+dm/8xSb3vjOehasTLbsTyBBgkeuA?=
 =?us-ascii?Q?RNgfKCEelf9FCawqElLeGi4xjvWtBGFzPoKK2SnQzRplYEtXGGUfcq1CVa4S?=
 =?us-ascii?Q?CEUhyDmt8GnX5nFhT8GBRIqmQfqp+5V/UjECHvc3+cv93QTfkZ8Lydx5x+YD?=
 =?us-ascii?Q?SHivpOG+szS/frUhIoGIbs175eZu96QXWOIA2hvJamqK8c9Bj8GVM4ypjGTL?=
 =?us-ascii?Q?a2CFl8cD2zOcMXUqGersJX5zMC0N+ozb13eICSI6QFW8KaBfazjrTpVufPhi?=
 =?us-ascii?Q?6imPf8JwVbDPFXLgz1nUY2Jwt5cE/qVeGPXXZEYy7ZAxJKvnlt7hqlUrTjbf?=
 =?us-ascii?Q?JqlMT3Ny8ZOy22SbwVPRLUtZtaD3f/LvKyvbEyucwllMS06nJIY20n5TLESI?=
 =?us-ascii?Q?smhJaAJfD/VO6VhaTQ87SKCnTuhtJdbS48pKWmS0Rwg8zPnVgwWuZZXMnFz2?=
 =?us-ascii?Q?wqH7JvQcVkppMA2djZzQxE6ExhuHw05kMa9u7tVkLJIt5xHppjDIkdKYqesI?=
 =?us-ascii?Q?99gBLRwMcM+985KH5b6BRDpeDkLseTcDnciTxp8RONmBNGB1KFpIEREGxY5A?=
 =?us-ascii?Q?inPIyNFaSRM3cWChQhTtwts9NKtdHFnmNmklOUwypPFqu3xXqJuUkSEmTJQH?=
 =?us-ascii?Q?eJXVyuaejELUTS4TmxJaYugAKyx/aDDO4qzJTS37RZDKZCuD9Z5ue/oflQZp?=
 =?us-ascii?Q?f/8o2glQkFBEN++8WM+cUStLZBu2P30Wdtwrrhn0XQrOnd5hITAZwo7UKpsz?=
 =?us-ascii?Q?SdmdJb+SSpPUdZbsu321QSQX62FgBxIbJHfWUxtoGAmVlpEcIb0Q/4l1xmS1?=
 =?us-ascii?Q?cAXtPVl+ybfPvcic+swCktvIr+9YuI7dHfZQ+NQwiVaXNJDlOfVya5NlbxP1?=
 =?us-ascii?Q?r6A1cFkAP+6V1cq10kV8km++CZKnFmFQVcIyHmVMoRwiQA+QRHaK83lv6yCF?=
 =?us-ascii?Q?mMMwDUp3OQ4W5qEvrn7E7WMBRrn9YgFl9oW3VpH4kwwAfPiPMZMzbcB60JhR?=
 =?us-ascii?Q?9VgpeEtWXnpyV2xX9VoUzzELHL7seuLEnI+6AIU8uqBQ+rYpS04IPHjSDfPU?=
 =?us-ascii?Q?Fob4Yyong8Gh3pZtw2neM2DezEtfUvMn2M5DvSXjAhEDJSlqDqqkT4rEJ73k?=
 =?us-ascii?Q?6mfI4oF7NoX88SkoHuLEe8qrGaToKuQQtFi8eWKa1l2cwG3Yr5+8nbxdXFt3?=
 =?us-ascii?Q?Viur98pi62DcIVvyFOOaRxgTmYgvXRsPCMRjJmvYRIorbtPlaaqcLTjpApt6?=
 =?us-ascii?Q?l7R5jHIdVVbJqzRxRh98bQubPuTAqrmNn8G+9cuN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dfbb165e-ed07-4d1f-5982-08dc0c753364
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 16:01:09.4815
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QVZlX6fTn8rvqo4itswMyWMBNnLabcwOh9gSfbgSdKQdlGi8GHXANcUIpHE37WlI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8843

On Wed, Jan 03, 2024 at 10:24:42AM +0800, Yi Liu wrote:
> On 2024/1/3 07:38, Jason Gunthorpe wrote:
> > On Fri, Dec 15, 2023 at 12:01:19PM +0800, Yi Liu wrote:
> > > > I think I misread Yi's narrative: dev_id is a working approach
> > > > for VMM to convert to a vRID, while he is asking for a better
> > > > alternative :)
> > > 
> > > In concept, dev_id works, but in reality we have problem to get a dev_id
> > > for a given device in intel iommu driver, hence I'm asking for help here. :)
> > 
> > I think we just need to solve this one way or another.. Even if you
> > use a viommu object you still end up having difficult coupling to
> > iommufd
> > 
> > Some:
> >    iommufd_get_dev_id(struct iommufd_ctx *ictx, struct device *dev)
> > 
> > Callable by a driver (using the driver-callable function
> > infrastructure we made for dirty tracking) Is really all that is
> > needed here.
> 
> yep, I noticed IOMMUFD_DRIVER was selected by intel iommu driver when
> IOMMUFD is configed. Maybe such an API could be compiled when
> IOMMUFD_DRIVER is enabled as well. This does address my concern on making
> intel iommu driver depending on iommufd. But still need a way to pass in
> the iommufd_ctx pointer to intel iommu driver, and store it. Hence intel
> iommu driver could call the above iommufd_get_dev_id(). One possible way is
> passing it when attaching device to domain and clear it in detach. However,
> this seems not ideal as iommufd_ctx information should be static between
> bind_iommufd and unbind. But we don't call into intel iommu driver in the
> bind and unbind operations. May need to add new iommu op. Any suggestion
> here?

You can pass the ctx to the invalidate op, it is already implied
because the passed iommu_domain is linked to a single iommufd ctx.

Jason