Received-SPF: pass (google.com: domain of linux-kernel+bounces-15730-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1364-ga51d5fd3b7-fm-20231219.001-ga51d5fd3
Precedence: bulk
MIME-Version: 1.0
Message-Id: <557cfaec-6721-4409-83c9-6a60742a5021@app.fastmail.com>
In-Reply-To: <ZZWBS5EugvO2dBp0@C02YVCJELVCG.dhcp.broadcom.net>
References: <20240103102332.3642417-1-arnd@kernel.org>
 <ZZWBS5EugvO2dBp0@C02YVCJELVCG.dhcp.broadcom.net>
Date: Wed, 03 Jan 2024 17:01:35 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Gospodarek" <andrew.gospodarek@broadcom.com>,
 "Arnd Bergmann" <arnd@kernel.org>
Cc: "Michael Chan" <michael.chan@broadcom.com>,
 "David S . Miller" <davem@davemloft.net>,
 "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>,
 "Paolo Abeni" <pabeni@redhat.com>,
 "Pavan Chebbi" <pavan.chebbi@broadcom.com>,
 "Somnath Kotur" <somnath.kotur@broadcom.com>,
 "Kalesh AP" <kalesh-anakkur.purayil@broadcom.com>,
 "Randy Schacher" <stuart.schacher@broadcom.com>,
 "Vasundhara Volam" <vasundhara-v.volam@broadcom.com>,
 Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnxt: fix building without CONFIG_RFS_ACCEL
Content-Type: text/plain

On Wed, Jan 3, 2024, at 16:46, Andy Gospodarek wrote:
> On Wed, Jan 03, 2024 at 11:23:11AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> A recent patch series generalized the filter logic in bnxt to no
>> longer just be used for RFS, but it now fails to build when RFS_ACCEL
>> is disabled:
>> 
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_cfg_ntp_filters':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:14077:37: error: implicit declaration of function 'rps_may_expire_flow' [-Werror=implicit-function-declaration]
>> 14077 |                                 if (rps_may_expire_flow(bp->dev, fltr->base.rxq,
>>       |                                     ^~~~~~~~~~~~~~~~~~~
>> 
>> Add back one #ifdef check around a call to the missing rps_may_expire_flow()
>> function.
>> 
>> Fixes: 59cde76f33fa ("bnxt_en: Refactor filter insertion logic in bnxt_rx_flow_steer().")
>> Cc: Michael Chan <michael.chan@broadcom.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> I don't know if this is a correct fix, only checked that it is plausible
>> and that it does address the build failure. If a different fix is needed,
>> please just treat this as a bug report.
>
> Are you using a kernel config with CONFIG_SMP=n ?  That was how I was
> able to reproduce this.

I saw this in two randconfig test builds on 32-bit arm, both with
SMP disabled, though I did not expect that to make a difference.

In case it helps, this is one of the two config files:
https://pastebin.com/raw/uxHEXzG2

> There is a good oppportunity to clean this up a little better.  When
> CONFIG_RFS_ACCEL is not set there is no reason to even have
> bnxt_cfg_ntp_filters included in the driver build.
>
> I'll talk to Michael and we will post a fix for this.

Ok, thanks!

     Arnd