Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7223048rdb; Wed, 3 Jan 2024 08:25:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IERDEV1oDs5Mwx2VApKx+NX2ov3C+xfw/98WklZ3cLqqziCplbfe3+lqfJdcNI+c20RLPqO X-Received: by 2002:ac2:5d67:0:b0:50e:383b:19bd with SMTP id h7-20020ac25d67000000b0050e383b19bdmr6974920lft.102.1704299111233; Wed, 03 Jan 2024 08:25:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704299111; cv=none; d=google.com; s=arc-20160816; b=yFzhcIYaolZIiZFetwelGpjMkgp/Lmoh8a/Ly33jT9MRl4sDllfwwGw7Tri5ht/eEY CWUDeJkrbR/JYfVAmBuSa7g5evtxaywcO/I0b66v77UoEw7rz28Jga7svi+vEthsD11m F7QOUc84AdmvGZItLYs0yk/8Criy/nyxDB0xJ043TNaZyyCtF3rcNzvOFSZLPMC+dKVs DoBITDq0qOAP4gmp4rMGKLkBxVgMikyQBJmTaYrcnM7BYXG5dZE/Ge4qG9nIyaol236K 38nuMa5/5z6GtPPHMg+rqJx8LVfeooLKzg00OJwgrhyE06rSdy+uIQIpVu1hbpInRqmd pHxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=F9SlIeWcaqv2yOr3ouOUtpw7mg0zqNKMNARNJ4ZDONI=; fh=0Ullwx05qUTaTunpWymXKtKJ7O5oDN7abEzzMHZP+x0=; b=cq/gwZzIv82PG3RGrylAwjEU/lH1XRnEW14TOnlS0JxWQXuTqKK20KJeuzPz/P+Kzl y9JaG9iNTzrlCPIKGfiASWf1pHa1AUlqigeaZ1jcV1jRZj1tbM684voKFZjCX0NiMvSe 14GoLpkqhxdCdOzzLyLfS6K+ECJny5Cs9bn1PdbqCIWRnODFQIFp9+N8DdPO8zebI8QS 1ee+Yp/WSuvm9mFDqfNTNUeYu/2i4B/B/YwbTifpCGAI9vud1Ph+5ZqQUBh0F3o3aX7N HX9Yxdv6FNcTsvbCffu2WCXSxjYxhMSsSBJmKhXjMB5BF5OnMrqLdUOgc4DyCygNLivo af3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cBGNN5Uy; spf=pass (google.com: domain of linux-kernel+bounces-15744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15744-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u20-20020a50d514000000b00552a9b8bc25si12328575edi.568.2024.01.03.08.25.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 08:25:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cBGNN5Uy; spf=pass (google.com: domain of linux-kernel+bounces-15744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15744-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A42711F24363 for ; Wed, 3 Jan 2024 16:25:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B91B41BDF1; Wed, 3 Jan 2024 16:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cBGNN5Uy" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9B61C68D for ; Wed, 3 Jan 2024 16:24:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a271a28aeb4so681496766b.2 for ; Wed, 03 Jan 2024 08:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704299074; x=1704903874; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=F9SlIeWcaqv2yOr3ouOUtpw7mg0zqNKMNARNJ4ZDONI=; b=cBGNN5UyHYH5DriH6iwbIRiDM39qZLlBWX9XIkEunysnHkE8qDlUHBGRDvdUTrTafk EM+lfyXrR/8vaXtb8Kwy3oZRchBkHksiDwiO1OLHFBohcdD/ffPO+d/Sf90ZrOOLgyAO k03CI9eFJPfc/9X2PpZ3Z5gR8w7EUBBK8ParTD873IhY9jz4y2W1r5x7hWhuIfx+WdcR AJ9Kare3PjPmx5f6PG4o6Bxaq5XMGzCwROwY70ls0qPaq5zaAPJnv5YI7HFrT15v+yIR tbyj9mIrHQ7atnpK8iUPxc/fGrSX76uGA8qoO6tIUOk/LT+6SoeaDPZIWUDlkIlrtkv0 QdmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704299074; x=1704903874; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F9SlIeWcaqv2yOr3ouOUtpw7mg0zqNKMNARNJ4ZDONI=; b=IQ8gf75v/9RyomPEC53ZaOTaWqrbQHqXoQIo2Sqh6YtpN30bfNBhLy6qpRXBrWZo2S z8IiVYxBvxgk3g75n2PokbgABEFwtc+ocaJpQxS40dDNgmaYFlL1y+bWE4Jw1rQ4ilVl z9TyyhcjwscaETBQGRNi8nYE5BoRDHqgO5WhQ1Ne4QijrMvw6LSfA04X7Oiy0xmPrYd9 Jb8QGNhCWnKDKRJxHQ4YLdmnwXLC0ExAjnVRM/wJzPGY65jZp7jjKfrn/n4IVFAOxwzt f0fUMdKKL6E0vJsv0CFElp2Wa4adWVC6cKsEkUavD4YuN9b71r878SPk5nAJJItO+XmN gWGA== X-Gm-Message-State: AOJu0YwB4pHih5ApCY6E/u5x/kS7vDRC5lQ2gYRQLXpD1/Zsfdj5z8yG OFRqu/hH+c2hR+iNI5/WDlssVt0kuusqSA== X-Received: by 2002:a17:906:1251:b0:a23:3753:c64c with SMTP id u17-20020a170906125100b00a233753c64cmr7329354eja.57.1704299074602; Wed, 03 Jan 2024 08:24:34 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id vz8-20020a17090704c800b00a26c308df74sm11186558ejb.195.2024.01.03.08.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jan 2024 08:24:34 -0800 (PST) Message-ID: Date: Wed, 3 Jan 2024 17:24:32 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] arm64: dts: imx93-var-som: Add Variscite VAR-SOM-MX93 To: Mathieu Othacehe , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Li Yang , Stefan Wahren Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240103143639.32280-1-othacehe@gnu.org> <20240103143639.32280-3-othacehe@gnu.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240103143639.32280-3-othacehe@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/01/2024 15:36, Mathieu Othacehe wrote: > Add DTSI for Variscite VAR-SOM-MX93 System on Module and DTS for Variscite > VAR-SOM-MX93 on Symphony evaluation board. > > This version comes with: > - NXP i.MX 93 Dual, 1.7GHz, Cortex-A55 + Cortex-M33 > - 2 GB of RAM > - 16GB eMMC > - 802.11ax/ac/a/b/g/n WiFi with 5.3 Bluetooth > - CAN bus > - Audio codec > > Reviewed-by: Fabio Estevam > Reviewed-by: Krzysztof Kozlowski You made significant changes, which invalidates both reviews. What's more, you did not test the changes after adding them. You must drop the tags after introducing such changes. > + > + key-menu { > + label = "Menu"; > + gpios = <&pca9534 3 GPIO_ACTIVE_LOW>; > + linux,code = ; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + status = "okay"; ??? > + > + heartbeat { This wasn't here during my review > + label = "Heartbeat"; > + gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Best regards, Krzysztof