Received-SPF: pass (google.com: domain of linux-kernel+bounces-15781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Jan 2024 12:58:48 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
	"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
	"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
	"peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com" <shameerali.kolothum.thodi@huawei.com>,
	"lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
	"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"Zeng, Xin" <xin.zeng@intel.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: Re: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Message-ID: <20240103165848.GR50406@nvidia.com>
References: <c967e716-9112-4d1a-b6f7-9a005e28202d@intel.com>
 <BN9PR11MB5276D14D2A7FF60B41A6A7B48C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXu5whlIGfiq16wF@Asurada-Nvidia>
 <BN9PR11MB52766D7F774510E0181CC89B8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZXvI2IiXwwuHRE8V@Asurada-Nvidia>
 <7c398efc-8a2f-479d-bcff-ded8cc1ef3d0@intel.com>
 <20240102233849.GK50406@nvidia.com>
 <c59a780d-4030-4815-a34b-fb2e2f902ab3@intel.com>
 <20240103160108.GP50406@nvidia.com>
 <ZZWP7iBqUtbTRb3s@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZZWP7iBqUtbTRb3s@Asurada-Nvidia>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?LlFiXEHJhRDSZ1yZ40zBvj+WQ/ikjfHaBETXBg0bmkZr8FzQcEdAQWA6Q3CY?=
 =?us-ascii?Q?psEvWdSkMcs5VVfomC0Q8c/NbhIKuMhQYUDaoBKEvYAC/29C1etZIlvAn2MK?=
 =?us-ascii?Q?ocCh4FyF3sAYUV9Kr/HO03Gl23eqPhUxZoWcvgTGZc6zdQiS92dQENdQ+Ncy?=
 =?us-ascii?Q?4KI2/EJvxCx+aWMWYibJu+A6yaGgfqtiiZIlXFd6wRqFDrs4NKvQMNJZv1uM?=
 =?us-ascii?Q?utYmRxLpKuCL3wiKQSl2ngitzfD3OhoyJY5KLQmoOwA2JFZS1nUPMoiQ6pg+?=
 =?us-ascii?Q?ociXoJ2TMuWG5g4ZMefeQ6Qv5w6ThWgC6qHNOExqyEzoS0kCL9OR47aXccMw?=
 =?us-ascii?Q?2D5q8JFuJDKCVKvvS6nNtpr7HyRQ3RxhpCiqC6IVSik9AKWrBeLFnPXI5WvO?=
 =?us-ascii?Q?tnIwD0ahYzBnNMl931Uo+kQvnxfLe2EVP2NFaDF8fz5MMWs0gp/YEfESmeC3?=
 =?us-ascii?Q?LtM4WITHwVgRAqlvZHwE2+5Hk/UxgAMMHp1hvXHdGp47CqIFfZtjH/7D2wqt?=
 =?us-ascii?Q?EiJSif2GYOsb0Ib96PtE9EeAtDfJj0w6ryUcZoP6DRZZdgfwGIWuI1WYGM2D?=
 =?us-ascii?Q?d5LevYpHQZUEarS3uf6B9YhG+Nk49h6W9ULkBrrV78ZAh82Q9zNFnLc62Dle?=
 =?us-ascii?Q?wMpdbd7EAZU0Jv/+GoADw9izuGE/pGdsVI8wrmuamw1bOMiwLLpJDh4nxWzH?=
 =?us-ascii?Q?m9eSiAXq9xBS6o+veS99hHYTWYLJBoNG6po76k51SWNiqpiaw7MeMzC7Rf3t?=
 =?us-ascii?Q?X020sB1AAfKj4lebHpZ+vsY8TTg06iParEYANmKfkEnLVvuA9HBTKguIIvNH?=
 =?us-ascii?Q?9nqoFNkpn9AxMYlNK+7BD4jkJfP2DaQi08R3VRIQaHo/v+m/wO50WMrd3mc4?=
 =?us-ascii?Q?uqppZZJZ4hQTVPZVr8J4K9MZWMWW/mIFrdOXWtb3HIpDvM7zioLsXet2kAqj?=
 =?us-ascii?Q?PP17WzfsXzAqH+LeGYDJx0A1qwikJAnRQaUWle14SKeEgvYPmrLftMVRIBPE?=
 =?us-ascii?Q?aauqP4sAM8ASLqoWt/GtaS+cOC/CvGOVvgwARvKOxMH44zIR2JejGQ3QulXl?=
 =?us-ascii?Q?u1Hvk/2Z2Joeh/JNLKFSYzVoczKpmq9LVi+TfFCvAIyrLIoBKs7Q/0WcrOEG?=
 =?us-ascii?Q?fxIKgT3s/0QNw1DC3JePsVN6VYqyKS/qbwPMWgqhXimngLAn1GEbgPWJIF2v?=
 =?us-ascii?Q?2x9GaRxy2lqbGE+jr2eSznuXIRkasg7to7FgWTaeVl3bhH1WV5T5eWFMFSos?=
 =?us-ascii?Q?wzY72z6CIxTv2cirB8FgOpXzgeKx+Ok00hJdAD+56dv/MWwqTPNq51GTuCmj?=
 =?us-ascii?Q?/atGZJf9/h7Ulm430m5ZaLCovFLaAxgaBjukmKYvyxyg94jdqzRqlhwAM98K?=
 =?us-ascii?Q?0lEliTZc1EDkaq5MbWXZDLf4lG6Iywp4CV3dUxRCNnOu/oxGH9MuBmHQHXDC?=
 =?us-ascii?Q?v2tvmE1yrW0DX42K6kK1fm9qenEKGWFy4iiEAaMCCP/gz8SD832YI/jWaIm4?=
 =?us-ascii?Q?VG5M9YKlFe5vNnxq2Qt+FXzit6HcMtnqvm6/R6wSfrJl1O/7TlNYWWrwEJxl?=
 =?us-ascii?Q?jW3PDj5vUA7jukEivAe0Qq846OM9VTuvyNg9n/Tz?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56feeb23-eadd-4d04-d221-08dc0c7d41cf
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 16:58:49.5696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hzjB9SJ1au1ql5mlOwj8jUGvH0Vphpxxw62i9OARBz6CiKiTdIQViyb109hM0rPL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5489

On Wed, Jan 03, 2024 at 08:48:46AM -0800, Nicolin Chen wrote:
> > You can pass the ctx to the invalidate op, it is already implied
> > because the passed iommu_domain is linked to a single iommufd ctx.
> 
> The device virtual id lookup API needs something similar, yet it
> likely needs a viommu pointer (or its id) instead? As the table
> is attached to a viommu while an ictx can have multiple viommus,
> right?

Yes, when we get to an API for that it will have to be some op
'invalidate_viommu(..)' and it can get the necessary pointers.

The viommu object will have to be some driver object like the
iommu_domain.

Jason