Received-SPF: pass (google.com: domain of linux-kernel+bounces-15811-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231207014655.1252484-1-irogers@google.com> <CAP-5=fWdAouBb7us44HOdd+ZfBj5fLFTuLCokbG8w3jVuQgTxw@mail.gmail.com>
 <ZZWK43OPvGcd-BAR@kernel.org>
In-Reply-To: <ZZWK43OPvGcd-BAR@kernel.org>
From: Song Liu <song@kernel.org>
Date: Wed, 3 Jan 2024 09:40:26 -0800
Message-ID: <CAPhsuW6EZ-FoZFbCuxs7gAa0OaQGw0zMLDaeEsNoU31vjXijnQ@mail.gmail.com>
Subject: Re: [PATCH v1] perf env: Avoid recursively taking env->bpf_progs.lock
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Namhyung Kim <namhyung@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, 
	Ming Wang <wangming01@loongson.cn>, Ravi Bangoria <ravi.bangoria@amd.com>, 
	Huacai Chen <chenhuacai@kernel.org>, Kan Liang <kan.liang@linux.intel.com>, 
	K Prateek Nayak <kprateek.nayak@amd.com>, linux-perf-users@vger.kernel.org, 
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 3, 2024 at 8:27=E2=80=AFAM Arnaldo Carvalho de Melo <acme@kerne=
l.org> wrote:
>
> Em Tue, Jan 02, 2024 at 07:00:53PM -0800, Ian Rogers escreveu:
> > On Wed, Dec 6, 2023 at 5:46=E2=80=AFPM Ian Rogers <irogers@google.com> =
wrote:
> > >
> > > Add variants of perf_env__insert_bpf_prog_info, perf_env__insert_btf
> > > and perf_env__find_btf prefixed with __ to indicate the
> > > env->bpf_progs.lock is assumed held. Call these variants when the loc=
k
> > > is held to avoid recursively taking it and potentially having a threa=
d
> > > deadlock with itself.
> > >
> > > Signed-off-by: Ian Rogers <irogers@google.com>
> >
> > Ping.
>
> Applied, with that minor patch reduction hunk and this:
>
> Fixes: f8dfeae009effc0b ("perf bpf: Show more BPF program info in print_b=
pf_prog_info()")
>
> Song, can I have your Acked-by?

LGTM. Thanks for the fix!

Acked-by: Song Liu <song@kernel.org>