Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7268667rdb; Wed, 3 Jan 2024 09:52:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEu8KRHOxVQpyExVgV7uCY0xjioobVtR6uwDwuV74uHjQyoZmfwDtlU79FShNz9Wnsuwh4C X-Received: by 2002:a05:6402:789:b0:556:ec3e:3204 with SMTP id d9-20020a056402078900b00556ec3e3204mr58592edy.50.1704304379075; Wed, 03 Jan 2024 09:52:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704304379; cv=none; d=google.com; s=arc-20160816; b=EfnOpQ4pIttoK88TL8iazb2z5GDPGBD/MevaEndTfNbtr/S/7CdRFdzMBlFKTVK9Hz uCEy3ppR2ctKMJbczApX87nqe5IPmaSp/JZduzKsZMBsQIxXTvlZiBuWazvm/2oqrkHX mw+SS4v1HKmDM5CkJ7uR+Jb7x50svMk02nhwfpbT1Z03qdU4zURjr8J6SvHL83kA+0/m HKhIt4HrdmVHDi2DwohKWtRBWiswJHkmiFx1GmsMHwatoLv6ilBkN8wV99ZmFoe2lJpl VsetkezL/fbTMgI/Vz0BlDLl7kxdrBrGAgUiEyCKhKPLoRM/krM1iZelhj2Nv6mkJJZT mQAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fF4q/F4qXHjBbLy1HCV4LjIA8ryy4tB5s8RSIwCOUYg=; fh=oUQXlm9N18NE8BciMxTG8yakJePvyLDL7KOQwgHv8WI=; b=a0yT7b9w0+18A9oSj8sS55unkH5foIhbzgUJ2pMWW8CTKz4ZeG5MowXAmW0AHUEk4i Xs5P/+PiUUBgCAWxUJXCCKa4zQOnoHFc/0WE758HffmrLCIU/ZzZc4P1i4WxUg28IE1g L7uQc/I2RPBx0l/Lxj1ArIW2onLSQ9IVKvlauLIMT0iXyfGatE6/xtOL+E1a5HSZauyf hj2YpvOgHgQTrQubayVpPwCNzEgDjkBbnVcVfBgfD/rSGHI+aQZvhssnFsegF0mDjL6F XV2bPyWsNkHACeIKCwRjxdKZ8KW7Kz5j+YDB/aWlajomYlYWd44WErZ21a1gEj9VEcAk /UQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ss1HqxdB; spf=pass (google.com: domain of linux-kernel+bounces-15823-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15823-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m5-20020a056402430500b0054f63eefdf5si12372526edc.583.2024.01.03.09.52.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 09:52:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15823-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ss1HqxdB; spf=pass (google.com: domain of linux-kernel+bounces-15823-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15823-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B96041F24F05 for ; Wed, 3 Jan 2024 17:52:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39D2C1C698; Wed, 3 Jan 2024 17:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ss1HqxdB" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6A11C2A6; Wed, 3 Jan 2024 17:52:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49F28C433C7; Wed, 3 Jan 2024 17:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704304368; bh=v4FnOT3+qS+6Q7aq9Kz0FybsYzgazhhzJUuxOz3LL5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ss1HqxdB559XH1OG9QLVj/IntPizmprsqe5d39xYMFi3kgKSf8ikKu+PU1OoAdEbC 09ROyfaV0IBSVIVRh+zPpMSXn9cSHMCnaDKERo4QQ5yGB7g7vDeILdN54UdpTlZvEz IS83nvKlHKuda0I02T2FC4ivDUptwZKcGwN9fI6TaRoSWZcIjQWUd+yLUXp1HVh6Lp S0zDHARvH4ADrFs0GeusmL1Iy7vnOcUbdy4mayvsouv6SUeSEH3R2RpE4a6FdKoEGr Azy0x16uqMnaLhH/KscabZPnNybpqKdr9l0QDPQlILyGaeTpTOy5VsIOcmH0yrA/vo KQwWeXS7ZcKtQ== Date: Wed, 3 Jan 2024 17:52:42 +0000 From: Simon Horman To: Sneh Shah Cc: Vinod Koul , Bhupesh Sharma , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Andrew Halaney Subject: Re: [PATCH net v2] net: stmmac: Fix ethool link settings ops for integrated PCS Message-ID: <20240103175242.GC31813@kernel.org> References: <20231226083432.24920-1-quic_snehshah@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231226083432.24920-1-quic_snehshah@quicinc.com> On Tue, Dec 26, 2023 at 02:04:32PM +0530, Sneh Shah wrote: > Currently get/set_link_ksettings ethtool ops are dependent on PCS. > When PCS is integrated, it will not have separate link config. > Bypass configuring and checking PCS for integrated PCS. > > Fixes: ("aa571b6275fb net: stmmac: add new switch to struct plat_stmmacenet_data") Nit: a correct format for the line above is: Fixes: aa571b6275fb ("net: stmmac: add new switch to struct plat_stmmacenet_data") > Tested-by: Andrew Halaney # sa8775p-ride > Signed-off-by: Sneh Shah ...