Received-SPF: pass (google.com: domain of linux-kernel+bounces-15829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231220083224.3712113-1-visitorckw@gmail.com>
In-Reply-To: <20231220083224.3712113-1-visitorckw@gmail.com>
From: Ian Rogers <irogers@google.com>
Date: Wed, 3 Jan 2024 09:56:29 -0800
Message-ID: <CAP-5=fXwa-GSDJX3pO-LSz-D_X7qk2Ck1vtdddtV8ixzsO+5BA@mail.gmail.com>
Subject: Re: [PATCH 0/2] min_heap: Min heap optimizations
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 20, 2023 at 12:32=E2=80=AFAM Kuan-Wei Chiu <visitorckw@gmail.co=
m> wrote:
>
> Hello,
>
> The purpose of this patch series is to enhance the existing min heap
> implementation. The optimization focuses on both the heap construction
> process and the number of comparisons made during the heapify
> operation.
>
> Kuan-Wei Chiu (2):
>   min_heap: Optimize number of calls to min_heapify()
>   min_heap: Optimize number of comparisons in min_heapify()

Thanks Kuan-Wei,

The patch series looks good to me. Given the extra conditions should
there be some updates to:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib=
/test_min_heap.c
to ensure coverage?

Thanks,
Ian

>
>  include/linux/min_heap.h | 44 +++++++++++++++++++++-------------------
>  1 file changed, 23 insertions(+), 21 deletions(-)
>
> --
> 2.25.1
>