Received-SPF: pass (google.com: domain of linux-kernel+bounces-15945-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [PATCH 1/4] acpi/ghes, cxl: Create a common CXL struct to handle
 different CXL CPER records
To: Ira Weiny <ira.weiny@intel.com>, linux-efi@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Yazen Ghannam <yazen.ghannam@amd.com>
References: <20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240102150933.161009-2-Smita.KoralahalliChannabasappa@amd.com>
 <6594387015431_151dc12949a@iweiny-mobl.notmuch>
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Message-ID: <321f2cd2-ec64-3def-857c-61c4054f8be2@amd.com>
Date: Wed, 3 Jan 2024 12:04:02 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
In-Reply-To: <6594387015431_151dc12949a@iweiny-mobl.notmuch>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?KzJad1FaNDI4NndEam4rbUpKL2JRUEtidmEweTVRN09aZTJ1VGVhK0RNVTVH?=
 =?utf-8?B?YUhlWEVkVThXdnduOWs1MTF0TUNrbDZiU1g3NVFCekVXSHN0VnYvRlhjK3g0?=
 =?utf-8?B?cGFmQzVnbUJRTU45WFBtejhHRGZKUkhHbTdycXJ4elBKRzQ2cVhpcXduSHF4?=
 =?utf-8?B?R0dqdTJ5VUNxMmQrU3RndUN2R0t4YnUzanRIaWY0b3ZpZXpMVUJzNnZRMjRJ?=
 =?utf-8?B?NVJNU3ZHOUhIWm5oNHEzRmlpSERUdGh5aU1HWHh6WDRHdmhSdDNSTnRGQlZB?=
 =?utf-8?B?TUR4a2xLT2loeFl2aklTK1oreTM5KzExRDVrdmdOTG1ETHRSNGYvd0o0Tklj?=
 =?utf-8?B?YUJ4VnhpR2J3UmZTeGRqL2ZmdGUvOXhONUhCcXpycmdCQjRQeUZuOExiYXZw?=
 =?utf-8?B?ZTUyWEthdFhRdXh3NjVrNW1wazRKSW9aM3IyUDJJbXN6ZmRCeXU0OUNIVWJi?=
 =?utf-8?B?Z21SSk0zaVQ3c2RDTWtxbEJ2aGsvQ01sM2R4RVJUR0U0a09yU3BIc0YyQnpO?=
 =?utf-8?B?QWdDQXZ6UHRQcUNYWkVVTy8ydDR0alVlQ2dBV0twbUp5ODFqSzhqY052ZUJ0?=
 =?utf-8?B?WHU4NUtFaTNCaFJKYWpuQXNmZklQaGtaZXpGd3ZLNnJDUGxYUHdEWXBYcEhy?=
 =?utf-8?B?aUkzMmdLR0NwZDlzRFIweGxzeU1jM21nL2tZdjdIZVBsN3NXNXRTZ0ZlTEpM?=
 =?utf-8?B?S1hQK1BaZXk3VWcvMDBLUFo4cSsvU3lzaGFwSmw1cURNcFN3d2FtSEk1TnVY?=
 =?utf-8?B?ejVlUEd5U0hyTnJtdHF6WHFicm5GbEZYNWhBVEtWbnFwUzlJS0h3bzhBVVU0?=
 =?utf-8?B?Tms0YVVaL2NDNDdMOTdHZU9jeVV1YjZQdDNTZlpHalBhM1ZDTUVSRk9XcW5u?=
 =?utf-8?B?QVI3MTFMRUhlLzQ5WjU2cWNubmd3VmRtaElyaTBScGxsRXZwamNvdGFqTklZ?=
 =?utf-8?B?TENhQU1hU3IzZEhFemtZQjZxbnowcVB5c21nM1lOQzNZbW53c1Iwcnc4NGE3?=
 =?utf-8?B?NXJ0MUsreS8yL0Iyem5iZnIzUDdaQTVFUXByNWVNa0c2bHVjOGloUWxJT1NX?=
 =?utf-8?B?UFlQaUUxUkd6K2FXOU15bFFiRm1ZYlVuMGhteUo1R0JnUE9BeU9nbGRxYWdV?=
 =?utf-8?B?clFNQ0JIeEkwMllaSkh2SVgvb2RQRlJXam51ZlRkeGxLMFJpVjVSVy9Qa0NN?=
 =?utf-8?B?YjJadU1MZGs0bUtla2NrblFtS01NdStKRnVnMnYxMXhGc1BraGd4R1o5UVRk?=
 =?utf-8?B?b2w2UWRwL1B3cUx6YnprakwvNERTeEFKZEkxcCtlWVJIMVVScEFjdVZ4OFI0?=
 =?utf-8?B?TjdqS2lRMmNJWlBxUmtNeWRGSWVYdzZhNDhvODVOTGFYc0sxZjJIQUdXUWhI?=
 =?utf-8?B?QUdNanpUMkg0NVJYb2JtSnExNHlBanlIajYrbklzMnVKZys3eitBK3NQZnBY?=
 =?utf-8?B?Q0ZFT2NlQjdPVHkvRk8wK3VpZjFnUWVjcXdINlZWRnN1T0p3ODZvN2w4VmxT?=
 =?utf-8?B?NlllK0Zxb2xZS2tNWFdzbnZLSWRVWG9mcEk4MlNnQmhlQXNaNmQ2cldBSkl4?=
 =?utf-8?B?cDQ3cDU3WGxCOFdKVUFZVEJrS2tEMVVjUCtKaFJjTjJBNG1FbUp5ZDJRdVk4?=
 =?utf-8?B?cG8yQWo4alNNRTdhd2YwSXFhS0RWbFduMGJDZUdHcklLU2tGdHVmb2wvSDM5?=
 =?utf-8?B?dXhDWnQyaE5sUnhBSC9hZVZHeWdBZ25SaTVvc2psbHRwOUFGakg0WURSL1Fn?=
 =?utf-8?B?clhmTm9XQjk2RGJSZEk3anN2NkdQT0Vmb1BxNTV4bGFjZW1iY1JxcnRoTWZS?=
 =?utf-8?B?TnMzTGpHcXNWb1VnNjFSbVZBdHQ1aVBFN25palZPYi8zS0lBbFc0NHFyTUlY?=
 =?utf-8?B?d2lhdHZUNHlOV1ZhMVBqMU55VkFSQ1ViNFl2Vy90U3E5Y2tLZGtZVmNDYlhM?=
 =?utf-8?B?R21sbWJ5YkhvMC91MGhjSVFxZERaY015cnhWZGFHeWNteFNWaHhOZEpkWmJs?=
 =?utf-8?B?VUVMbDFyMkNhNU9CY3RwZ0V6WlZxSkx5dHJOTEZrRDFCSCtLNlR5T0d1eEl4?=
 =?utf-8?B?L3B0MVVYYk90dUQ5V0MvbHBrYldsd0pNYzgzWGR0SGdsV1kwWk1KQUV5eVlx?=
 =?utf-8?Q?oMcBAjjq1fUNLx142h0taYJg/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3247b33-51bb-4414-2a75-08dc0c9722e5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 20:04:04.7050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ruUCRuXUUlEr7zcPUytk1UVkHv9cOUKlobfxpDFzSkf4UsLTN/PcP0AokmfLIAlTvVX/N8xwgBH9i2NRCARmGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8118

On 1/2/2024 8:23 AM, Ira Weiny wrote:
> Smita Koralahalli wrote:
>> Currently defined cxl_cper_callback interface between CXL subsystem and
>> GHES module is just confined to handling CXL Component errors only.
>>
>> Extend this callback to process CXL Protocol errors as well. Achieve
>> by defining a new struct cxl_cper_rec_data to include cxl_cper_event_rec
>> and other fields of CXL protocol errors which will be defined in future
>> patches.
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
> 
> [snip]
> 
>>   
>>   static int __init cxl_pci_driver_init(void)
>> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
>> index 17eadee819b6..afa71ee0437c 100644
>> --- a/include/linux/cxl-event.h
>> +++ b/include/linux/cxl-event.h
>> @@ -141,8 +141,12 @@ struct cxl_cper_event_rec {
>>   	union cxl_event event;
>>   } __packed;
>>   
>> +struct cxl_cper_rec_data {
>> +	struct cxl_cper_event_rec rec;
> 
> NIT: I would call this something like event to distinguish it from other
> record data.

What do you think of the below?

struct cxl_cper_event_info {
	struct cxl_cper_event_rec rec;
	struct cxl_cper_prot_err {
		struct cxl_ras_capability_regs cxl_ras;
		int severity;
	} p_err;
};

Addressed changing to sub-struct and copying the struct rather than 
pointer comments in patch 3..

> 
> Other than that this seems reasonable to me.
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> 
> [snip]
>