Received-SPF: pass (google.com: domain of linux-kernel+bounces-15951-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 4 Jan 2024 04:08:45 +0800
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Ian Rogers <irogers@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] min_heap: Min heap optimizations
Message-ID: <ZZW+zcfFOa5YgK2j@visitorckw-System-Product-Name>
References: <20231220083224.3712113-1-visitorckw@gmail.com>
 <CAP-5=fXwa-GSDJX3pO-LSz-D_X7qk2Ck1vtdddtV8ixzsO+5BA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fXwa-GSDJX3pO-LSz-D_X7qk2Ck1vtdddtV8ixzsO+5BA@mail.gmail.com>

On Wed, Jan 03, 2024 at 09:56:29AM -0800, Ian Rogers wrote:
> On Wed, Dec 20, 2023 at 12:32 AM Kuan-Wei Chiu <visitorckw@gmail.com> wrote:
> >
> > Hello,
> >
> > The purpose of this patch series is to enhance the existing min heap
> > implementation. The optimization focuses on both the heap construction
> > process and the number of comparisons made during the heapify
> > operation.
> >
> > Kuan-Wei Chiu (2):
> >   min_heap: Optimize number of calls to min_heapify()
> >   min_heap: Optimize number of comparisons in min_heapify()
> 
> Thanks Kuan-Wei,
> 
> The patch series looks good to me. Given the extra conditions should
> there be some updates to:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/lib/test_min_heap.c
> to ensure coverage?
>
Hi Ian,

Thank you for your review.

The current min_heap test is sufficient to cover all the code changes
introduced by this patch series, even when only tested with a known
set of values copied from the data.

Additionally, I'm unsure if the commit message title prefix I used is
correct. Perhaps I should use "lib:" instead of "min_heap:"?

Best regards,
Kuan-Wei Chiu