Received-SPF: pass (google.com: domain of linux-kernel+bounces-15990-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 3 Jan 2024 12:35:52 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, Ira Weiny
	<ira.weiny@intel.com>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
CC: Ard Biesheuvel <ardb@kernel.org>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>, Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH 1/4] acpi/ghes, cxl: Create a common CXL struct to handle
 different CXL CPER records
Message-ID: <6595c5283a043_2308294bb@iweiny-mobl.notmuch>
References: <20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240102150933.161009-2-Smita.KoralahalliChannabasappa@amd.com>
 <6594387015431_151dc12949a@iweiny-mobl.notmuch>
 <321f2cd2-ec64-3def-857c-61c4054f8be2@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <321f2cd2-ec64-3def-857c-61c4054f8be2@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZaveNLt3xqyZodd9Cujzqw/W2f4KBApfu8xENhGvdmtZ51heQoUJa1EtZSTF?=
 =?us-ascii?Q?lPb6XEHebBNY+T7iYlol/9bhCLLpyY/OgzBkRWJ1zuXyvNlrHTyejEH10aOR?=
 =?us-ascii?Q?TvTc3gOpzybrPd5SUbcLLpGTUcDHqAS8Dr3F7oQBV599I24y1FfypPQnyiWM?=
 =?us-ascii?Q?lZtQN8t3l1bxPyFPqsIVpjGl1ZhPIC33QclpSzrY5ur14MBQCq3aad+IQVtz?=
 =?us-ascii?Q?xsO5oSkC8AL+iAQUYP9p3Q2XLckVuRhhcQWxTXekSHNpxzi0KLxx5LSpUpY1?=
 =?us-ascii?Q?EIwRcpkP8OWXB3enL7sava2mNVUkRoHfxmz58AgpgkNGHG9L0uAb5daYAL4a?=
 =?us-ascii?Q?J4KtV69NmbaQl99lCUN3TzcRuhu/eUWqWb36P2k7afh34yXZAr4eXsnIwBHM?=
 =?us-ascii?Q?OTIVtRSwqmGXX/AqA56APH3lGc5sMb8RdlfTr0BDeGYAanjPILUnxXiM22EP?=
 =?us-ascii?Q?U07GlFOjtnnHPv2sYoEDYyuH7B7g6SLAQbs8PuGkYQfO6uXgt9R+gVvQyjVC?=
 =?us-ascii?Q?c7oqO+tNK6rOs6fjM+h1TPqwn0grabaa6UHqU0c6dL9s7nUQ5H8KpJ1m75fs?=
 =?us-ascii?Q?eT31Qf3LzNXNtGSzLu4tCl98VMTAbP9Ni7RXgEoIGOVcDdrxvHYheE99pyJY?=
 =?us-ascii?Q?dx24NwnvR4XeZiKBX0QgcBc1CQe6MZu3GUtpe+w/5KNFOAPsEClUmmQo83fQ?=
 =?us-ascii?Q?xcMol+aj4PSqPKzfCRntUr6b4x+lKHlzXOJTYJfiiKSi463K3bju6FzKxGFZ?=
 =?us-ascii?Q?C/W7UnX7QAvKSZRUODk6YGDY+lNuYQanzA6a2W+FnpMpIxATMTPN+3/oG1ZV?=
 =?us-ascii?Q?mm5CBkiR2x5avKHbmZPK/r2RvPy4TnMAGclObfv0DmGMb4hoJWn1yzyFv+2M?=
 =?us-ascii?Q?fWykovvC/Yq+xMVn0ZNHAVhDOJzOEOWWVZC8HNB8Xl2uBBzFIsvhcuiDJKb7?=
 =?us-ascii?Q?02xKPR/RU0eKNRGNcBKdpTRtapMPnrg+9xe24gH+9rFgYATtaTwkb2iINtr7?=
 =?us-ascii?Q?PH66C9h56CmMJrAONiYl3DWVZUGw7eGFyGNtZ7qWtiZ6ibA51MC9pP3L8k4L?=
 =?us-ascii?Q?wDI8Z/wcQyeqA52v1/oRsekOMgpuronO7YIC2FFmnOoxAbbo362pZgqqrBjW?=
 =?us-ascii?Q?bzCIwXtMx4tP/UVme0ygHCAxnxPTDJ+MGunJUKTx6eIcqgUR2c3hZbdSxOvt?=
 =?us-ascii?Q?vhpcIJksLAfNKkI4VaCsVqQEXWI2DXXXg3iISEPmo/bmApsj/tOiCa2v8uca?=
 =?us-ascii?Q?n8wuUJvFalhIsWr3WGzElhhJ6/UpKWsrymiqAGvJDaowPufLgOq3rH+gnkH5?=
 =?us-ascii?Q?eBQRQtx4PYiJ6KuoLAQj8231OMTe4qdBiHEMnVGYGYTtKvFOjtf3OrVkwg3w?=
 =?us-ascii?Q?BDSBodMbRumgEJYx3Qw5+Wrs2fozOuEjf/kY9Qb7BonHWVIMgst08IQwCEyA?=
 =?us-ascii?Q?VdmNrNkjQFZ95XgadV/jqHIQeQb88GZZOKDcJM33+Ie+Bnc9xzdyf89Eogtb?=
 =?us-ascii?Q?7eOzfIpCjnNkbGqEdR0As17ienGt7j27QNSrpyWgpAlpdXBwOX5KkltofE36?=
 =?us-ascii?Q?Fag90wuOdvp3RHDSNMbx7t7I0Mnk0o8vUbPatra1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b522213-3449-4b22-7e85-08dc0c9b95ed
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 20:35:55.6085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OqLBub7WZAoL2EaGxvubddcTgKvvN3j2fk7RPMndBdroPdqPRHc7s8W93yo2efjz7SO6QMqQtsTaUYaFVBvNcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5084
X-OriginatorOrg: intel.com

Smita Koralahalli wrote:
> On 1/2/2024 8:23 AM, Ira Weiny wrote:
> > Smita Koralahalli wrote:

[snip]

> >> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> >> index 17eadee819b6..afa71ee0437c 100644
> >> --- a/include/linux/cxl-event.h
> >> +++ b/include/linux/cxl-event.h
> >> @@ -141,8 +141,12 @@ struct cxl_cper_event_rec {
> >>   	union cxl_event event;
> >>   } __packed;
> >>   
> >> +struct cxl_cper_rec_data {
> >> +	struct cxl_cper_event_rec rec;
> > 
> > NIT: I would call this something like event to distinguish it from other
> > record data.
> 
> What do you think of the below?
> 
> struct cxl_cper_event_info {
> 	struct cxl_cper_event_rec rec;
> 	struct cxl_cper_prot_err {
> 		struct cxl_ras_capability_regs cxl_ras;
> 		int severity;
> 	} p_err;
> };
> 
> Addressed changing to sub-struct and copying the struct rather than 
> pointer comments in patch 3..

That is much better.  Thanks!
Ira