Received-SPF: pass (google.com: domain of linux-kernel+bounces-16003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jonathan Corbet <corbet@lwn.net>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, linux-doc@vger.kernel.org, Mauro Carvalho
 Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] scripts/get_abi.pl: ignore some temp files
In-Reply-To: <20231228233113.5218-1-rdunlap@infradead.org>
References: <20231228233113.5218-1-rdunlap@infradead.org>
Date: Wed, 03 Jan 2024 14:03:31 -0700
Message-ID: <87plyi86zg.fsf@meer.lwn.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Randy Dunlap <rdunlap@infradead.org> writes:

> When there are filenames of the form ".orig" or ".rej" in
> the Documenatation/ABI/ subdirectories, there can be confusing or
> erroneous output generated. Example: the file
> Documenation/ABI/testing/sysfs-bus-papr-pmem.orig causes this
> warning message:
>
> Documentation/ABI/testing/sysfs-bus-papr-pmem:2: WARNING: unknown document: '/powerpc/papr_hcalls'
>
> Prevent this by skipping over filenames that may be created by
> patch/diff tools etc.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>  scripts/get_abi.pl |    1 +
>  1 file changed, 1 insertion(+)
>
> diff -- a/scripts/get_abi.pl b/scripts/get_abi.pl
> --- a/scripts/get_abi.pl
> +++ b/scripts/get_abi.pl
> @@ -93,6 +93,7 @@ sub parse_abi {
>  	return if ($mode & S_IFDIR);
>  	return if ($file =~ m,/README,);
>  	return if ($file =~ m,/\.,);
> +	return if ($file =~ m,\.(rej|org|orig|bak)$,);

Applied, thanks.

It would have been nice to create all of those files with a .abi
extension so we didn't have to do this kind of blocklisting, but so be
it.

Should we exclude emacs-style ~ files too?

jon