Received-SPF: pass (google.com: domain of linux-kernel+bounces-16047-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <bbe9f340-aea2-4847-b11e-31042a1440b9@infradead.org>
Date: Wed, 3 Jan 2024 14:06:30 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scripts/get_abi.pl: ignore some temp files
Content-Language: en-US
To: Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-doc@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>
References: <20231228233113.5218-1-rdunlap@infradead.org>
 <87plyi86zg.fsf@meer.lwn.net>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <87plyi86zg.fsf@meer.lwn.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/3/24 13:03, Jonathan Corbet wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
>> When there are filenames of the form ".orig" or ".rej" in
>> the Documenatation/ABI/ subdirectories, there can be confusing or
>> erroneous output generated. Example: the file
>> Documenation/ABI/testing/sysfs-bus-papr-pmem.orig causes this
>> warning message:
>>
>> Documentation/ABI/testing/sysfs-bus-papr-pmem:2: WARNING: unknown document: '/powerpc/papr_hcalls'
>>
>> Prevent this by skipping over filenames that may be created by
>> patch/diff tools etc.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: linux-doc@vger.kernel.org
>> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
>> ---
>>  scripts/get_abi.pl |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff -- a/scripts/get_abi.pl b/scripts/get_abi.pl
>> --- a/scripts/get_abi.pl
>> +++ b/scripts/get_abi.pl
>> @@ -93,6 +93,7 @@ sub parse_abi {
>>  	return if ($mode & S_IFDIR);
>>  	return if ($file =~ m,/README,);
>>  	return if ($file =~ m,/\.,);
>> +	return if ($file =~ m,\.(rej|org|orig|bak)$,);
> 
> Applied, thanks.
> 
> It would have been nice to create all of those files with a .abi
> extension so we didn't have to do this kind of blocklisting, but so be
> it.
> 
> Should we exclude emacs-style ~ files too?

Hm, probably. Someday.

-- 
#Randy