Received-SPF: pass (google.com: domain of linux-kernel+bounces-16075-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 3 Jan 2024 14:32:22 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>, Ira Weiny
	<ira.weiny@intel.com>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
CC: Ard Biesheuvel <ardb@kernel.org>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>, Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH 3/4] acpi/ghes, efi/cper: Recognize and process CXL
 Protocol Errors.
Message-ID: <6595e076cac24_3ec8294fb@iweiny-mobl.notmuch>
References: <20240102150933.161009-1-Smita.KoralahalliChannabasappa@amd.com>
 <20240102150933.161009-4-Smita.KoralahalliChannabasappa@amd.com>
 <65944ec1dccee_151dc1294f3@iweiny-mobl.notmuch>
 <66b7feb6-b151-ad97-0ee4-3fd7da7137eb@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <66b7feb6-b151-ad97-0ee4-3fd7da7137eb@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MJid5/D9alX2v+sp1WwXpdO2p57DIZwXirWMVmJmpWfvIUGi0nLSla5QGYmt?=
 =?us-ascii?Q?/5a5OmjQuJVgmPbDihDPFlJbeiOA08WD/3BkNxO9s3LlychJMIAnwNLMNfRy?=
 =?us-ascii?Q?iMFnEwesF7/fukC7Et+gg4FI48eGXRsUU+X/ACOZJBj/7QZKeGGPLcvTQqin?=
 =?us-ascii?Q?5GS7N2QAZIlhJVAUqzPqTDKnsOauWrwWzMVBlRbU6zutkCDMMutcQDCl4rC2?=
 =?us-ascii?Q?ZYlAEeCaOxhWP77RT3d1vkK4G3gxYZxcsDfitldbhH1N3baAKHh4OngxKPYx?=
 =?us-ascii?Q?g7h9Z3VW52V7AQvug3mu4ikdhpG8qgDXm8By0IX7AelrFYVOU+XEsrKo58uy?=
 =?us-ascii?Q?Q6NgYKHcKyzBDDOd4jGjo9NlLlLb8aeE2PKpkRaptRuwB/l9mA2Mu9sPX4Ei?=
 =?us-ascii?Q?VvKZeksHCZZcbOdzBXaH+pyZxskaq8Hx+BnfSwzeb6uNzSnfYEfGY6YASA8n?=
 =?us-ascii?Q?oOSZ8xm3D/5cbep5r7TX4/3W7IeaQjHxBQ2KMmsJ1Hg+I7JdVNYvJaxfVX+j?=
 =?us-ascii?Q?QlARfDsFEY67ucuB2JMSn2M8pD/4fvLiUdBRtNaYdc1mtOaKVWsWdur+aLQS?=
 =?us-ascii?Q?2AQcZJLCooy+b2kR+hHiejl82Z2hAw8m4gkphfQNvBsNvOWUi0LsOMv83gSR?=
 =?us-ascii?Q?17If0KycR+MFjONRv4htX8lB/szo7A86VUrKh2K7w3ZcOiBrgmE3YV5GCqIL?=
 =?us-ascii?Q?BOUfKFr3Gin2v7ASZ4ZdGFexFlo5LVZmAZ3Xels2sNjk18/vZuXQM3WQSa/3?=
 =?us-ascii?Q?O6bzGEC0KNqDQr9JluVAiXFtNLarb4XT1IQsUpzz1Agk+VJy2eyiEgXOlsne?=
 =?us-ascii?Q?hor/tIA6SkM0VBH/VrsYcjydIRDuUUnBce+2Dt8tTze1pYI2yP9N6I/+QS6m?=
 =?us-ascii?Q?R9Il39cU23noqX3qDo7qfQUqicW+r3pm16si070XGADvUjCIfHni+xAmuHJK?=
 =?us-ascii?Q?TIMr5ntFHYxCpxsSzhbYWx4CwkfWhXHPladqILhYqLWy9UOBSVKu+jpDuJj2?=
 =?us-ascii?Q?5fmcpIyfML5REOgEuKrTleMQQiTfNXhtt2z9ybbNc7V4zfkETaQXVXRg3cKb?=
 =?us-ascii?Q?Dlmss+Br7inmM8mKcaJmdF4Uasfer3iv61sfAm6rTc0srg9P3uaEyATErhyN?=
 =?us-ascii?Q?jg+d25SO7idtUDpg5PRk/li7SJ75Xdxi2uEBS98t2VLR5hKNfxVPqqj2sJlH?=
 =?us-ascii?Q?qRL5odAt/FW0kqYC1GEBqPOPu4yHItFPbt0HTyM7dCyyH/WH362tbB370PCS?=
 =?us-ascii?Q?mUUrveLLehSto5u2pzzD3zw2bJxzVY+ff5B8SUXoCa0cfS2NlUkMEFVp/1hB?=
 =?us-ascii?Q?xB9NoEm7TRWv7AgHpDH9nMlJQkioFlL8nWM8iGhS6f6umr0Dl0bqNcfQBV7b?=
 =?us-ascii?Q?GDY5KcK/AnPckLAl3601ZglHRZWTKVrVu8Twz7WOSFZrQm6tp5z2P2Hksb37?=
 =?us-ascii?Q?MTk4f8a2MeM91dwLd4qMOwvd+EYsuKUUe+EuTHME1HkuB8uuGF3R907AlHux?=
 =?us-ascii?Q?5RqFZKxGNsrMYMxWFTdwQ8XfK2u7Pq++Zqs9/BdeJitrhZSuKXKvKg/GkMqn?=
 =?us-ascii?Q?PKUfnsMu+/vQSsFtvGdJdrv62pJFseGYfoiRnDsM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 79d34f6a-284b-47e6-2074-08dc0cabdc85
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 22:32:25.9756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1w9lFAiDnlevZjy9kzqvCLIe+wGAADhapYw3vx0+i5xmnX6V9jEK60lTdFs4cgvB+XIfJuJ0sDrVXXSAkdOu3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6560
X-OriginatorOrg: intel.com

Smita Koralahalli wrote:
> On 1/2/2024 9:58 AM, Ira Weiny wrote:
> > Smita Koralahalli wrote:

[snip]

> >> +
> >> +	return 0;
> >> +}
> >> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> >> index 90d8390a73cb..7ba2dfd6619e 100644
> >> --- a/include/linux/cxl-event.h
> >> +++ b/include/linux/cxl-event.h
> >> @@ -154,11 +154,17 @@ struct cxl_ras_capability_regs {
> >>   
> >>   struct cxl_cper_rec_data {
> >>   	struct cxl_cper_event_rec rec;
> >> +	struct cxl_ras_capability_regs *cxl_ras;
> >> +	int severity;
> > 
> > NIT: When I saw this without any addition to event type I wondered if the
> > series would bisect.  I see it does because the record is not sent until
> > the next patch.  But I wonder if the 2 patches would be best reversed.
> 
> You mean to say patch 4 to be 3 and 3 to be 4?
> 
> And since I haven't used severity yet,  fix it by declaring severity to 
> where it is used..

Yes.  What you have is not technically wrong but it threw me in review.

> 
> > 
> > Also, should cxl_ras + severity be put in a protocol error sub-struct?
> > Does severity ever apply to event records?
> 
> No, not in any of the component event records. Only place is in "Event 
> Record Flags" in Common Event Record Format (Table 8-42).
> 
> Addressed in patch 1 to make a sub-struct.

Thanks!
Ira