Received-SPF: pass (google.com: domain of linux-kernel+bounces-16076-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 3 Jan 2024 14:38:57 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>, Ira Weiny <ira.weiny@intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Smita Koralahalli
	<Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose <shiju.jose@huawei.com>
CC: Yazen Ghannam <yazen.ghannam@amd.com>, Davidlohr Bueso
	<dave@stgolabs.net>, Dave Jiang <dave.jiang@intel.com>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ard
 Biesheuvel" <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>, Ira Weiny
	<ira.weiny@intel.com>, <linux-pci@vger.kernel.org>
Subject: RE: [PATCH v5 8/9] PCI: Define scoped based management functions
Message-ID: <6595e201beb4_be7022944d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231220-cxl-cper-v5-0-1bb8a4ca2c7a@intel.com>
 <20231220-cxl-cper-v5-8-1bb8a4ca2c7a@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231220-cxl-cper-v5-8-1bb8a4ca2c7a@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hyZ8VIUcW8i9sD/I7c+Sn2ivdVJYLg0LxINXKIcbe3csB9CJQR40FFWnJlMP?=
 =?us-ascii?Q?6+ZEFXHIbPjpv+4Atmbbu6zeWNPP9Tlq1iBb0ZilR5iuas5Ues7UrSvNXWKJ?=
 =?us-ascii?Q?S4qsyTRLbDlj+rzZUKFHmwdy85Yd81R+gca1Cx+y96jcUkD5vdRj1BZFeG5J?=
 =?us-ascii?Q?MKd+aqt+TxCQd9ZVlQxs3WEnDHnRUbYkkYLblciE9xfM9jRLkVpxGiIDsMSU?=
 =?us-ascii?Q?cpjqDyegyPX8psuD6rcTOidSEAWEvILxII3HhxnqbT5kPw2/+nNwFXgnfzo8?=
 =?us-ascii?Q?LQ3n3vfr+eEcqHrz0BH5ySrDITMeZWchbp5Cyn41kWKd+2fGcmuwp1P97haM?=
 =?us-ascii?Q?m5BXGyCcrIRqRWg/LegIcpRcmL0usRkT5poyecxIrC0fccIfZF3MPIiCZIfB?=
 =?us-ascii?Q?8jhJk4oqjtzQZsezWzw7fjjmvV4bxLI8d3y8TtIDya/uu04Gt4oTDpuUooFX?=
 =?us-ascii?Q?xvsXA8Jpgc6usW7IKNCBJPkLoWTaBZJYqLBlLr0l+xp/MWPd9pL/yRDQZLVa?=
 =?us-ascii?Q?jW7auguqVunOVS0D4IZCtfBg8txO2aNRZx5C/UJ6yv1EkoW5QGroceZyN/iw?=
 =?us-ascii?Q?JtgocJiaYgeAZgJujgrPCd4JB6d9cvVCCaKQObpDAokEXbU3doGnb3r2aNmC?=
 =?us-ascii?Q?0kljXuKQ5PlKu2jxpK8v+lpx5IDx858aZ7yQDadcDdeh7SZOpf8BcuZ/L2xq?=
 =?us-ascii?Q?GLrz+hLpJN1MuFXQ/KvmvAAPFTxBKUvg6zKAchUvYsr0WUiCm4teM6MUYV/q?=
 =?us-ascii?Q?inD9ky40h8K6R4I1kl1hdprDbiGRr/NJRzxqaVEHFsbc/AJEeJuFfCCQbBKG?=
 =?us-ascii?Q?5VI2AKynM2cg4z3Hqk/nptGoZfITd5N/dFTrUCkU6UAaY01xq1jSc+vxJfId?=
 =?us-ascii?Q?RNaAtdrciI05m8EtyxeMUWbUpbFVk/+RpIiMh5+GSJA5C57zw9k3vuJXM7Dh?=
 =?us-ascii?Q?LMnhYfRM0uPbcOzrtE+wd3Lxv0rvZuf9gxvS7gFWpwjss0a9tLtW8zTxO5xb?=
 =?us-ascii?Q?RAmbADoFS3uQuHA/HT1IyrfPSKAj5/7uKjHePBxuL9ETIYH+OFxSXr7YUS11?=
 =?us-ascii?Q?RuNpZaviSNTcpiHnKe81E5pLU8Q1N39ByZShE4/QkMnG1trUEgf58byBuhas?=
 =?us-ascii?Q?7ookleAexnVFibDVwBymrOOwE57QM5Pj05yT6Z+hUDFnT9zhGMOJflH8yr+A?=
 =?us-ascii?Q?brj/LatSd1A6fbZTOTcD/C9n6Q4amCcujyny/tLUYgQ/NIK4nBiB5hrttMr6?=
 =?us-ascii?Q?fOO5rEUGwcPzlF3IlN28AmZGF1zO+tJBIKvypQv7nzp14l0w4b7TTNR5qEOO?=
 =?us-ascii?Q?SNbr/EeaFShIq0+CTt++o62DpSXC4OAV/tzpvzwVO1rdkjvNdCcm+WvW1/tE?=
 =?us-ascii?Q?gdTp0Chmlu0+BaOC1iPSZQ7qauBCrV88ZiWMcghzNGqc/lR3LHA6OArDWxLn?=
 =?us-ascii?Q?OEQdWLdjfNDJchWEOxV3mUeZFwDv0tvxtlDYGbZUQGthnJyamsFKJP1m5dwW?=
 =?us-ascii?Q?46fReX6Df7eOlz+3fEz61zMw8XKP0x2GCZs1VOoixq3pRCNtOhlPtiR+U7OM?=
 =?us-ascii?Q?BDpCn4TSD9zzlaTFxroNHNggCY+tjyZUlr7wo5xI9vo+aKQeQC4VO7Kn3X0x?=
 =?us-ascii?Q?JA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d8c7c666-848d-48fe-1636-08dc0cacc782
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 22:39:00.2472
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PybQ1f/VuFaHJlpYJjvUfEbnXoau0B3KFIqB/fn21tjJmhOPs0Hw20iNFxWPSsx9zwmfex4+CxPqI4J+Ld0JJ1eVrhOL6t/yrlA4z/0QHjc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8600
X-OriginatorOrg: intel.com

[ add linux-pci ]

Ira Weiny wrote:
> Users of pci_dev_get() can benefit from a scoped based put.  Also,
> locking a PCI device is often done within a single scope.
> 
> Define a pci_dev_put() free function and a PCI device lock guard.  These
> will initially be used in new CXL event processing code but is defined
> in a separate patch for others to pickup and use/backport easier.

Hi Bjorn,

Any heartburn if I take this through cxl.git with the rest in this
series? Patch 9 has a dependency on this one.

> 
> Cc: Bjorn Helgaas      <bhelgaas@google.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes for v5:
> [Jonathan: New patch]
> ---
>  include/linux/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 60ca768bc867..290d0a2651b2 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1170,6 +1170,7 @@ int pci_get_interrupt_pin(struct pci_dev *dev, struct pci_dev **bridge);
>  u8 pci_common_swizzle(struct pci_dev *dev, u8 *pinp);
>  struct pci_dev *pci_dev_get(struct pci_dev *dev);
>  void pci_dev_put(struct pci_dev *dev);
> +DEFINE_FREE(pci_dev_put, struct pci_dev *, if (_T) pci_dev_put(_T))
>  void pci_remove_bus(struct pci_bus *b);
>  void pci_stop_and_remove_bus_device(struct pci_dev *dev);
>  void pci_stop_and_remove_bus_device_locked(struct pci_dev *dev);
> @@ -1871,6 +1872,7 @@ void pci_cfg_access_unlock(struct pci_dev *dev);
>  void pci_dev_lock(struct pci_dev *dev);
>  int pci_dev_trylock(struct pci_dev *dev);
>  void pci_dev_unlock(struct pci_dev *dev);
> +DEFINE_GUARD(pci_dev, struct pci_dev *, pci_dev_lock(_T), pci_dev_unlock(_T))
>  
>  /*
>   * PCI domain support.  Sometimes called PCI segment (eg by ACPI),
> 
> -- 
> 2.43.0
>