Received-SPF: pass (google.com: domain of linux-kernel+bounces-16176-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20231227053509.894642-1-allencl_lin@hotmail.com>
 <SEZPR06MB56080820EE51CBAE9C6B6B3E9E9FA@SEZPR06MB5608.apcprd06.prod.outlook.com>
 <08623087-bf1c-411e-87de-d40ffab6e2bc@linaro.org> <TY0PR06MB561188EBD127F8ECF4A7052B9E9DA@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <0a817121-620c-4630-93a3-5cf3173b924f@linaro.org>
In-Reply-To: <0a817121-620c-4630-93a3-5cf3173b924f@linaro.org>
From: Allen Lin <allencl_lin@hotmail.com>
Date: Thu, 4 Jan 2024 09:14:47 +0800
Message-ID:
 <TY0PR06MB56119087B8D10E57F769BB379E67A@TY0PR06MB5611.apcprd06.prod.outlook.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: input: Add Himax HX83102J touchscreen
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Allen Lin <allencl_lin@hotmail.com>, dmitry.torokhov@gmail.com, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jikos@kernel.org, 
	benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TY0PR06MB5611:EE_|SEZPR06MB7412:EE_
X-MS-Office365-Filtering-Correlation-Id: a78c3206-8f03-41c5-c212-08dc0cc358a1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	woTuQfGriMjg0fnuAGW1uT3/EwaxETC4Cd9fsGav6cHTE2+NjAXv6phRiNgaLlj0K6Ge+Zgcc6JA33PF3X5LOeYgBTP8DrA05lS1zQOW5bltzrdUEpPYzjchVKlcvG3XJxR0EEFbULKu6Zx185wzgwfDu+nPZkfj/NjDhdDRy1DqdRpre3+CBasYCMUDW9z0vcbRvutBxdOon3ESXMTzIBAeY04xNrfIJgFxRrI5Vw9YnwPkmNkDFbaG8ajTUkGht8tjuUUnzFGlfx4KlHh8xtPK5EHKJ924ay02GikcaIodya9/Aljj8hB+bInf2M1cHejFdP/hCOmyHaHIPLCTTydLyPmj/4NsTVKMnvsJdJBuNJq07kuLMz8qHiVc/4MG7aiW/0br0psPB9q0jv9uBdmIZd4zWH2gECxRlctSozlt2kklffD3HAEN4ZM17xEyBojbaTPMLkmVqKWUord8wEbXpKNG4nXAgYjDxtd5iCltEa3YeTU4nn0mzlXK+XLU2rfp6dOOIh81+XGc1YoAect9CelGc+Vi5l3NmVDFjEnhXqw5SxLCrdN/EvFck2MwlgAzAf4+0sIf+tUOPzDLE5ALgsAAENNWn5KIK1QnCNE=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Mi9oUG5RUXZScDhHelBQZXBJK2NHNEpWSjhJNnpPbmpjL2FaSFFwS0plZzlj?=
 =?utf-8?B?WVFzeFU5a0xoVlBYYldTQndoWTRPaDQ0cjlILzJZKzM1NEJQYUNxdlJodlVR?=
 =?utf-8?B?dDc3TUhyMWtZbXdjOW9McUY4Nk1HeVFXcjVWdWRMZmpTL2tGaHFkWlRYOCta?=
 =?utf-8?B?ZXFacFZ6L1RpQWc0MFc2aVRrUkl0amlmNEhpeVN3eVp0UVpnVkdXd3FtaGZt?=
 =?utf-8?B?Smh1Z0N2dzVPMFE4OTY5bW9SQVE3OXZ1aGVZMGN2dkF3VEU1a2REYnlpblhr?=
 =?utf-8?B?bjlxSVp4WEdsS1QyRm9XazFsNnNVWWNvK1lGSGVyTkI4YkoyMjRvd2RQb2Z3?=
 =?utf-8?B?bGh0eXlwRjNpR0FvazczamFpenQweG5DeUVYOFBmUEJkM0dLT0Z2MnFtbUc2?=
 =?utf-8?B?MlA2VzRjNlpVSXVObDRQc3FVZDIzWXpCb1p1U1JPSFVCckhndmZTZFpQMDJt?=
 =?utf-8?B?bnlpYmd1b0F6T0padlZZWVhJMmF6UDRRbGVrQzMwWVl0bGhuVTFIRjcwVlFu?=
 =?utf-8?B?UE9SOHVSa0NhSXhsUkNPSHFjeDNJYnpvdWw4KzdCSkoxbEFhZTczV2I3OW16?=
 =?utf-8?B?VjZEa3JhczlOeEtUaUJyd2hla3hoZHVMdUdQbHJYaFI0L01zOXFOeW12WmNG?=
 =?utf-8?B?aVE0V21ESGZicENLM2NvVldRdkpIaUFMSDdvYm4rK0E3RmpQNUpPOU55d1p5?=
 =?utf-8?B?Vm9LSStPbkd1M01ZRG9SRXdsZzFETHF3dFk3TFVCUndYT3ZrTjN1SldsNy9H?=
 =?utf-8?B?c1dYdHdScU45Zk9xQnBkdXBPcUlMNlI4OGNCVkc4Z3l0b0poRElzODA0WmdI?=
 =?utf-8?B?dGNDYWFkTStZQ0RNdXFKZUhHUGxLV0hUWE5yaGdGNmFTeDI4T2lrTzA5WVpO?=
 =?utf-8?B?L1VNNFZTeCs0RlBlRlhveUZvMFpudittbVk3aVdCb1o4SktCUWJHUkJac1Mz?=
 =?utf-8?B?TXIyRXd6MkdVNUdxVXVFMk9uVW1jQ0ZoaDVjL0ZFNHFzNmtEeGp3NkIwMnow?=
 =?utf-8?B?WUtIb3RSc012QitydTM1alNkdUQ2OE05cXQ3MmpiMFRjLzJwQ2lSUzlhaURh?=
 =?utf-8?B?bjlGS21hY2Z6bXlFMDZUNG5uMlcxcWxHczJ2Q3RCSXFhWVQ4b1dYMXV2dU1u?=
 =?utf-8?B?ejR2cGJLT0FZdnhmOXdBSS9BT01CTS9xdTRNZ2RlTGVPejhNV1hoblo2Q2ln?=
 =?utf-8?B?TjZISmxFV2VnZ1Z4c0JxVnF0L0tic0NQcGhUalowR05FNVpHMi82T2NUQ0xz?=
 =?utf-8?B?V0xZNUZjQm5ReE9jWG5sMGZMWm9VZUp4RTgwZlNVMUVKR09xY3J3UHFmSXpu?=
 =?utf-8?B?UkVObGZ5SW5LTm4vZW96eWVwS1BJbmhEUFE0a2ZpdjBQWmZpUjN5QjZ0Ti9n?=
 =?utf-8?B?YzhHam1BREpWSlVNNm4xeTFDQ2JObFpuaGRNc0xNZFc4aWpOUlRHQVR5VG9H?=
 =?utf-8?B?eE4xYTNWNXJFcklCbnpwVlltdXNDVDNRaGJnREJyMjJ5WjZST2ljam5oWnB0?=
 =?utf-8?B?dzNCdjhrcjEvV2dyNUh6VXozQ0ZxaEdRc1IraUFmNWNmdlJveU5IT2hnY0lN?=
 =?utf-8?B?VWFOWGJRY2ZkWFhTOGhnVWsyMmRqZkJKSVdFelUwaXF4dnh6YURTdXhqL2Fk?=
 =?utf-8?Q?7gU3mEisAe9jibpRT1uXLVbeVhzblfdpZ/RG6qbarvNs=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-3208f.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: a78c3206-8f03-41c5-c212-08dc0cc358a1
X-MS-Exchange-CrossTenant-AuthSource: TY0PR06MB5611.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 01:20:32.9022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB7412

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> =E6=96=BC 2023=E5=B9=
=B412=E6=9C=8830=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8B=E5=8D=8810:19=E5=AF=
=AB=E9=81=93=EF=BC=9A
>
> On 29/12/2023 10:08, Allen Lin wrote:
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> =E6=96=BC 2023=E5=
=B9=B412=E6=9C=8828=E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:36=E5=
=AF=AB=E9=81=93=EF=BC=9A
> >>
> >> On 27/12/2023 06:35, Allen_Lin wrote:
> >>> Add the HX83102j touchscreen device tree bindings documents.
> >>>
> >>> Signed-off-by: Allen_Lin <allencl_lin@hotmail.com>
> >>> ---
> >>
> >> Where is the changelog? There is no cover letter attached, so changelo=
g
> >> is supposed to be here. There were several comments, so does it mean y=
ou
> >> ignored them?
> >>
> > Cover letter is not in this mail but in the mail with this title
> > "[PATCH v3 0/2] Add HX83102j driver for HIMAX HID touchscreen"
>
> There was no cover letter attached to this thread. Don't send cover
> letters in separate threads.
>
> >
> > Hi,
> > This driver implements for Himax HID touchscreen HX83102j.
> >
> > Using SPI interface to receive/send HID packets.
> >
> > Patchs notes as below
> > 1. Add the Maintainer and devicetree bindings document for driver
> > 2. Add the driver code and modify Kconfig/Makefile to support the drive=
r
> >
> > change in v2 :
> > - Fix kernel test robot build warnings.
> > change in v3 :
> > - Modify code according to review suggesions.
>
> Not detailed enough. What did you change exactly?
>
1. Remove function pointer coding style
2. Remove unused code/variable/structure
3. Use devm_kzalloc() to allocate memory
4. Use gpio descriptors to control gpio
5. All functions are changed to static
6. Drop all global variables.
>
> Best regards,
> Krzysztof
>
Best regards
Allen