Received-SPF: pass (google.com: domain of linux-kernel+bounces-16196-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 3 Jan 2024 21:03:51 -0500
From: Gregory Price <gregory.price@memverge.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	linux-arch@vger.kernel.org, akpm@linux-foundation.org,
	arnd@arndb.de, tglx@linutronix.de, luto@kernel.org,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	hpa@zytor.com, mhocko@kernel.org, tj@kernel.org,
	ying.huang@intel.com, corbet@lwn.net, rakie.kim@sk.com,
	hyeongtak.ji@sk.com, honggyu.kim@sk.com, vtavarespetr@micron.com,
	peterz@infradead.org, jgroves@micron.com, ravis.opensrc@micron.com,
	sthanneeru@micron.com, emirakhur@micron.com, Hasan.Maruf@amd.com,
	seungjun.ha@samsung.com, Frank van der Linden <fvdl@google.com>
Subject: Re: [PATCH v6 08/12] mm/mempolicy: add userland mempolicy arg
 structure
Message-ID: <ZZYSB3kUOjCSo28h@memverge.com>
References: <20240103224209.2541-1-gregory.price@memverge.com>
 <20240103224209.2541-9-gregory.price@memverge.com>
 <429dd825-204a-4b11-87fd-ce9d39040d4d@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <429dd825-204a-4b11-87fd-ce9d39040d4d@infradead.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7L7cbGlDXeuK3lavyb5T435IiHrGxoFV62JLGakoLQfZne7x/jXyxD5HNc22?=
 =?us-ascii?Q?sL5tC4/3m2gISMxI//iNiaLVfNuUnonyY4BTVCPt39saes4aQ+GzMWns7JlS?=
 =?us-ascii?Q?3nXeN9F27cMcGaZirvEeicuuFx4R7NV5eZcd03IdPsOcDB9P3d5ajTdQTcYX?=
 =?us-ascii?Q?j2OEbIL7zQSL90n8UMsd7rrUEFIJKqKN4O1T1zZRRF1WTaPKiSEXcuBGDU7N?=
 =?us-ascii?Q?nKjWzjZcES/lLSPyfIAlzgXVlbLErcr2d0+LsZcYS0CEkDjGt65li2INdz/g?=
 =?us-ascii?Q?hgt2HapdCqv5k2+D6qdnpbXPnGakMgfWl6A4mIe9ryRbQlB+vc41douCMg2F?=
 =?us-ascii?Q?sSjsZ69i8A5FZEAad3EWwV3f1TSkmEWhl8hnz5JugoiwQjFUPCTy4l/WU2xf?=
 =?us-ascii?Q?V0c5+/Hb/KyWRbdK0SQ/tlSKNrKMshQogpbhk1JCp8Gjpq8jrsht50uQbKdx?=
 =?us-ascii?Q?483yC+CNRW2RYQfyzJKJd8oEl1to/9bpXAFIRklsFbO5dshoti3AkUX0zp97?=
 =?us-ascii?Q?pXo0dh1RqYIzaXYVEoUNPCEH1HDPwr65rTgBku9OX8KEfQ1AKHjGKcap+Dy5?=
 =?us-ascii?Q?v7CFXAWXt05FPIJ5/4W7i6vd7aV+d42457QOcN7eeiG8S5jCdUKRK5+307Ba?=
 =?us-ascii?Q?voPRzJQedyAcLEFPleyzQEXpSbZZQA4HjYD0gEOQNlYtBU6mTzkhqpiUmZr3?=
 =?us-ascii?Q?gFr+6gLIQVDuRIb9oPAfeQ+hK8zV0oJFo+4gEVoD4PmCFOsPuVara/YnZfSZ?=
 =?us-ascii?Q?vfnCxyj1TDb9J55uwCLnOHDZXP6S8JE3KvXmgtDDala67AAGB8hnr8qcP2If?=
 =?us-ascii?Q?0qETdC7iW7kg3Tu3XlOg8UFspeGseO6iy3MqeCSz4+/YMfN9r6Qcx5o4WWBc?=
 =?us-ascii?Q?mXpD2C9qdJXTEIf1xeusGXbS6jeXR/lPN9zsFiiiAu5GFx1iEFhADYmmCkoT?=
 =?us-ascii?Q?FFbXraOQKRCcNRRzezQ7vTSUuAN+GUaUoz16ZpHofMqx4SzU5/o3e8OHKWLT?=
 =?us-ascii?Q?as5ZfoPB/LepxMDIN5UjIMtDcPA2/3pUJTvluZKjGBzPfn5QoqGzERs+Vqou?=
 =?us-ascii?Q?JgwomeniKAXb/YwsPmpawJfa/b3LSTFfSwbcZUNIX1r6JNgxsz1nBW46mafc?=
 =?us-ascii?Q?k8cP4gm4/ZNZQHTdc6alJk7qNKgOeDSmwARhzD8wxbac3ciUMVY8ZaUr+L4M?=
 =?us-ascii?Q?irNIfsAIrGZCA0MMJtsO/3v39kxL1KIhMiWX6K6knCdBPLTR2DCwzHXgu2gZ?=
 =?us-ascii?Q?24OhfTvAL5h+kcZQ4nTAGBu61YAWKHbOQ/cdoWx+SxrBsCA4f32J54DrUokj?=
 =?us-ascii?Q?98vTG/rE0KnjUhXDfvBY+auc+qN08DBchQtQKHdcESJmqIXAYZ6bQOMclrfK?=
 =?us-ascii?Q?unpwmKAs/etws8xNa4JP4D3t8vxVOsbLGX2xuv3gdJHRGPi9KPrQKmUKNWFv?=
 =?us-ascii?Q?/qSSATTPgOAbmF+fSJHgFLEqdaepn60WeiYe0e4EvDz1eeqeIz/Ck41amONN?=
 =?us-ascii?Q?wWfDGsD8f1DxG2ou7JGYrRcHg9qIUAD1qI/yOXLK6jcmsRY5YQVaBEnQbcZs?=
 =?us-ascii?Q?UVuwtsoCtlaWoqA1L+K5HPp5Bc9BI2NF1OV1rrbrYdkAS598O+YDVEhBe3MI?=
 =?us-ascii?Q?8g=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2f13017-2811-4c3f-020e-08dc0cc9689c
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 02:03:56.4622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZT9CJwTORPuEdRDd0y/B75TmYwy/kEHpAlH1FpwoOVjspEJDMMm6Juf8Lr5hW/Rq9fXQgcCLXqMEGm01ZFDIdoI64zGENJwViLp5SfrdgnI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR17MB5567

On Wed, Jan 03, 2024 at 04:19:03PM -0800, Randy Dunlap wrote:
> Hi,
> 
> On 1/3/24 14:42, Gregory Price wrote:
> > This patch adds the new user-api argument structure intended for
> > set_mempolicy2 and mbind2.
> > 
> > struct mpol_param {
> >   __u16 mode;
> >   __u16 mode_flags;
> >   __s32 home_node;          /* mbind2: policy home node */
> >   __u16 pol_maxnodes;
> >   __u8 resv[6];
> >   __aligned_u64 *pol_nodes;
> > };
> > 
> >  
> > +Extended Mempolicy Arguments::
> > +
> > +	struct mpol_param {
> > +		__u16 mode;
> > +		__u16 mode_flags;
> > +		__s32 home_node;	 /* mbind2: set home node */
> > +		__u64 pol_maxnodes;
> > +		__aligned_u64 pol_nodes; /* nodemask pointer */
> > +	};
> >
> 
> Can you make the above documentation struct agree with the
> struct in the header below, please?
> (just a difference in the size of pol_maxnodes and the
> 'resv' bytes)
> 
> 

*facepalm* made a note to double check this, and then still didn't.

Thank you for reviewing.  Will fix in the next pass of feedback.

~Gregory