Received-SPF: pass (google.com: domain of linux-kernel+bounces-16200-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e90ac2af-dcc7-46b9-97e5-a5b5c58e5e42@intel.com>
Date: Thu, 4 Jan 2024 10:16:49 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 06/26] x86/fpu/xstate: Create guest fpstate with guest
 specific config
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "john.allen@amd.com"
	<john.allen@amd.com>, "peterz@infradead.org" <peterz@infradead.org>, "Gao,
 Chao" <chao.gao@intel.com>, "mlevitsk@redhat.com" <mlevitsk@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
References: <20231221140239.4349-1-weijiang.yang@intel.com>
 <20231221140239.4349-7-weijiang.yang@intel.com>
 <bc19422761014edceffac971ec66d7a9a77f5ad1.camel@intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <bc19422761014edceffac971ec66d7a9a77f5ad1.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0Z3ZThlYk5ya0VLUU4yM1ZJekJtU1MwSDdtS1NNMDJQZXFUVk1qamlzVW14?=
 =?utf-8?B?cWFQZlVvNGMvODE0UGJvcmFmamlJdGlVdjRnSjF6UzFodjk4cjJIZVJkbnB2?=
 =?utf-8?B?RlJLRFRsQ1FRTHNMUW5SMTI5M3BUajFrdEtWczNodm92VmNDL3FUL2pLelMx?=
 =?utf-8?B?MjBMUGNGV0dYTVBYTmI4U1VsZDYzdDBNRi9GaVhZajJPVDF4dkZwVVBsUXBM?=
 =?utf-8?B?UXR2NDliM2hCSnZZOHE3V1ZXUE5FU215ak9LZkRiSG42UjJVRHI1dTRVY2Fs?=
 =?utf-8?B?SnEwamY3TFE2ZGlkSnM1MkppYVlyRkxPWkdxWEJPdHg1NCtrbm1ZZFdDem5z?=
 =?utf-8?B?RG9vYzR6Vm1LN2RNcFJBRzQ4bTk1b3BBYzRYTzNpQmJOTmhKSmJzNER4U2pi?=
 =?utf-8?B?YnVwR1ZXNWdWVHVhTmlEc29ha2dYZTl3WVZld2djMVZIb1gyV0JqR0J3TDdE?=
 =?utf-8?B?OUhSUi94MWxTL1JoOS9mdnBTY0RXWkFxRDhocm56d1JtOXgrY082aEw1dWNL?=
 =?utf-8?B?dUdMUkE1c3ZWSzV5Z1MrVTFFYWE1WW5HcXNVWGkxZ0R6bjFOckNmY3FwcmV4?=
 =?utf-8?B?L2oyVi9KSnQ5VmVuTngrKy91bklhNjAybm1VUW02YXVmMVZIOUkxVEtnV1I2?=
 =?utf-8?B?V05tcHA3VDNmUEEvb0xHS1pvWk1NYnJFeDJnMyszZk1zaDcwK2t4eTZoNjhR?=
 =?utf-8?B?TVV1ejVNQXR5TnkxWVVSYlFGVTQyOW5YblliWDd2b3E4VC9Ceks1YW5KVnZI?=
 =?utf-8?B?L3haMkM5WjU4MlZYcUxxSUI1bW5rOG9SWGw2d2dwWnIvVkEydFlsaDU1d0Jk?=
 =?utf-8?B?RVJKRlBRMlNjSGMrK3pTcDhibWNGdStXSWwxNm4vRnZIaG9MalM2L3JTSlJM?=
 =?utf-8?B?SmZ6UE5ubnh6UE5DNlFhNTVYSHZJMWpHS3pDTkx3RVd2cGlDR0x0RWU0ekpF?=
 =?utf-8?B?WkVxMXNiVTNXK0dzNWRvbE1oWDZGb2ZRZHdwUEVLNU45UHdqWXJldmdldjQy?=
 =?utf-8?B?cjlzMkNRZjkrRFNTMXhkckhONWJiMXdRbWNLY3c4RTVPbitKczNQbldJVHQz?=
 =?utf-8?B?U05JMEtSUG1QOHh3MG40L0ZkdTBhYVVlT1FCaUxkMWxGcVFHenFVV0pOY2Nq?=
 =?utf-8?B?N292UnBVclQvUDQxQWppMnI1VHg0SnZiMG9SVkh2N1pOUUJaVFFabG54b3Rx?=
 =?utf-8?B?c21IMUxRaHR4ZWI3SjY0MXFUZmVWbFREZVZHZFZTd3ZJRHNOTHg0dGdxdkVp?=
 =?utf-8?B?eTI1VGh2MlIyMmRjSU1uMnluWEZxMFNaMDd5MTJhdHdwQ1UzOUJrcUdicnFE?=
 =?utf-8?B?NHkrbDJ5eWpUQmJSNUZTWFMrOXFSYkdBM0xVK3JiY3BZYVhONVYwTVAzSmJG?=
 =?utf-8?B?NFJOMUViWjJTcCtaVXhUZU9aR3JQR2ZzdE9PL1BFekdENjB5Q0NTNmdKWW5Y?=
 =?utf-8?B?VEZNUUJRcmg0amVjWlhNUVQwVmFDaGZVNk9DeU9GOUxDVG0wMkV4Umk2OVJE?=
 =?utf-8?B?bEgrK3JqWVNJSE5jWUhBK3BnelQ5aUtqT0dZaU9adTY5OUgzU21VQnplVFl3?=
 =?utf-8?B?OXBPeGFlZDhOYUpvU1hBamkxSzJxNEFWeU5idTNvaUp6cklTZUhhZWpZWkEz?=
 =?utf-8?B?VlIwN2dLYUZDNUVUVi8vRGtONHNoMTR6VklWcEZDd3F0dVd4WmYxWm9vMmZs?=
 =?utf-8?B?V041eXNhc0Z2aXRTMjQ4cXVKanU5NXRyN0JEdmlLN04wUHBVVUdSRGZvV0xJ?=
 =?utf-8?B?LzNwaEJLWDJoWXN3elowdHJxOTRnSXIrcDNzUWpNczByb21ZZFNJdnBaVzZV?=
 =?utf-8?B?N0VibzFzNm9sUGNHSFVnUmpXaUdicGI5dkdsWmNJalIwNzllNWVxRlZRaUJ6?=
 =?utf-8?B?ekF4L2JkZlBLZXg4U1dIV1llWElzQzB4KzNzeVZ5bFFNcXA3Smk5TXZiQWhq?=
 =?utf-8?B?ZlAvZFZUM1pRYngwaTU5YmIycmN5ZHlRZHNKQkJGeHFEdmdaTGtrajRMbGxx?=
 =?utf-8?B?WHBpenBueWF0L201b0dNbVk2K0RyWnh2dkl2VzI0eUxCclU1VHZOUUFVdkVN?=
 =?utf-8?B?ZDJ2dDJDV2ZQL2daTTBBajRTaHBOeEpMamUyck5XRVU1NTdwZ2lzenFhaXlv?=
 =?utf-8?B?eS9vekl4RGJ3azBSUXpoMDRjZkd5OFBSNGkwTFJZdVlXb3A4ZVNVNUNmN1BR?=
 =?utf-8?B?c3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 94acdae1-a99c-43da-a313-08dc0ccb3dc5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 02:17:03.7634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mcv2sSq4ajoan40D8Z3q2HqL1WoZBvJoHq/bC0CvSZ1P6hfmDin12fbErwv8PIOWKsF0QuBIf23U8Nt5LPCb5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7434
X-OriginatorOrg: intel.com

On 1/4/2024 2:16 AM, Edgecombe, Rick P wrote:
> On Thu, 2023-12-21 at 09:02 -0500, Yang Weijiang wrote:
>>   #if IS_ENABLED(CONFIG_KVM)
>> -static void __fpstate_reset(struct fpstate *fpstate, u64 xfd);
>> -
>>   static void fpu_init_guest_permissions(struct fpu_guest *gfpu)
>>   {
>>          struct fpu_state_perm *fpuperm;
>> @@ -272,25 +270,54 @@ static void fpu_init_guest_permissions(struct
>> fpu_guest *gfpu)
>>          gfpu->perm = perm & ~FPU_GUEST_PERM_LOCKED;
>>   }
>>   
>> -bool fpu_alloc_guest_fpstate(struct fpu_guest *gfpu)
>> +static struct fpstate *__fpu_alloc_init_guest_fpstate(struct
>> fpu_guest *gfpu)
>>   {
>> +       bool compacted = cpu_feature_enabled(X86_FEATURE_XCOMPACTED);
> With CONFIG_WERROR I get:
> arch/x86/kernel/fpu/core.c: In function
> ‘__fpu_alloc_init_guest_fpstate’:
> arch/x86/kernel/fpu/core.c:275:14: error: unused variable ‘compacted’
> [-Werror=unused-variable]
> 275 |         bool compacted =
> cpu_feature_enabled(X86_FEATURE_XCOMPACTED);

Nice catch! Will remove this unused variable, thanks!

>