Received-SPF: pass (google.com: domain of linux-kernel+bounces-16204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20230921090027.11136-1-Wenhua.Lin@unisoc.com> <20230921090027.11136-4-Wenhua.Lin@unisoc.com>
 <ZQwomPRn0HaqHMgK@smile.fi.intel.com>
In-Reply-To: <ZQwomPRn0HaqHMgK@smile.fi.intel.com>
From: wenhua lin <wenhua.lin1994@gmail.com>
Date: Thu, 4 Jan 2024 10:31:35 +0800
Message-ID: <CAB9BWhf2BqkA8DG2m+K=_oBo_zymZwmejnxyaC6wLZHD4HZ3dA@mail.gmail.com>
Subject: Re: [PATCH V2 3/4] gpio: sprd: Modify the calculation method of eic number
To: Andy Shevchenko <andy@kernel.org>
Cc: Wenhua Lin <Wenhua.Lin@unisoc.com>, Linus Walleij <linus.walleij@linaro.org>, 
	Bartosz Golaszewski <brgl@bgdev.pl>, Orson Zhai <orsonzhai@gmail.com>, 
	Baolin Wang <baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, 
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Xiongpeng Wu <xiongpeng.wu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 21, 2023 at 7:27=E2=80=AFPM Andy Shevchenko <andy@kernel.org> w=
rote:
>
> On Thu, Sep 21, 2023 at 05:00:26PM +0800, Wenhua Lin wrote:
> > When the soc changes, the corresponding gpio-eic-sprd.c
> > code needs to be modified, and the corresponding
> > Document must also be modified, which is quite troublesome.
> > To avoid modifying the driver file, the number of EICs
> > is automatically calculated by matching dts nodes.
>
> > Fixes: 2788938b7946 ("gpio: eic-sprd: Make the irqchip immutable")
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
>
> Same comment as per patch 1. Also, fixes needs to be grouped at the begin=
ning
> of the series. (I don't remember seeing Fixes tag in the patch 2.)
>
> ...
>
> > +#define SPRD_EIC_VAR_DATA(soc_name)                          \
>
> Misindented \

Thank you very much for your review.
I will fix this issue in patch v3.

>
> > +static const struct sprd_eic_variant_data soc_name##_eic_dbnc_data =3D=
 {       \
> > +     .type =3D SPRD_EIC_DEBOUNCE,                                     =
 \
> > +};                                                                   \
>
> ...
>
> >       struct sprd_eic *sprd_eic;
> >       struct resource *res;
>
> >       int ret, i;
> > +     u16 num_banks =3D 0;
>
> Preserve reversed xmas tree order.

Thank you very much for your review.
I will fix this issue in patch v3.

>
> --
> With Best Regards,
> Andy Shevchenko
>
>