Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7481033rdb; Wed, 3 Jan 2024 18:56:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZ3Ihu/KYj4N2mPWOGOPUdDlItR+WoPzg7zvLXsx6dnF9qAwxBCSWCOEZmVwaM47Y5HWTV X-Received: by 2002:a17:902:7803:b0:1d4:133d:6ace with SMTP id p3-20020a170902780300b001d4133d6acemr8061995pll.7.1704336963197; Wed, 03 Jan 2024 18:56:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704336963; cv=none; d=google.com; s=arc-20160816; b=UlFWskGiZpqm1WBvMX79gN84oLZwUR0xst2wpI36zL3ZBoaH7ZUn4OWrNNMMoyjux2 wT6B+Vx0C5TPkFPkI5ubIvYIr6Ef3uS+7Qi5aEoJ/DHQrFv85UjSQjk8FfgX1Ruzyc8e dCsW1lT5CqtY8V4G0UGTNOd9LrQyrriPIA9OMfr+cuVP3CTfDkJ65qXpGHtl1ZcJC/Hf OW4mKBrKsaP7V+SjUsmUbDO/ymxAGi59rdKdzA0Z315JwoxrvHNQgRavgmHq+ybFJJ+C JyEftQ7PCEggzLGM15wTI/bXX+kvozy4JKQyBPgQRpT7oPPWtpkfqglwsXXAL9LQlzV9 V3yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=d/ZyyrczRRAg41dHk676oMumSI1/RuUVWYEm5uVQf9A=; fh=TXrzAYJh9FX/xQr21WBYoqiDMHTz97esVkujXgd6Bgs=; b=N+ADk/9TrKvfYDbCk2AtzkXb9uGaKf1Y8OcWQKrFvfQ4fbpc8rn//jgjhgax3UG8DM A99p6ozxW2tfaCS+pHj7004BLwNWXUXow6Tr71Ve5fw1OVP7Oy0Al2pqKoHl1A+5sauQ gGw/oPGQHxxh00sLnNFvHWIiItevn7B/TFod5uEzWJkq3jGqYFW6MrUj8818sT+wpF1W vePQ9BylIYeSsLxzPfmIB26KwQZuiPpwiDViGIYbU8L2bUb9/KOaBAR2ZLx/ZaBds7BS 5Cx4Y1HNVDHBzpKbG6X5+iEAlLJ2EuJI2aOI9x0ziAU+zJmMDVHU64OfXSlcbtFmFOMr PF3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Kezb9ASk; spf=pass (google.com: domain of linux-kernel+bounces-16215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16215-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id n16-20020a170902969000b001d065c68f06si1061929plp.494.2024.01.03.18.56.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 18:56:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Kezb9ASk; spf=pass (google.com: domain of linux-kernel+bounces-16215-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16215-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C4519B22ED7 for ; Thu, 4 Jan 2024 02:55:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1EFCB18041; Thu, 4 Jan 2024 02:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Kezb9ASk" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B176D111A7; Thu, 4 Jan 2024 02:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d/ZyyrczRRAg41dHk676oMumSI1/RuUVWYEm5uVQf9A=; b=Kezb9ASk4oEH4XR0eJzJzv5hSZ 2MHZYHHVOAOZaIQfKvgIhS3/QnU4aNQEsIDTRmj54EIrDAmHV20po0OfqfITzTJQKpCieuHEPhNK3 pvc0SQS3rC+vet3misG0FmIeF+yrKih7FBICbQCluyM5i1UxaiosseLqexKaN2z6YZ8FMZJY4cjyN 9JhFnUMkr67PYeCvjQr0WJFl8ybL2qv6KCjqdj8D/7rwnpYrqfuBmLKQg2OzG6QdvA/Nut6u7n3eG QfZVOv5fbYTurJvbys1v3Ydwmfc4chjHaMDVoIH1T5Hw/H/A9twSB4UdyTzZ7i6h58Frjw9vwExuN k72lEOKA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rLDtW-00E7Ni-Bx; Thu, 04 Jan 2024 02:55:42 +0000 Date: Thu, 4 Jan 2024 02:55:42 +0000 From: Matthew Wilcox To: Hou Tao Cc: linux-fsdevel@vger.kernel.org, Miklos Szeredi , Vivek Goyal , Stefan Hajnoczi , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, houtao1@huawei.com Subject: Re: [PATCH] virtiofs: use GFP_NOFS when enqueuing request through kworker Message-ID: References: <20240104015805.2103766-1-houtao@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104015805.2103766-1-houtao@huaweicloud.com> On Thu, Jan 04, 2024 at 09:58:05AM +0800, Hou Tao wrote: > static int virtio_fs_enqueue_req(struct virtio_fs_vq *fsvq, > - struct fuse_req *req, bool in_flight); > + struct fuse_req *req, bool in_flight, > + bool in_atomic); Better to pass the gfp_t directly instead of a bool.