Received-SPF: pass (google.com: domain of linux-kernel+bounces-16228-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231215235638.19189-1-rdunlap@infradead.org>
In-Reply-To: <20231215235638.19189-1-rdunlap@infradead.org>
From: Zack Rusin <zack.rusin@broadcom.com>
Date: Wed, 3 Jan 2024 22:31:03 -0500
Message-ID: <CABQX2QMm4ovL51sLOgi-bFtctLUgXuw-T2m0Qcja41HaR3XKkQ@mail.gmail.com>
Subject: Re: [PATCH] drm/vmwgfx: fix kernel-doc Excess struct member 'base'
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>, 
	dri-devel@lists.freedesktop.org, 
	VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>, Maxime Ripard <mripard@kernel.org>, 
	Thomas Zimmermann <tzimmermann@suse.de>, Zack Rusin <zackr@vmware.com>, 
	Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 6:56=E2=80=AFPM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> Fix a new kernel-doc warning reported by kernel test robot:
>
> vmwgfx_surface.c:55: warning: Excess struct member 'base' description in =
'vmw_user_surface'
>
> The other warning is not correct: it is confused by "__counted_by".
> Kees has made a separate patch for that.
>
> In -Wall mode, kernel-doc still reports 20 warnings of this nature:
> vmwgfx_surface.c:198: warning: No description found for return value of '=
vmw_surface_dma_size'
> but I am not addressing those.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150701.kNI9LuM3-lkp@i=
ntel.com/
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Zack Rusin <zackr@vmware.com>
> Cc: VMware Graphics Reviewers <linux-graphics-maintainer@vmware.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff -- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgf=
x/vmwgfx_surface.c
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c
> @@ -44,7 +44,6 @@
>   * struct vmw_user_surface - User-space visible surface resource
>   *
>   * @prime:          The TTM prime object.
> - * @base:           The TTM base object handling user-space visibility.
>   * @srf:            The surface metadata.
>   * @master:         Master of the creating client. Used for security che=
ck.
>   */

Thanks, looks great. I went ahead and pushed this one to drm-misc-next.

z