Received-SPF: pass (google.com: domain of linux-kernel+bounces-16238-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
To: Chanwoo Lee <cw9316.lee@samsung.com>
Cc: mani@kernel.org, agross@kernel.org, andersson@kernel.org,
        konrad.dybcio@linaro.org, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-arm-msm@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        grant.jung@samsung.com, jt77.jang@samsung.com,
        dh0421.hwang@samsung.com, sh043.lee@samsung.com
Subject: Re: [PATCH] scsi: ufs: qcom: Remove unnecessary goto statement from
 ufs_qcom_config_esi function
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1edexagl0.fsf@ca-mkp.ca.oracle.com>
References: <CGME20231219082757epcas1p33bda4e0723d3d57552132054d3e5a3fe@epcas1p3.samsung.com>
	<20231219082740.27644-1-cw9316.lee@samsung.com>
Date: Wed, 03 Jan 2024 23:05:39 -0500
In-Reply-To: <20231219082740.27644-1-cw9316.lee@samsung.com> (Chanwoo Lee's
	message of "Tue, 19 Dec 2023 17:27:40 +0900")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?T9NATcs3/OA9y1McL5srKqnAd4yrSQDWOc2xYxpOBdIGRwOjheTPwyoun5PB?=
 =?us-ascii?Q?0aqk15MIcfEiuokmJ8a62rpT13Lm19/HqVtIb7JSPVNGGbURcQoe6KDAhw/o?=
 =?us-ascii?Q?9AxIPWrDwOzhkawkauZ8SfqxcncQs2XgoZDe6nv9gWGB1gcZRyD3whEHWPej?=
 =?us-ascii?Q?SQjlSkRed2KUmSD1tMvuyepLpyFlgKCZUmL+xzwSHf13vO2BTgR0Z07oW/6n?=
 =?us-ascii?Q?qlk1JYROZFvzL38dKvvq99e948H1bzbq+D8+tQk8KdNMeAngUFZVohiiU4G3?=
 =?us-ascii?Q?wK4X4cU8/wIQ8gCX/0V18oErVEITh/EA78nCOHVsNLNV0XBBylePyND31sVo?=
 =?us-ascii?Q?UrJiPtrLMBbBvAkAU53zk+wkIKtb/8ysdwr+Mq9XR1mxGxw9MRElUnazatam?=
 =?us-ascii?Q?RCplPFTlJ8tTOe/AmBGz56qCdHaJQZSFv9SMPM5S7Cd5xUxwp2hYgLVeFFqb?=
 =?us-ascii?Q?+KbBHJiLum/dpPONAlEmVL+u+xkvq11563TbPlZQTsjWgusQB0dzx1QOiYvI?=
 =?us-ascii?Q?XlGox0vvEcikqHEu1Xe12/9rWKsCdJowzSWpIswD25hjAklrb9MPGr+OQ53j?=
 =?us-ascii?Q?IGtckXJZP8rhizDvVsyzsnuxTXKDj3/SelEv7nXi6Mgrxqvipr+rTDVsexn6?=
 =?us-ascii?Q?xFhil5NQtxjk05rPDWla8RurYnjh1axy+B6O/MWFNtiTQM4Jdw1CQuw7m/Gx?=
 =?us-ascii?Q?YXx5iJN81TdmxKBIwDKr8rIdMLjbX9dZQMBjGXWgc3pu7knx6N2eV/UFAFET?=
 =?us-ascii?Q?FmFRxu7OJTtkHAOjiQNpIKSkTKSW/XU+zZhyavNNKl19qwIFFRmt4qazTB/g?=
 =?us-ascii?Q?sr8INFmVt27nVFIaL8a2pqvNgI/vaKwZrOvaNaiM8fKWTuTj2a29GOdGYFb5?=
 =?us-ascii?Q?VeKaA6jWhPwMqOEZLp2u28lzGXiRzFCAnHYrQRcSjHG+ffdyuD5vegcQbw/J?=
 =?us-ascii?Q?olYgHneHKK+zZDtP8PILBPRQUduW2ZEuQveBKpDB5LIZpfJq5btHR2xo0xpZ?=
 =?us-ascii?Q?uaJ4QW/8exIiG6wG/tOH2JvcUGor/Q47MIC/mXTYjCX0nKscdohhX97gvrsH?=
 =?us-ascii?Q?Lq8trGFK8qvIZCwY8EZI/pe7jTIWEebkt5XeMS+pAwH906lJzTigfdTWLYTh?=
 =?us-ascii?Q?Y044qR5vNMfv9l3CTgMb+ZDaCdkGBMJguNMNVMtTnb9+2ieuR0CsMFeAmS4s?=
 =?us-ascii?Q?snNOxrgx6ANoIzfACHEFlc9SC4piLI1OjCtkXYqqGYbdMHcWjTkrhmz1HOll?=
 =?us-ascii?Q?fiBmh4qAdGbsMQe5AgRmge2B/5l/7aXIKX2qdwzTXdLPlDnM6z7Su/g0qCdX?=
 =?us-ascii?Q?GF0pQ+jGwQz1JSC6YS+kIUmabGHnB2ceIemrvwCGHQWrEKcOxOKwGz1Cm8RK?=
 =?us-ascii?Q?McL6yTEvE2xSwnY8tqd64L52kHz7uCZkePgzoIuqVppOi25zy1YfAes3viPP?=
 =?us-ascii?Q?fbDByf4zKnfp3oulWeDZLKqVagzj7xtinuMvOmS8g8Udjlkqd6l5A+gN8Tmk?=
 =?us-ascii?Q?e6FHzfE4a7i0qTgUGfKoN8u9SduEpPegZm9tl48/NyhlOweLrUv1Gj6ppq9x?=
 =?us-ascii?Q?qfAUg/dJagPh91oCU9nVK5YX8iUxUErO/LCkJPS2MUiEUgWQHa4XeS8iNwwC?=
 =?us-ascii?Q?Jw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	iPYh38Hj+3yuwDJyUfWL4QVYva/ng9IL1RP1Y/pYIXFgV3VfsGBPyp2p+yjpYLmfgj2spqIfp4ni04zS4ojzOSPCcinDxxTCNx+zTYTn8Y6dYfUJtomTSsytgERvwWgB3UOK0w6gLcDjKZXszQQy5er863BfXFNVPzQafR47jOgMdoMiByQ21tlC09G0NlKZVUkqMt64+N/6v9V/x/+gndmQ5LKSC3Pzr/hJambkDDOkrzwun6jDDF3EluI/x8DyWUVl4zxzrvrk382Ob9Kk3fxzePwSbyLDzMijfml3UHQLBhxJ7KeI8LwiQeXfJlZJCiIF/FjlRsdO05wPTSUNdsnsih1UsrF1qf0ZeASrsGdX/BiqVJXAJKNLF8Y+SoubMYeRuaA43ujVMILvQoWIkhEK+Cw4Ie3QR6tWx6xD5P4SVpWIecJ/HywhitmwIrs+uj39ZUFyBCfs2/BybsjIKy2Q5nZMS0Wy8ph8PrWD5Pdtb9rw9LdAfA6WU47aWf9k/eo5XI91ou+oNjEw4qco0Trcs9YJRkun6XJoamUGbfTfycMQYVZl4St7CwL0DrHk0REhAwnzE2KOYtGw0C22GiUJxm3yepWrSDnshhIpfFE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa8cb15-9fca-48cb-8d10-08dc0cda6ac2
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 04:05:41.4394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GsglukZdPpEzgc7PsLwZdzzLaTnKS7Gu89M6SMqTj/jboAkl/6BMERix1YMdya0PN+CdpuuwL/VEqnyxSX5HmnoJl4mfjZHgUCHz0F9DtAM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7098
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-03_10,2024-01-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0
 bulkscore=0 mlxscore=0 mlxlogscore=960 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401040024
X-Proofpoint-GUID: CxXGC3qWUGILQmKhidXlw5d4vw1W6DLK
X-Proofpoint-ORIG-GUID: CxXGC3qWUGILQmKhidXlw5d4vw1W6DLK


Chanwoo,

> There is only one place where goto is used, and it is unnecessary to
> check the ret value through 'goto out' because the ret value is
> already true.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering