Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7517699rdb; Wed, 3 Jan 2024 21:06:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0TKABWzNZJSaL4ik/fc29D2OTj0OHVEEb3x8l58EX9WUhESYUrIaxEpq8cSUP67dnUU2o X-Received: by 2002:a05:6a00:1d10:b0:6d9:ac48:1ed4 with SMTP id a16-20020a056a001d1000b006d9ac481ed4mr79540pfx.46.1704344768427; Wed, 03 Jan 2024 21:06:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704344768; cv=none; d=google.com; s=arc-20160816; b=Nrp/mQ33LhMIyHS6hzrl+36D7QK951EncmuAgbfsy0L9VZefM2kBZBImEkhn5A/0I2 92jZy52uVkUC2tZw8YOnf7fWjcIk1dGZ07v6I+a9rF6KFzx7+UQaPjFSVIwxd9WHzLgg BZSMP/LP9mYn8HwhsJ0c7umeZWKresfTJcYMV+S95/ekXLCW8tEaWdCINYsi514gqFwB 1VIoQKp85pbGojJoWoFAv5qblF73RxygT3EHRtz9Dhe9SdFXnFp3fymr+2Ln5vl5SSyy vo6kMnu0nF9beaDpokWGFJhzsTpeTw1CmbhxAn7wdW/yc6sSff/BW+jFTC4+eP2JCPnS GyRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=fgG3RR6ns0CBYeFcOflZPGhr9fVyxh18ERVWnEeDq2I=; fh=ZRDEuF5Nmsel7lTaYPm1IS6N4gF9ZV1np5mbF1XfBvg=; b=OAjXtv/WLPwbOwl/lwuA5SQHvYeOwI/vkpcISybAtJMEZGlxC2pyilIfebDouoOck8 K+bb2bwRxAe2JDCBv1hZEcr8n2IaAQU9Me/B3bV9y6ewXtqQMrFG+kohgMHqDpuoH5nR LMbKm99Gcb81HSEgRVa6tl0/HE19j4pUXSqL1A9mDxMgW6lGQm1ibAUZgGwrtYMn8bT3 ytCllwnVBrWoo1Dy4KdjDMNS365jjfPa6tCeEw5pIGUjJF18QEI66GMndBYbrF1T2snQ hvslltCY3Ze92dR783d6PNmS4k33JImihUiGo6vMq1v1se/eGMhb5x+FNdS8SNHTFwNf cWFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@faucet.nz header.s=fe-4ed8c67516 header.b=bD8WH9+R; spf=pass (google.com: domain of linux-kernel+bounces-16250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=faucet.nz Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bs128-20020a632886000000b005cdbeb8228dsi22141760pgb.433.2024.01.03.21.06.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 21:06:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@faucet.nz header.s=fe-4ed8c67516 header.b=bD8WH9+R; spf=pass (google.com: domain of linux-kernel+bounces-16250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=faucet.nz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5C177B24DA8 for ; Thu, 4 Jan 2024 05:06:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55C8A1D521; Thu, 4 Jan 2024 05:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=faucet.nz header.i=@faucet.nz header.b="bD8WH9+R" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2D881B28D for ; Thu, 4 Jan 2024 05:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=faucet.nz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.faucet.nz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=faucet.nz; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From; q=dns/txt; s=fe-4ed8c67516; t=1704344723; bh=fgG3RR6ns0CBYeFcOflZPGhr9fVyxh18ERVWnEeDq2I=; b=bD8WH9+RlN16hufHYZMF/07I1gDRj1hle6W3s03f4PUUs5TBcdZMWg77G81nW8IXnYW8zJrfp qffgW/rBq5U7pmDVGhhjtmfDdMJzvwTSaJ+SfojoB3cKBohlCltfDhDbMKjCNEHCsricsYsCEA8 uf/zDa6ghvZxxOjsMcdnUbo= From: Brad Cowie To: aconole@redhat.com Cc: brad@faucet.nz, coreteam@netfilter.org, davem@davemloft.net, dev@openvswitch.org, edumazet@google.com, fw@strlen.de, horms@kernel.org, kadlec@netfilter.org, kuba@kernel.org, linux-kernel@vger.kernel.org, lucien.xin@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, pabeni@redhat.com, pablo@netfilter.org Subject: Re: [PATCH net] netfilter: nf_nat: fix action not being set for all ct states Date: Thu, 4 Jan 2024 18:04:52 +1300 Message-Id: <20240104050452.808076-1-brad@faucet.nz> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Report-Abuse-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Complaints-To: abuse@forwardemail.net X-ForwardEmail-Version: 0.4.40 X-ForwardEmail-Sender: rfc822; brad@faucet.nz, smtp.forwardemail.net, 149.28.215.223 X-ForwardEmail-ID: 65963c921192512af6adefb7 On Wed, 3 Jan 2024 at 04:10, Aaron Conole wrote: > LGTM. I guess we should try to codify the specific flows that were used > to flag this into the ovs selftest - we clearly have a missing case > after NAT lookup. Thanks for the review Aaron, and the sensible suggestion to add a test to ovs to avoid this problem occuring again in future. I've simplified our NAT ruleset and turned it into an ovs system test, which I've submitted as a patch [1] to ovs-dev. The test reproduces the issue introduced by ebddb1404900 and passes when e6345d2824a3 is applied. [1]: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html