Received-SPF: pass (google.com: domain of linux-kernel+bounces-16258-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231215060159.555229-1-ghanshyam1898@gmail.com> <e9b028b3-20e6-4e74-a305-c4f18efc70e1@infradead.org>
In-Reply-To: <e9b028b3-20e6-4e74-a305-c4f18efc70e1@infradead.org>
From: Zack Rusin <zack.rusin@broadcom.com>
Date: Thu, 4 Jan 2024 00:18:17 -0500
Message-ID: <CABQX2QO0mPD3KYZYVk+cEr1z9o_cjRM9nct7piZhD4oJEm2hZg@mail.gmail.com>
Subject: Re: [PATCH V2] drivers: gpu: drm: vmwgfx: fixed typos
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Ghanshyam Agrawal <ghanshyam1898@gmail.com>, zackr@vmware.com, 
	linux-graphics-maintainer@vmware.com, maarten.lankhorst@linux.intel.com, 
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, 
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 15, 2023 at 1:21=E2=80=AFAM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> Hi--
>
> On 12/14/23 22:01, Ghanshyam Agrawal wrote:
> > Fixed multiple typos in vmwgfx_execbuf.c
> >
> > Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
> > ---
> > V2:
> > Fixed some more typos suggested by codespell
> > and the community.
> >
> > V1:
> > Fixed multiple typos
> >
> >  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/=
vmwgfx/vmwgfx_execbuf.c
> > index 36987ef3fc30..76aa72e8be73 100644
> > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> > @@ -127,7 +127,7 @@ struct vmw_ctx_validation_info {
> >   * @func: Call-back to handle the command.
> >   * @user_allow: Whether allowed from the execbuf ioctl.
> >   * @gb_disable: Whether disabled if guest-backed objects are available=
.
> > - * @gb_enable: Whether enabled iff guest-backed objects are available.
> > + * @gb_enable: Whether enabled if guest-backed objects are available.
>
> "iff" normally means "if and only if" and its use in the kernel sources i=
s
> usually not a mistake. However, this one sounds dodgy to me (before your =
change),
> so it's OK IMO. Also, the line above it uses "if" for a similar comment.
>
> Maybe someone else knows better.

Right, this one was "iff". I submitted a version of this without the
iff change to drm-misc-next.
z