Received-SPF: pass (google.com: domain of linux-kernel+bounces-16368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 4 Jan 2024 09:30:22 +0100
From: Johan Hovold <johan@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>, Andy Gross <agross@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v5 02/12] clk: qcom: Use qcom_branch_set_clk_en()
Message-ID: <ZZZsnvjTsmMrUwWt@hovoldconsulting.com>
References: <20230717-topic-branch_aon_cleanup-v5-0-99942e6bf1ba@linaro.org>
 <20230717-topic-branch_aon_cleanup-v5-2-99942e6bf1ba@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230717-topic-branch_aon_cleanup-v5-2-99942e6bf1ba@linaro.org>

On Wed, Jan 03, 2024 at 02:36:00PM +0100, Konrad Dybcio wrote:
> Instead of magically poking at the bit0 of branch clocks' CBCR, use
> the newly introduced helper.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/clk/qcom/camcc-sc8280xp.c     |  6 ++----

>  drivers/clk/qcom/dispcc-sc8280xp.c    |  4 ++--

>  drivers/clk/qcom/gcc-sc8280xp.c       | 25 ++++++++++---------------

>  drivers/clk/qcom/gpucc-sc8280xp.c     |  9 +++------

I only reviewed the sc8280xp ones, and with the updated comment this
looks good to me now:

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>

Johan