Received-SPF: pass (google.com: domain of linux-kernel+bounces-16410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Jack Allister <jalliste@amazon.com>
To: <usama.arif@bytedance.com>
CC: <bp@alien8.de>, <corbet@lwn.net>, <dave.hansen@linux.intel.com>,
	<hdegoede@redhat.com>, <hpa@zytor.com>, <jalliste@amazon.com>,
	<juew@amazon.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <mingo@redhat.com>, <paulmck@kernel.org>,
	<pdurrant@amazon.com>, <peterz@infradead.org>, <rafael@kernel.org>,
	<rdunlap@infradead.org>, <tglx@linutronix.de>, <tj@kernel.org>,
	<x86@kernel.org>, <yanjiewtw@gmail.com>
Subject: Re: [PATCH v5] x86: intel_epb: Add earlyparam option to keep bias at performance
Date: Thu, 4 Jan 2024 09:00:22 +0000
Message-ID: <20240104090022.41499-1-jalliste@amazon.com>
In-Reply-To: <a57b9e19-3466-bb73-1c88-c19417ac6822@bytedance.com>
References: <a57b9e19-3466-bb73-1c88-c19417ac6822@bytedance.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain

> Thanks for the patch. Is auto needed over here? It was pointed in an 
> earlier review that it could be an option, but it doesn't seem to serve 
> a purpose.

Auto is effectively just the default as if no parameter is passed in here.
In the reply from Dave for he has mentioned that displaying it like this
may actually be clearer.

```
	intel_epb=	[X86]
			
			auto (default)
```

As we're not implicitly not taking any action for this default case it
doesn't make too much sense to add in a specific strcmp case for auto,
however what I can do is add a comment within the code to explicitly show
that this is effectively a no-op when parsing.


> Maybe add an print in else here to say that unexpected value has been 
> encountered for intel_epb if preserve is not seen.

I'd be hesitant to do this as we already have the pr_warn_once during the
intel_epb_restore path when defaulting from perf -> normal.