Received-SPF: pass (google.com: domain of linux-kernel+bounces-16449-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 4 Jan 2024 11:34:28 +0200
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: gts-helper: Fix division loop
Message-ID: <ZZZ7pJBGkTdFFqiY@dc78bmyyyyyyyyyyyyydt-3.rev.dnainternet.fi>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZBhXKsBwY+mTdV5C"
Content-Disposition: inline


--ZBhXKsBwY+mTdV5C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The loop based 64bit division may run for a long time when dividend is a
lot bigger than the divider. Replace the division loop by the
div64_u64() which implementation may be significantly faster.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")
---

I've implemented also a fixup series for supporting rounding of
gains/scales:
https://lore.kernel.org/lkml/37d3aa193e69577353d314e94463a08d488ddd8d.17017=
80964.git.mazziesaccount@gmail.com/

That series does also remove the offending loop.

We don't currently have any in-tree users of GTS helpers which would
need the rounding support so pushing the rounding is not urgent (and I
haven't heard of Subjahit whose driver required the rounding). Hence, we
may want to only take this loop fix in for now (?) and reconsider
rounding when someone need that.

Jonathan, what's your take on this?

 drivers/iio/industrialio-gts-helper.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrial=
io-gts-helper.c
index 7653261d2dc2..abcab2d38589 100644
--- a/drivers/iio/industrialio-gts-helper.c
+++ b/drivers/iio/industrialio-gts-helper.c
@@ -34,7 +34,7 @@
 static int iio_gts_get_gain(const u64 max, const u64 scale)
 {
 	u64 full =3D max;
-	int tmp =3D 1;
+	int tmp =3D 0;
=20
 	if (scale > full || !scale)
 		return -EINVAL;
@@ -48,8 +48,7 @@ static int iio_gts_get_gain(const u64 max, const u64 scal=
e)
 		tmp++;
 	}
=20
-	while (full > scale * (u64)tmp)
-		tmp++;
+	tmp +=3D div64_u64(full, scale);
=20
 	return tmp;
 }

base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
--=20
2.41.0


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--ZBhXKsBwY+mTdV5C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmWWe5QACgkQeFA3/03a
ocVoKwf+JqwM+uOPd3l+ECkvm1GhHX2OsknGaOa2lMTHeXBlDRKhYvR5694Z7eSj
XLsmOLS1WIwmrffFpprksh7DXTXfQp9pwLIjmh8BFjP/dCkBowBMw/O8E74Cpe3b
gHU77BC09IAYlKNeS2fQBbrVlVSzkb8mma1MmISvs4pNaV+4DmdTWSoYn2n1mqcS
s0DCjDOW3dXOrU57TtfJma9M3SGIalXLhj8DUqZji4zHTO+u7w0aPF7iJuiHnYUF
tWNS5f6rZ+JGa4Fph/T0LFXblQ85v7yGdubrU5cITRf8vvSFP+wQlBusWTd+oqMx
Fwh+rKlRQnhMo7P6SuZCau3HW+kSDA==
=4zw1
-----END PGP SIGNATURE-----

--ZBhXKsBwY+mTdV5C--