Received-SPF: pass (google.com: domain of linux-kernel+bounces-16461-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Gan, Yi Fang" <yi.fang.gan@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Halaney
	<ahalaney@redhat.com>, Javier Martinez Canillas <javierm@redhat.com>, "John
 Stultz" <jstultz@google.com>, "Rafael J . Wysocki" <rafael@kernel.org>, "Jens
 Axboe" <axboe@kernel.dk>, Russell King <linux@armlinux.org.uk>, "Heiner
 Kallweit" <hkallweit1@gmail.com>, "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, "Paolo
 Abeni" <pabeni@redhat.com>, =?iso-8859-1?Q?Marek_Beh=FAn?=
	<kabel@kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Looi, Hong Aun" <hong.aun.looi@intel.com>,
	"Voon, Weifeng" <weifeng.voon@intel.com>, "Song, Yoong Siang"
	<yoong.siang.song@intel.com>, "Lai, Peter Jun Ann"
	<peter.jun.ann.lai@intel.com>, "Choong, Yong Liang"
	<yong.liang.choong@intel.com>
Subject: RE: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()
Thread-Topic: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()
Thread-Index: AQHaM+tcmnrQCuQ6Q0WT+EJT7YP9o7CzdqWAgBYFSWA=
Date: Thu, 4 Jan 2024 09:45:47 +0000
Message-ID: <MW6PR11MB8310E51E5EEDA8EE98BC37D4B967A@MW6PR11MB8310.namprd11.prod.outlook.com>
References: <20231221085109.2830794-1-yi.fang.gan@intel.com>
 <20231221085109.2830794-3-yi.fang.gan@intel.com>
 <0f85171e-cb9c-47dd-bb7d-f58537e24a54@lunn.ch>
In-Reply-To: <0f85171e-cb9c-47dd-bb7d-f58537e24a54@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?BsohoVKKaiw/cQ/JLqtyM0Z/Ld+iN/LrFPrJm45iuLSz3oZvuHPRznUOaE?=
 =?iso-8859-1?Q?cUwca20gWJKjajPDpo2Ph6lGrlOgG1ENy1KPBuSL3gZwuyDqe69xExU10L?=
 =?iso-8859-1?Q?jki8ikN3293psSJcIw7ZGtAklXUv9rxfptPBzRr8cAclvdi2PHmzK4YB/k?=
 =?iso-8859-1?Q?ciaDe7s/1nt/IYGo7RtIWfYMMuWrIWq5J9EeciMHyZHZoVt7ifjvBLiMRU?=
 =?iso-8859-1?Q?o1eMCXSPhIw5+ufIdvoU+OpE9fVyb6v64H+rUj9WL6LVP07Ol6wpAHjqE5?=
 =?iso-8859-1?Q?O6qQnHyau4xSNG7dOKiOO2SNOwi81WNyNZ/CBT7/Y3zWepjz9aVkI05idr?=
 =?iso-8859-1?Q?EKWUyhkVbWjTDFgoB+1qXwFSyKcxDstvqJxB984g4Dk0/9n3Kohl6ppltA?=
 =?iso-8859-1?Q?qSFPdq+Bb74xre4xLDOFxae7H1aAKcUdNxBgH6HF7kciWOZITjZy/mduEe?=
 =?iso-8859-1?Q?Soq6s2vH2WNDdfX38lPhaNVhAf0jo2SYaOOtgTL794bfO5Y3tLQi63rE69?=
 =?iso-8859-1?Q?MU1OUfrawh6Oy3GVU31m2zOlK1bxjIybKytrQwWjvNcScAaTHxu9PbV5eI?=
 =?iso-8859-1?Q?reCDzg+551dEw0PLS53yS2KNuuvFcvExkj435PNonTm4ERKevnYTn/LFbG?=
 =?iso-8859-1?Q?iBmwUjjkjwqxEbhKnJn9YHOoAdbaxoP9HQM1JYEKcaGlmg1nGHUywhlycC?=
 =?iso-8859-1?Q?smHdUNlJ6YTDp2SAH6vsf+EWOSurocggxBr+Jt5IUZw7n2yyyTut7bsGor?=
 =?iso-8859-1?Q?ZpzbHOtgx9eJp7txkpLMT6dHRtOZb9oORYPdR0Bgb4DbuOD5wfDb2KAc/Y?=
 =?iso-8859-1?Q?jZLqv+5z+wGjw6O7y04jdFplHG+nsu5Ob/W3KnHmc4Cb6GteFyQe4nmFcT?=
 =?iso-8859-1?Q?+Dx/H0Z6LXqZ9eUlQ4K1OBaICNQa1J4c8Q76W02BSn0hgCJZnRPfMjPjWo?=
 =?iso-8859-1?Q?V9qMamk3JlE3XCqV9KhrtIaulAsZi2xdLRpCdbiTg1bcQPCfUWvSo5YWPI?=
 =?iso-8859-1?Q?pKSz8OxDDSq/sXo8tVTPBaTyBVnKeRQUvilKd93W1DYg/aBjUcgokRyE26?=
 =?iso-8859-1?Q?wiBvScBWgqFKIjC2Xkr8yZMptvgCaCv8d1HABJshTB9BnQZEEXXRUtxSQY?=
 =?iso-8859-1?Q?RkbdLiP7Iaw5YhXqnAtABfCtWGzReO/z9lB2HYuHV8kiedYKbKUrCfH/L5?=
 =?iso-8859-1?Q?sZQrIcjyT5MI/dVXMK9/1UHfcDucRzpU42QWb3S8dkfinGPF2ee5Lw4wHT?=
 =?iso-8859-1?Q?9To0+e9/IcoG5izulVVi7tNLfwRnDmU18xTiWa+NvYpWTHUEcy4d5jICW6?=
 =?iso-8859-1?Q?0+2p6Y3MzoO/i58zaGdngnZV8hJAihUWHZUnlpbevxtcQMfmnk15KBrI/C?=
 =?iso-8859-1?Q?h1cxiF1ZNOcj3s2od/+rJ8nGIcLoqd9FDG26h1FdZQVDkQV/K92ezsL77Z?=
 =?iso-8859-1?Q?CsY5KvwnmrchxR8HJ8quBEt1Cp40OGu666xry7F9ervzr6icbBAVCx+BNA?=
 =?iso-8859-1?Q?wpQNTpw55mWGNyZX6EYjs5rGHjcoCXEMLsl/KiJZG/e8lt9NgsoFCZw2XR?=
 =?iso-8859-1?Q?b6jJp55+vrrJBkBhTkhGI/ocRP7zJKSG0JrcQWhYzC5iZz+H0ajgLxzQqX?=
 =?iso-8859-1?Q?tdYDqnVemmmMLYe51jpp4tWLtYFbjPU61D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW6PR11MB8310.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc470d5-b3cb-4e35-e715-08dc0d09edfd
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2024 09:45:47.7925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gPKRna2Rvah6Ym2yPUa48WcdA9vxBG0OzUnneBnhfLJvRXOPXB0SY8MElaw4eWeFjPqXE6ZmOQ6vjWShFA/qxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7046
X-OriginatorOrg: intel.com

Hi Andrew,

The function phylink_init() is introduced by others.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=
=3Dlinux-6.6.y&id=3Deca68a3c7d05b38b4e728cead0c49718f2bc1d5a=20
The module_exit() is added by referring to
https://elixir.bootlin.com/linux/latest/source/kernel/module/main.c#L738.
Since the macro function is rejected, I will send a V3.
Let's see if Rusell King has any comment. Thanks.


Best Regards,
Gan Yi Fang

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, December 21, 2023 5:23 PM
> To: Gan, Yi Fang <yi.fang.gan@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Andrew Halaney
> <ahalaney@redhat.com>; Javier Martinez Canillas <javierm@redhat.com>; Joh=
n
> Stultz <jstultz@google.com>; Rafael J . Wysocki <rafael@kernel.org>; Jens=
 Axboe
> <axboe@kernel.dk>; Russell King <linux@armlinux.org.uk>; Heiner Kallweit
> <hkallweit1@gmail.com>; David S . Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Marek Beh=FAn <kabel@kernel.org>;
> netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-
> arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Looi, Hong =
Aun
> <hong.aun.looi@intel.com>; Voon, Weifeng <weifeng.voon@intel.com>; Song,
> Yoong Siang <yoong.siang.song@intel.com>; Lai, Peter Jun Ann
> <peter.jun.ann.lai@intel.com>; Choong, Yong Liang
> <yong.liang.choong@intel.com>
> Subject: Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub()
>=20
> On Thu, Dec 21, 2023 at 04:51:09PM +0800, Gan, Yi Fang wrote:
> > In delete_module(), if mod->init callback is defined but mod->exit
> > callback is not defined, it will assume the module cannot be removed
> > and return EBUSY. The module_exit() is missing from current phylink
> > module drive causing failure while unloading it.
>=20
> You are missing justification it is actually safe to remove phylink. Mayb=
e Russell
> King deliberately did not implement
> module_exit() because it can explode in interesting ways if it was?
>=20
> 	Andrew