Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7617140rdb; Thu, 4 Jan 2024 02:08:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvqdfa6zAHvH5Y92s7wAqbDTXXPP8whyHE+/qNycqtdoxgVjRauqy11mIBHdtWFF/C2HAf X-Received: by 2002:a17:906:a153:b0:a28:d144:cda1 with SMTP id bu19-20020a170906a15300b00a28d144cda1mr171897ejb.145.1704362897409; Thu, 04 Jan 2024 02:08:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704362897; cv=none; d=google.com; s=arc-20160816; b=XDqznRgRKBPePeKPFCBJiUTI2ungSrpiKAZwL+MTNtUSZN1ecMDWt7BT5Ua4USn4JE fKg4BB5vTeAIMxVAg/8MKeeind5ntJr/E0q5MU3nQjDptNKvkP1+jUumtQ5IIXqI3uEC 2QGtoa+i12EkXHK46wS0cXl7MFUD4h83WD0kXE1ScZMeiKLYL8epqS5+CL9xEgiUGQVz ON8TClG7iaO/efWLXsdH76cl+J4XCJXjz5pmI96HZjzxRVV2JrmY72slEuEfHedFyUCQ 8kd9JZG92WXQym+4qyhM/g8kz8dEcdNGHT3tg6/ukWI/RPWHdTApItxErpN2DT3pCweU QQAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=/uwrmr2Zap5JQoCTLstjtQh9E89u2t2zie20KtNedw4=; fh=rjNwUWYKl5jAjg7BCa2PHudK5aU0nDcPj4ULaTf7wVM=; b=FCQpxfWOta28OXpzAq+pXqxeda+ufNwTOfWIk0P/e1qJJcxUYGQQ20WPikTmiQukBK DBcFSrLZowA1pxWL4icENZEN9Fe54SW3C0m929iRROUZuGMC2b6dYtXV/hNcm/u01fIo rT2T5PIKyZOiH/4103HLit2/eAk0+kvRV9IGlKtD9YgqM1QPXtkxAPTYioHRWZIsXSSQ 8GTb7fLfIyIZeSK8rGERfS1q9PykFrnraq9PXRXpm83fIKmeqDiDDBj0jIoQeblwn0HF qxyngCkHIFnpOjBUuQDKOYvigUc0KVM7PWA6ziRdvPxVpG9vvKyLNIsTTc5Q8X6hMcIY 41FA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-16488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16488-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gi34-20020a1709070ca200b00a1d3eccb0f0si11496424ejc.428.2024.01.04.02.08.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 02:08:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-16488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16488-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 252071F24B4A for ; Thu, 4 Jan 2024 10:08:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5B44720DE2; Thu, 4 Jan 2024 10:07:37 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82A4F20B1A for ; Thu, 4 Jan 2024 10:07:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLKdN-0001FW-3A; Thu, 04 Jan 2024 11:07:29 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rLKdL-000JzL-Dq; Thu, 04 Jan 2024 11:07:27 +0100 Received: from mfe by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1rLKdL-00ACE9-AR; Thu, 04 Jan 2024 11:07:27 +0100 Date: Thu, 4 Jan 2024 11:07:27 +0100 From: Marco Felsch To: Frank Li Cc: krzysztof.kozlowski@linaro.org, devicetree@vger.kernel.org, conor+dt@kernel.org, hongxing.zhu@nxp.com, krzysztof.kozlowski+dt@linaro.org, imx@lists.linux.dev, linux-pci@vger.kernel.org, lpieralisi@kernel.org, linux-kernel@vger.kernel.org, s.hauer@pengutronix.de, helgaas@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, bhelgaas@google.com, shawnguo@kernel.org, kw@linux.com, festevam@gmail.com, robh@kernel.org, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Subject: Re: [PATCH v7 01/16] PCI: imx6: Simplify clock handling by using bulk_clk_*() function Message-ID: <20240104100727.xtwn76lhp72ika7i@pengutronix.de> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-2-Frank.Li@nxp.com> <20240102084744.tyquwp6hkb36tfxg@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On 24-01-03, Frank Li wrote: > On Tue, Jan 02, 2024 at 09:47:44AM +0100, Marco Felsch wrote: > > Hi Frank, > > > > On 23-12-27, Frank Li wrote: > > > Refactors the clock handling logic. Adds clk_names[] define in drvdata. > > > Using clk_bulk*() api simplifies the code. > > > > does this influence the clock enable/disable sequence ordering? Just > > asking to avoid regressions on older platforms which may require some > > sort of order (e.g. require clock-a before clock-b). > > drvdata::clk_names is order of enble sequence. So far we have not found > the problem. Okay, thanks. Regards, Marco